[HOLD for payment 2024-10-24] [#wave-control] [Bring copilot to NewDot] Add Copilot section to Security Settings Page

[dangrous]

Part of the Bring copilot to NewDot project

Main issue: https://github.com/Expensify/Expensify/issues/382866
Doc section: https://docs.google.com/document/d/18G6J5bl61VnVa5CoKpRXhM0MhkXDwpm87GVitZrSCVg/edit#heading=h.wdm4uvchsma7
Project: https://github.com/orgs/Expensify/projects/130

Feature Description

Manual Test Steps

Automated Tests

Issue Owner

Current Issue Owner: @lschurr

[dangrous]

assigning myself for review once it's ready

[melvin-bot]

@dangrous, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@dangrous, @rushatgabhane Still overdue 6 days?! Let's take care of this!

[dangrous]

Not overdue, draft PR up and waiting on related code

[melvin-bot]

@dangrous, @rushatgabhane 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@dangrous, @rushatgabhane 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @dangrous, @rushatgabhane eroding to Weekly issue.

[dangrous]

Still in progress, getting there~

[dangrous]

Just noting - the backend PR needed is finally on staging

[melvin-bot]

This issue has not been updated in over 15 days. @dangrous, @rushatgabhane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[allgandalf]

Please assign me here payment for review of #47984

[dangrous]

@lschurr no action needed right now but this should be merged soon and then we'll work on payment!

[fedirjh]

Please assign me for C+ PR review payment at #47353

[dangrous]

done! Given that this issue was split in 2 PRs, I think it's full payment for both @allgandalf and @fedirjh , right?

[rushatgabhane]

yes it is more of a PR based payment than issue based

[allgandalf]

No regression test/ checklist here, this was part of project, only payment remains 🙏

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[marcaaron]

The above bot message is not a drill 😄

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Popover for remove copilot and change access level #47984

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @fedirjh requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @fedirjh / @allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @fedirjh / @allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @fedirjh / @allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @fedirjh / @allgandalf] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @fedirjh / @allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

NO checklist here, this belongs to project

[lschurr]

No overdue - payment is tomorrow.

[lschurr]

Based on this comment, we'll issue full payment to @rushatgabhane @allgandalf and @fedirjh.

Payment summary:

• Contributor: $250 @rushatgabhane (please request in NewDot)
• Reviewer: $250 @fedirjh (please request in NewDot)
• Reviewer: $250 @allgandalf (paid in Upwork)

[melvin-bot]

@dangrous @lschurr Be sure to fill out the Contact List!

[garrettmknight]

$250 approved for @fedirjh