[HOLD for payment 2024-10-30] [$250] Web - Attachment - Unable to scroll video playback speed options

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with any account
3. Navigate to any 1:1 DM that has a video attachment
4. Start the video
5. Hover over the video and click on the "Fullscreen" button
6. Click on the "..." button
7. Click on "Playback speed"
8. Hover over any of the speed options and scroll the mouse wheel

Expected Result:

I should be able to scroll.

Actual Result:

Unable to scroll video playback speed options.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6635253_1728998943127.bandicam_2024-10-15_15-25-24-025.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847127321367852470
• Upwork Job ID: 1847127321367852470
• Last Price Increase: 2024-10-18
• Automatic offers:
• paultsimura | Reviewer | 104484873

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to scroll the video playback speed options while fullscreen.

What is the root cause of that problem?

The chat page uses an inverted FlatList which registers a custom 'wheel' listener (inside rn-web) and calls a preventDefault. When we scroll within the video element, the 'wheel' event is still captured by the chat FlatList. Even when we go fullscreen, the 'wheel' event is still captured by the list because the video element is inside the list.

That's why if we see the old code of PreRenderer where it used to be only one line but scrollable, we also add a wheel listener to override the event when scrolling horizontally.

This doesn't affect some elements, for example, a popover, because a popover is put on the body element using a portal.

What changes do you think we should make in order to solve the problem?

We should add a 'wheel' listener to the video player (BaseVideoPlayer) and stop the propagation if the video player is on full screen.

// we shouldn't do the type case here, just for testing
(videoPlayerElementParentRef.current as HTMLDivElement)?.addEventListener('wheel', (ev) => {
    if (!isFullScreenRef.current) {
        return;
    }
    ev.stopPropagation();
});

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021847127321367852470

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[alexpensify]

@paultsimura - can you please identify if this proposal will fix this issue? Thanks!

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

[paultsimura]

The proposal by @bernhardoj looks good and tests well, thanks.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @paultsimura

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix can't scroll video playback speed when fullscreen #51112

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Reviewer)
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@paultsimura] The PR that introduced the bug has been identified. Link to the PR:
• [@paultsimura] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@paultsimura] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@paultsimura] Determine if we should create a regression test for this bug.
• [@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[paultsimura]

I can't name an offending PR here because this feature simply was not implemented before.

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Send a video in a chat
2. Start the video from the thumbnail (without opening it in a modal)
3. Hover over the video and click on the "Fullscreen" button
4. Click on the "..." button
5. Click on "Playback speed"
6. Hover over any of the speed options and scroll the mouse wheel
7. Verify you can scroll the Playback Speed list with the wheel

Do we agree 👍 or 👎

[alexpensify]

Payouts due: 2024-10-30

• Contributor: $250 @bernhardoj - Please submit a request in Chat
• Reviewer: $250 @paultsimura - I completed the payment via Upwork

Upwork job is here. @yuwenmemon, do you agree with this regression test? If yes, I can create the GH. Thanks!

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj