[HOLD for payment 2024-11-01] [$125] BUG: SelfDM is marked as unread even though there is no message

[danielrvidal]

BUG: SelfDM is marked as unread even though there is no message

1. I signed up and wen’t through onboarding modals
2. When I get to the Concierge chat my SelfDM is unread
3. But there is no message in the self DM

• The first image is when I choose “Manage my team”
• The second is the SelfDM when you choose “Track my expenses”
• In both cases, I don’t think it should be unread.

We discussed this internally and can't think of any cases where the SelfDM should be unread. So let's please update the flow so that it is marked as read when users come in as new users.

Some background from @trjExpensify:
#43489 - It looks like we did this in this PR.

We need to remove the selfDM from this line:

App/src/libs/ReportUtils.ts

Line 6127 in f180cbb

if (isEmptyReport(report) && !isSelfDM(report)) {

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847081858608334041
• Upwork Job ID: 1847081858608334041
• Last Price Increase: 2024-10-18
• Automatic offers:
• mkhutornyi | Reviewer | 104524422
• mkzie2 | Contributor | 104524424

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021847081858608334041

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-10-18 01:11:24 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

SelfDM is marked as unread even though there is no message

What is the root cause of that problem?

We forced showing unread for empty self DM:

App/src/libs/ReportUtils.ts

Lines 6127 to 6129 in f180cbb

	if (isEmptyReport(report) && !isSelfDM(report)) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

Remove the isSelfDM check from the above.

[trjExpensify]

I'm dropping the price on this as a one-liner we've identified.

[melvin-bot]

Upwork job price has been updated to $125

[trjExpensify]

@zanyrenney when this is deployed, please make sure we remove this test case from QA: https://github.com/Expensify/Expensify/issues/412760

CC: @isagoico

[melvin-bot]

@zanyrenney, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mkhutornyi]

@mkzie2's proposal looks good.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: self DM is marked as unread when empty #51212

If no regressions arise, payment will be issued on 2024-11-01. 🎊

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment automatic offer (Reviewer)
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
• [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mkhutornyi] Determine if we should create a regression test for this bug.
• [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[danielrvidal]

Confirmed it's working on production as intended!

[zanyrenney]

@mkhutornyi please complete the checklist (you can edit my comment here to do so) so that i can close this out and pay it.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
• [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mkhutornyi] Determine if we should create a regression test for this bug.
• [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

I have DM'd @mkhutornyi

[mkhutornyi]

This is not a regression but new expected behavior.
@zanyrenney please check #51066 (comment) for regression test
We should update test case:

1. Sign in with a new expensify account
2. Complete onboarding flow
3. Verify self DM is not shown in bold

[zanyrenney]

Cool, please can you also complete the checklist? this is past due for payment @mkhutornyi Thanks!

[zanyrenney]

@isagoico already replied to the comment about updating the test case here.

[mkhutornyi]

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2024-11-01] [$125] BUG: SelfDM is marked as unread even though there is no message #51066 (comment)

[zanyrenney]

BZ checklist above!

[zanyrenney]

payment summary

@mkhutornyi requires payment automatic offer (Reviewer) - paid $125
@mkzie2 requires payment automatic offer (Contributor) - paid $125