Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags - State field is not auto populated #51256

Closed
4 of 8 tasks
lanitochka17 opened this issue Oct 22, 2024 · 13 comments
Closed
4 of 8 tasks

Tags - State field is not auto populated #51256

lanitochka17 opened this issue Oct 22, 2024 · 13 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9. 0. 52-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Pre-condition: As admin in old dot, upload dependent tags

  1. Go to https://staging.new.expensify.com/home
  2. As employee, login
  3. Open workspace chat
  4. Tap plus icon -- submit expense
  5. Enter an amount and tap next
  6. Note the state field

Expected Result:

State field must be auto populated

Actual Result:

State field is not auto populated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6642044_1729602634818.az_recorder_20241022_183628.mp4

Dependent - Multi Level tags NEW (1).csv

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 22, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@dangrous
Copy link
Contributor

Interesting, I see it on staging (and not on production) but not able to reproduce locally. Will investigate further.

@dangrous
Copy link
Contributor

Found a potential cause here - #49412 - but still not able to reproduce, so it's proving hard to figure out.

@ishpaul777
Copy link
Contributor

Hey @dangrous, sorry for noob question but can you tell me whats "dependent tags" meant in issue OP ?

@ishpaul777
Copy link
Contributor

@lanitochka17 Can you please add steps for:

Pre-condition: As admin in old dot, upload dependent tags

@lanitochka17
Copy link
Author

@ishpaul777 uploaded dependent tags:

Dependent - Multi Level tags NEW (1).csv

@ishpaul777
Copy link
Contributor

Thank you!

@dangrous
Copy link
Contributor

Should be fixed by @ishpaul777's PR!

@m-natarajan
Copy link

Not reproducible

bandicam.2024-10-22.19-34-35-169.mp4

Copy link

melvin-bot bot commented Oct 23, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@ishpaul777
Copy link
Contributor

hey 👋 i found and reverted the offernding PR for this, is this eligible for payment. This was not related to a PR i authored.

cc @yuwenmemon @dangrous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants