Deploy Checklist: New Expensify 2024-10-22

[github-actions]

Release Version: 9.0.52-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Patch 116 #48354
• [Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412
• Refactor: reuse ValidateCodeActionModal #49445
• [A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit #49592
• [Debug Mode] Show reason for RBR/GBR on LHN tabs #49962
• Resolves offline sound playback by caching assets locally #50130
• fix: migrate withFullTransactionOrNotFound #50327
• fix: report header has "Hold" action when the expense is already in Hold status #50383
• Show missing shipping details always when assigned user is not same as current user #50489
• fix: The selected approver has no background color #50541
• Update and rename adding-payment-card-subscription-overview.md to Add… #50567
• workspace invite submit #50581
• Fix previous invite message showing on every type #50618
• Fix/50248 handle card failure data #50644
• Fix inconsistent money request and task behavior #50700
• fix: error when changing website value and reset it #50715
• Company Cards - Bank UI #50716
• Enable ending animation in RequireTwoFactorAuthenticationModal #50790
• Add images to help site repo and to the doc #50816
• Add RBR reason to LHN debugging #50831
• [QBD] Offline mode for RequireQuickBooksDesktopModal #50915
• fix gray placeholder shown for markdown images with invalid URLs #50918
• [No QA] Bump eslint-config-expensify version #50935
• Update CONTRIBUTING.md #50965
• [No QA] [Direct Feeds] Update Feed switcher label #50972
• Migrated from withOnyx to useOnyx for KYCWall #50999
• Adjust condition to access submit button #51012
• feat: Frame for non USD bank account flow #51019
• Fix: Submit expense - Highlight jumps to manual when clicking back from start/stop #51020
• Sort to ensure the CREATED action is always on top #51023
• Support empty value for categories and tags v2 #51033
• Replace with correct path in nested state #51071
• Create autocomplete parser #51079
• [No QA] [3rd Party Feeds] Follow-up: Move company cards related functions to CompanyCards file #51080
• [No QA] Docs: Added entry about complex types in functions parameters #51085
• Replace duplicated openReports #51093
• fix: do not show spinner if data is already there #51098
• [NO QA] Update Configure-Netsuite.md #51103
• [No QA]Update to use a shared CLA #51111
• Fix can't scroll video playback speed when fullscreen #51112
• Update link to OfflineWithFeedback link in OFFLINE_UX.md #51134
• [NoQA] fix(e2e): fix e2e search test by clicking search page #51157
• Add active policy type and role to perf metadata #51176
• [CP Staging] Revert "Search suffix tree implementation" #51177
• fix: saved search is overlapped by bottom padding #51210
• [CP Staging] [Firebase] replace empty string with 'N/A' #51226
• [CP Staging] Revert "[A/B Testing][ESLint Clean Up] Use useOnyx cases for files in combinedTrackSubmit" #51245
• fix: reuse ValidateCodeActionModal in wallet settings page #51267
• Revert "fix: migrate withFullTransactionOrNotFound" #51283
• [CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" #51289

Deploy Blockers:

• [HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30][$100] New Expensify Crashing at Login #51222
• Split - App crashes after clicking on split preview #51235
• Expense - Category list loads infinitely when submitting to non-existing workspace chat #51238
• [HOLD for payment 2024-11-20] [$250] FAB - Track expense option is not present in FAB for Expensifail account #51242
• [$250] Expense - Expense amount is not added but substracted when submitting from the expense report #51249
• Tags - State field is not auto populated #51256
• [HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Account Settings - I don't receive the magic code to verify the account in wallet section #51258
• Concierge - Concierge not displayed for new Employees added to collect policy #51262
• An error appears when try to issue card for a new user on private domain #51265
• [HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Copilot - Nothing happens when clicking on the grayed out user when magic code is incorrect #51266
• Search - Expenses created on a control WS are not showing up on Search page #51270
• [HOLD for payment 2024-11-29] [$125] Copilot - Clicking outside magic code RHP does not dismiss the RHP entirely #51272
• [HOLD for payment 2024-11-13] [$250] Copilot - Nothing happens when clicking Add copilot after returning from magic code page #51273
• [HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Profile - "Failed to add this contact method" error appears when correct magic code is entered #51274
• [Hold for #50796] [$250] Contact method - User returned to enter new email step after backgrounding app #51275
• [HOLD for payment 2024-11-01] Validate - Magic code RHP does not animate correctly from pay someone confirmation page #51276
• [HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Validate account - Magic code email is received twice when validating from bank account setup #51277
• [Awaiting checklist] [$250] Contact method - Keyboard not opened when navigating to enter magic code step #51279
• Expense - Error when submitting distance expense to non-existing workspace chat #51286
• Android/iOS - Chat - Not here page in 1:1 DM after connecting online #51292
• [HOLD for payment 2024-11-14] [$250] Android -Distance - Distance tab is gray and not highlighted in green when swiping to Distance #51297

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.52-0 🚀

[Beamanator]

Checking off #51222 as fixed by #51226

[Julesssss]

#49592 resolved blocker #51242

[mvtglobally]

Regression is at 50% completed

Blockers
#51235
#51238
#51249
#51256
#51258
#51262
#51265
#51266

[carlosmiceli]

Demoting #51273

[mvtglobally]

Regression is at 75% completed

Blockers
#51235
#51238
#51249
#51256
#51258
#51262
#51265
#51266
#51274
#51275
#51276
#51277
#51286

PRs

#51019 (comment) can we check off?
#50816 - is this Prod QA? Can we check off?

[yuwenmemon]

Checking off #51235, based on https://expensify.slack.com/archives/C01GTK53T8Q/p1729629890442699?thread_ts=1729595391.798739&cid=C01GTK53T8Q

[yuwenmemon]

#51019 (comment) can we check off?
#50816 - is this Prod QA? Can we check off?

@mvtglobally Yes, feel free to check off both.

[srikarparsi]

Checking off #51275 as it's reproducible in production.

[yuwenmemon]

Checking off
#51249
#51286

Based on https://expensify.slack.com/archives/C9YU7BX5M/p1729639636311899?thread_ts=1729632202.975429&cid=C9YU7BX5M

[yuwenmemon]

Checking off
#51256

Based on: https://expensify.slack.com/archives/C9YU7BX5M/p1729638110947209

[yuwenmemon]

Checking off
#51238

Based on: https://expensify.slack.com/archives/C9YU7BX5M/p1729637904665049

[mvtglobally]

Regression is at 95% completed

Blockers
#51258
#51266
#51274
#51275
#51276
#51277
#51292

PRs
#49592 - Is failing with #51247. Repro in PROD checking off
#49962 - We dont have option to validate on Hybrid app, Pending Desktop validation
#50130 - Is failing with #50843. Repro in PROD, checking off
#50383 - Original issue still repro on mWeb, rest are pass. Ok to check off?
#50489 - is failign with #51265
#50700 - Pending validation on Desktop
#50790 - Is failing with #51254. repro in PROD. Checking off
#50831 - Is blocked by #50843 on Hybrid app. Ok to check off?
#51023 - Pending validation on Hybrid apps and Desktop
#51093 - - Pending validation on Hybrid apps and mWeb
#51098 - is failing with original issue
#51267 - Checkig n CP

[yuwenmemon]

Checking off the lot:
#51258
#51266
#51274
#51276
#51277

From: https://expensify.slack.com/archives/C9YU7BX5M/p1729642519167879

[mvtglobally]

Regression is at 99% completed

Blockers
#51292

PRs
#50383 - Original issue still repro on mWeb, rest are pass. Ok to check off?
#50489 - is failign with #51265
#50700 - Pending validation on Desktop
#50831 - Is blocked by #50843 on Hybrid app. Ok to check off?
#51023 - Pending validation on iOS and Desktop
#51093 - Pending validation on Hybrid apps and mWeb
#51098 - is failing with original issue
#51267 - Pending validation on iOS

[yuwenmemon]

#50383 - Original issue still repro on mWeb, rest are pass. Ok to check off?

Yeah, made a comment in the original issue so the stakeholders are aware.

[yuwenmemon]

#50831 - Is blocked by #50843 on Hybrid app. Ok to check off?

Yes, checking off!

[yuwenmemon]

Checking off #51292 (comment)

[izarutskaya]

Regression completed

#50700 - blocked on iOS with #51090
#51093 - blocked on iOS and Android. Can you please to check off?
#51098 - failing with original #49964

[mountiny]

all of the remaining seem good to check off so I have done so

[yuwenmemon]