[HOLD for payment 2024-11-29] [$125] Copilot - Clicking outside magic code RHP does not dismiss the RHP entirely

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Security.
3. Click Add copilot.
4. Select a user > Next.
5. Select an access level > Next.
6. Click Add copilot.
7. Click outside the RHP to dismiss it.

Expected Result:

The RHP will be dismissed when clicking outside it for the first time (production behavior).

Actual Result:

The RHP is not dismissed when clicking outside it for the first time. It returns to copilot confirmation page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642180_1729610329475.20241022_231619.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850957170859734764
• Upwork Job ID: 1850957170859734764
• Last Price Increase: 2024-11-04
• Automatic offers:
• mkzie2 | Contributor | 104756037

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The RHP is not dismissed when clicking outside it for the first time. It returns to copilot confirmation page.

What is the root cause of that problem?

We only hide the modal when it's closed

App/src/pages/settings/Security/AddDelegate/DelegateMagicCodeModal.tsx

Lines 36 to 38 in 3e27050

	const onBackButtonPress = () => {
	setIsValidateCodeActionModalVisible(false);
	};

What changes do you think we should make in order to solve the problem?

We should dismiss the modal if we click outside. We can add onBackdropPress to Modal here.

onBackdropPress={() => {
    Navigation.dismissModal();
}}

App/src/components/ValidateCodeActionModal/index.tsx

Line 50 in 3e27050

<Modal

OPTIONAL: We can introduce a new prop onBackdropPress in ValidateCodeActionModal and add onBackdropPress here that will dismiss the modal here and other places that use ValidateCodeActionModal and want to dismiss the modal if clicking outside.

App/src/pages/settings/Security/AddDelegate/DelegateMagicCodeModal.tsx

Line 56 in 3e27050

<ValidateCodeActionModal

What alternative solutions did you explore? (Optional)

[pecanoro]

Since this is under a beta, I am going to remove the blocker first

[melvin-bot]

@pecanoro, @OfstadC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[pecanoro]

Opening for proposals but this one is pretty straightforward so setting bounty to $125

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850957170859734764

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: ValidateCodeActionModal is not dismissed on backdrop press #52232

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@sobitneupane @OfstadC @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[OfstadC]

@sobitneupane Please complete BZ checklist by Friday so we can issue payment here 😃

[melvin-bot]

@pecanoro, @OfstadC, @sobitneupane, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[OfstadC]

Payment Summary

• @sobitneupane due $125 via manual New Expensify request
• @mkzie2 Paid $125 via Upwork

[OfstadC]

Bump @sobitneupane

[sobitneupane]

Regression Test Proposal

1. Go to Settings > Security > Add copilot
2. Select a user > Next.
3. Select an access level > Next.
4. Click Add copilot.
5. Click outside the RHP to dismiss it.
6. Verify the RHP is dismissed.

Do we agree 👍 or 👎?

[sobitneupane]

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [CP Staging] add validate code modal #48628 (comment)

[OfstadC]

Thanks @sobitneupane - Updated Payment Summary

[garrettmknight]

$125 approved for @sobitneupane