[QBD] Offline mode for RequireQuickBooksDesktopModal #50915

ZhenjaHorbach · 2024-10-16T15:23:28Z

Details

Add Offline mode for RequireQuickBooksDesktopModal

Fixed Issues

$ #50548
PROPOSAL:

Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account

Sign in on an account above
Go to any Workspace -> Accounting
Click on Connect under QuickBooks Desktop connection
While RHP is loading, quickly disconnect network.
Verify that after this the offline screen is displayed (The offline screen is displayed until the link is received)

Verify that no errors appear in the JS console

Offline tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account

Sign in on an account above
Go to any Workspace -> Accounting
Click on Connect under QuickBooks Desktop connection
While RHP is loading, quickly disconnect network.
Verify that after this the offline screen is displayed (The offline screen is displayed until the link is received)

QA Steps

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account

Sign in on an account above
Go to any Workspace -> Accounting
Click on Connect under QuickBooks Desktop connection
While RHP is loading, quickly disconnect network.
Verify that after this the offline screen is displayed (The offline screen is displayed until the link is received)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

not relevant

Android: mWeb Chrome

not relevant

iOS: Native

not relevant

iOS: mWeb Safari

not relevant

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…View

melvin-bot · 2024-10-17T15:54:14Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-10-18T02:22:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

Screen.Recording.2024-10-18.at.22.40.34.web.mov

MacOS: Desktop

Screen.Recording.2024-10-18.at.22.43.02.desktop.mov

hoangzinh

Overal looks good, just 1 minor feedback. Can you also check test steps? It looks incorrect.

hoangzinh · 2024-10-18T02:37:03Z

src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx

-                setIsLoading(false);
-            });
-        };
+    const ContentWrapper = codatSetupLink ? ({children}: React.PropsWithChildren) => children : FullPageOfflineBlockingView;


Suggested change

const ContentWrapper = codatSetupLink ? ({children}: React.PropsWithChildren) => children : FullPageOfflineBlockingView;

const ContentWrapper = codatSetupLink ? View : FullPageOfflineBlockingView;

I think it's simpler

In this case we will have to pass flex: 1 for this View
So the current implementation is the simplest

hoangzinh · 2024-10-18T02:41:54Z

Additional, the title may be incorrect, it should be "Offline mode for QBD setup page"

hoangzinh · 2024-10-18T02:47:05Z

Bug 1: The screen flickers when I turn off and then turn on the network.

Screen.Recording.2024-10-18.at.09.42.50.mov

ZhenjaHorbach · 2024-10-18T08:28:25Z

Bug 1: The screen flickers when I turn off and then turn on the network.

Actually it's strange
When I try to turn off the Internet using the developer tool
My request does not return an error and waits for the Internet to return

But using force offline (CMD+D) I don't have this visual bug

ZhenjaHorbach · 2024-10-18T14:16:55Z

Bug 1: The screen flickers when I turn off and then turn on the network.

I still can't reproduce
But I hope last changes should help

src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx

hoangzinh

LGTM

OSBotify · 2024-10-21T06:16:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-22T04:48:36Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T16:26:03Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ZhenjaHorbach added 2 commits October 16, 2024 17:21

refactor RequireQuickBooksDesktopModal to use FullPageOfflineBlocking…

71f4258

…View

refactor screen

0054c86

ZhenjaHorbach marked this pull request as ready for review October 17, 2024 15:54

ZhenjaHorbach requested a review from a team as a code owner October 17, 2024 15:54

melvin-bot bot requested a review from hoangzinh October 17, 2024 15:54

melvin-bot bot removed the request for review from a team October 17, 2024 15:54

hoangzinh reviewed Oct 18, 2024

View reviewed changes

fix bug with loader

8eed560

ZhenjaHorbach added 2 commits October 18, 2024 10:29

fix bug with loader v2

6bb8d2c

remove useEffect

2e8d995

lakchote self-requested a review October 18, 2024 13:19

ZhenjaHorbach added 2 commits October 18, 2024 16:00

fix bug with empty codatSetupLink

a51b13d

fix bug with empty codatSetupLink v2.0

bdae84a

hoangzinh reviewed Oct 18, 2024

View reviewed changes

src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx Outdated Show resolved Hide resolved

ZhenjaHorbach added 3 commits October 18, 2024 17:08

refactor code

eb5e6b3

fix conflicts

4fa4a7b

fix eslint issue

bd740de

hoangzinh approved these changes Oct 18, 2024

View reviewed changes

lakchote approved these changes Oct 21, 2024

View reviewed changes

lakchote merged commit 893ef36 into Expensify:main Oct 21, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks

melvin-bot bot mentioned this pull request Oct 23, 2024

[HOLD for payment 2024-10-30] QBD - Empty link in RHP when network is disconnected while QBD setup is loading #50548

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QBD] Offline mode for RequireQuickBooksDesktopModal #50915

[QBD] Offline mode for RequireQuickBooksDesktopModal #50915

ZhenjaHorbach commented Oct 16, 2024 •

edited

Loading

melvin-bot bot commented Oct 17, 2024

hoangzinh commented Oct 18, 2024 •

edited

Loading

hoangzinh left a comment

hoangzinh Oct 18, 2024

ZhenjaHorbach Oct 18, 2024 •

edited

Loading

hoangzinh commented Oct 18, 2024

hoangzinh commented Oct 18, 2024

ZhenjaHorbach commented Oct 18, 2024

ZhenjaHorbach commented Oct 18, 2024

hoangzinh left a comment

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

	const ContentWrapper = codatSetupLink ? ({children}: React.PropsWithChildren) => children : FullPageOfflineBlockingView;
	const ContentWrapper = codatSetupLink ? View : FullPageOfflineBlockingView;

[QBD] Offline mode for RequireQuickBooksDesktopModal #50915

[QBD] Offline mode for RequireQuickBooksDesktopModal #50915

Conversation

ZhenjaHorbach commented Oct 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 17, 2024

hoangzinh commented Oct 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh left a comment

Choose a reason for hiding this comment

hoangzinh Oct 18, 2024

Choose a reason for hiding this comment

ZhenjaHorbach Oct 18, 2024 • edited Loading

Choose a reason for hiding this comment

hoangzinh commented Oct 18, 2024

hoangzinh commented Oct 18, 2024

ZhenjaHorbach commented Oct 18, 2024

ZhenjaHorbach commented Oct 18, 2024

hoangzinh left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 21, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

ZhenjaHorbach commented Oct 16, 2024 •

edited

Loading

hoangzinh commented Oct 18, 2024 •

edited

Loading

ZhenjaHorbach Oct 18, 2024 •

edited

Loading