Fix inconsistent money request and task behavior #50700

bernhardoj · 2024-10-14T05:05:05Z

Details

On the money request confirm page, if no participant is selected, the submit button is disabled. We want to keep it enabled and instead show an error when pressed. Also, a few issue is fixed:

Blank money request confirm page view when no participant is selected
Task confirm page info are not updated dynamically

Fixed Issues

$ #50577
PROPOSAL: #50577 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Web/mWeb
Open the same app on 2 tabs

For both tabs, press FAB > Submit expense and proceed to the confirm page
On the 2nd tab, submit the expense
On the 1st tab, verify the page is not empty/blank
On the 1st tab, verify the submit button is enabled
On the 1st tab, press the submit button and verify an error is shown
For both tabs, open any chat, start the Assign Task flow, and proceed to the confirm page
On the 2nd tab, submit the task
On the 1st tab, verify the task info is cleared
On the 1st tab, submit the task
On the 1st tab, verify an error is shown

Desktop/iOS/Android

Press FAB > Submit expense. Make sure the amount is still empty
Deeplink to the money request confirm page (e.g., staging.new.expensify.com/create/submit/confirmation/1/7929715303670174)
Verify the page is not empty/blank
Verify the submit button is enabled
Press the submit button and verify an error is shown
Close the page and open any chat
Press the + button and choose Assign task. Make sure the title and description are empty when open (if not, reopen to clear it)
Deeplink to the task confirm page (staging.new.expensify.com/new/task)
Submit the task
Verify an error is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…ow error when submitting

melvin-bot · 2024-10-14T05:05:10Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-10-14T05:09:38Z

MoneyRequestConfirmationList Onyx migration is being handled here

hungvu193 · 2024-10-16T02:56:16Z

I'm getting not found page on the second tabs.
Let's use the testcase from OP here

Screen.Recording.2024-10-16.at.09.50.14.mov

…k-behavior

bernhardoj · 2024-10-16T08:26:32Z

@hungvu193 I sometimes can repro it. The not found page is shown because the transaction draft is cleared when we submit the expense.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 672 in c4fb434

    
           const IOURequestStepConfirmationWithFullTransactionOrNotFound = withFullTransactionOrNotFound(IOURequestStepConfirmation);

But there is a useEffect here that init the money request back when the transaction is cleared. The effect sometimes is triggered while the RHP is closing, but sometimes not.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 64 to 69 in c4fb434

    
           useEffect(() => { 
        
               if (transaction?.reportID === reportID) { 
        
                   return; 
        
               } 
        
               IOU.initMoneyRequest(reportID, policy, isFromGlobalCreate, transactionRequestType.current); 
        
           }, [transaction, policy, reportID, iouType, isFromGlobalCreate]);

The not found page is also shown when the screen is focused.

App/src/pages/iou/request/step/withFullTransactionOrNotFound.tsx

Lines 50 to 57 in c4fb434

    
           const isFocused = useIsFocused(); 
        
           // If the transaction does not have a transactionID, then the transaction no longer exists in Onyx as a full transaction and the not-found page should be shown. 
        
           // In addition, the not-found page should be shown only if the component screen's route is active (i.e. is focused). 
        
           // This is to prevent it from showing when the modal is being dismissed while navigating to a different route (e.g. on requesting money). 
        
           if (!transactionID) { 
        
               return <FullPageNotFoundView shouldShow={isFocused} />; 
        
           }

hungvu193 · 2024-10-17T02:02:47Z

I think we might need to fix it as well.

bernhardoj · 2024-10-17T06:21:06Z

Hmm, what should be the expected behavior? The not found view is from WithFullTransactionOrNotFound. I think it's fine to show the not found page when the transaction data is undefined. The issue we are trying to fix is when the transaction data isn't undefined but the participant is missing.

hungvu193 · 2024-10-18T02:58:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-18.at.10.20.14.mov

Android: mWeb Chrome

// issue with setup

iOS: Native

Screen.Recording.2024-10-18.at.10.14.00.mov

iOS: mWeb Safari

Screen.Recording.2024-10-18.at.09.57.13.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-18.at.09.48.35.mov

MacOS: Desktop

Screen.Recording.2024-10-18.at.09.53.31.mov

hungvu193 · 2024-10-18T03:21:18Z

@bernhardoj Let's merge main 😄

…k-behavior

bernhardoj · 2024-10-18T05:09:36Z

@hungvu193 done

francoisl · 2024-10-18T17:00:33Z

Looks like there's a deprecation warning for withOnyx causing the ESLint action to fail.

bernhardoj · 2024-10-18T17:58:24Z

Yes, I noted it here

francoisl · 2024-10-19T00:09:16Z

Ah ok, it looks like in that case we're ok with merging then.

melvin-bot · 2024-10-19T00:09:52Z

@francoisl looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

francoisl · 2024-10-19T00:10:25Z

Not an emergency, see comments above – the withOnyx deprecation is being taken care of in #50532

OSBotify · 2024-10-19T00:20:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-22T04:48:18Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T16:25:45Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 3 commits October 14, 2024 12:41

fix blank view is shown when no participants

8b5bb7e

fix task info are not dynamically updated

611e6d8

keep the button enable even when not participants are selected and sh…

90ef6bb

…ow error when submitting

bernhardoj requested a review from a team as a code owner October 14, 2024 05:05

melvin-bot bot requested review from hungvu193 and removed request for a team October 14, 2024 05:05

bernhardoj mentioned this pull request Oct 14, 2024

[HOLD for payment 2024-10-30] [$250] Assign task - Inconsistent Button Behavior Between Submit and Assign Task After Navigating via URL #50577

Closed

6 tasks

Merge branch 'main' into fix/50577-inconsistent-money-request-and-tas…

f51fda8

…k-behavior

hungvu193 approved these changes Oct 18, 2024

View reviewed changes

melvin-bot bot requested a review from francoisl October 18, 2024 03:21

Merge branch 'main' into fix/50577-inconsistent-money-request-and-tas…

4d4edb1

…k-behavior

francoisl approved these changes Oct 19, 2024

View reviewed changes

francoisl merged commit 66cf824 into Expensify:main Oct 19, 2024
15 of 16 checks passed

melvin-bot bot added the Emergency label Oct 19, 2024

francoisl removed the Emergency label Oct 19, 2024

github-actions bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inconsistent money request and task behavior #50700

Fix inconsistent money request and task behavior #50700

bernhardoj commented Oct 14, 2024

melvin-bot bot commented Oct 14, 2024

bernhardoj commented Oct 14, 2024

hungvu193 commented Oct 16, 2024 •

edited

Loading

bernhardoj commented Oct 16, 2024

hungvu193 commented Oct 17, 2024

bernhardoj commented Oct 17, 2024

hungvu193 commented Oct 18, 2024 •

edited

Loading

hungvu193 commented Oct 18, 2024

bernhardoj commented Oct 18, 2024

francoisl commented Oct 18, 2024

bernhardoj commented Oct 18, 2024

francoisl commented Oct 19, 2024

melvin-bot bot commented Oct 19, 2024

francoisl commented Oct 19, 2024

OSBotify commented Oct 19, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

Fix inconsistent money request and task behavior #50700

Fix inconsistent money request and task behavior #50700

Conversation

bernhardoj commented Oct 14, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 14, 2024

bernhardoj commented Oct 14, 2024

hungvu193 commented Oct 16, 2024 • edited Loading

bernhardoj commented Oct 16, 2024

hungvu193 commented Oct 17, 2024

bernhardoj commented Oct 17, 2024

hungvu193 commented Oct 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Oct 18, 2024

bernhardoj commented Oct 18, 2024

francoisl commented Oct 18, 2024

bernhardoj commented Oct 18, 2024

francoisl commented Oct 19, 2024

melvin-bot bot commented Oct 19, 2024

francoisl commented Oct 19, 2024

OSBotify commented Oct 19, 2024

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

hungvu193 commented Oct 16, 2024 •

edited

Loading

hungvu193 commented Oct 18, 2024 •

edited

Loading