[HOLD for payment 2024-11-13] [$250] Desktop - Unexpected error when try to select the purpose "Chat and split"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5123689
Email or phone of affected tester (no customers): rybkina+102324fi@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch App
2. Create a new user (gmail)
3. Select the purpose "Chat and split expenses with friends"
4. Click on "Continue"
5. Verify that the "What’s your name?" modal appears
6. Enter any names
7. Click on "Continue"

Expected Result:

User should land to Concierge chat without issues.

Actual Result:

"What do you want to do today?" modal appeared again and errors appeared in Concierge chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6643819_1729723484035.chat_and_split.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850849037204397718
• Upwork Job ID: 1850849037204397718
• Last Price Increase: 2024-10-28

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Edited by proposal-police: This proposal was edited at 2024-10-26 04:12:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Unexpected error when try to select the purpose "Chat and split"

What is the root cause of that problem?

BE returns error saying

It's because we pass undefined value if the completedTaskReportAction?.reportActionID is null

App/src/libs/actions/Report.ts

Line 3427 in 8e13bcc

completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? undefined,

What changes do you think we should make in order to solve the problem?

We should pass '-1'or '0' as we're changing now from'-1'to'0'`

What alternative solutions did you explore? (Optional)

[trjExpensify]

I can repro this reliably, and dupe reported it here. Moving it on to get C+ eyes on this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850849037204397718

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[DylanDylann]

@NJ-2020's proposal looks good to me. Let's use "-1" value as confirmed here

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

❌ There was an error making the offer to @DylanDylann for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @NJ-2020 for the Contributor role. The BZ member will need to manually hire the contributor.

[yuwenmemon]

@sonialiap Halp

[DylanDylann]

@NJ-2020 Please create a PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix completed task report action id for onboarding #51722

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @NJ-2020 requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

@marcochavezf Already created a PR on BE

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @NJ-2020 paid $(AMOUNT) via Upwork (LINK)
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sonialiap)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1850849037204397718/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[DylanDylann]

@marcochavezf Could you give an update on this PR?

[marcochavezf]

👋🏽 The PR has been deployed to production

[DylanDylann]

@NJ-2020 Could you create the PR again to fix this issue?

[NJ-2020]

With the same changes?

I couldn't reproduce this issue on staging web

[DylanDylann]

@NJ-2020 Could you help to point out why we can't reproduce anymore? Our previous PR was reverted

[NJ-2020]

I think there's some BE changes, right?
#51395 (comment)

[DylanDylann]

Do you mean that the BE no longer returns errors when we pass an undefined value to completedTaskReportActionID params?

[NJ-2020]

Yes because we still pass undefined here

App/src/libs/actions/Report.ts

Line 3583 in 99da1ac

completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? undefined,

But it works when selecting "Chat and split"

Screen.Recording.2024-11-13.at.20.19.59.mov

Related PR: #51992

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/444096

Regression Test Proposal

Test:

1. Sign in with new account
2. On the onboarding flow, select "Chat and split expenses with friends"
3. Click on "Continue"
4. Enter your name
5. Click on "Continue"
6. Verify it lands to Concierge chat without issues

Do we agree 👍 or 👎

[DylanDylann]

Confirmed the bug is fixed on staging

[sonialiap]

@DylanDylann I see that this is linked to a deploy blocker, but seems like that was due to needing BE changes, is that correct?

[DylanDylann]

@sonialiap yes. And It is done now

[melvin-bot]

@yuwenmemon, @sonialiap, @NJ-2020, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sonialiap]

Payment summary:

• @NJ-2020 $250 via upwork - paid ✔️
• @DylanDylann $250 via upwork - paid ✔️