[HOLD for payment 2024-11-13] [$250] Workspace - In android, WS report displays double spacing before&after user name/id

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9. 0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch site in both mweb and hybrid app
2. Tap profile icon -- workspaces -- workspace
3. Tap invite- members
4. Invite users with email id and user name
5. Navigate to LHN and note the their workspace chat

Expected Result:

In android and mweb, the LHN text should displayed in same manner

Actual Result:

In android, there is double space before& after email id and user name on Workspace chat text in LHN but in mweb, single space only displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849941675546725686
• Upwork Job ID: 1849941675546725686
• Last Price Increase: 2024-10-25
• Automatic offers:
• ishpaul777 | Reviewer | 104654129
• huult | Contributor | 104654130

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[sakluger]

This feels like a pretty small bug, I'm going to set the price at $125. Feel free to let me know if you disgree.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849941675546725686

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[shahinyan11]

Edited by proposal-police: This proposal was edited at 2024-10-24 14:00:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - In android, WS report displays double spacing before&after user name/id

What is the root cause of that problem?

There are spaces at the beginning or end of translations here and we add additional spaces during usage here

What changes do you think we should make in order to solve the problem?

Remove spaces from this translations

  beginningOfChatHistoryPolicyExpenseChatPartOne: 'This is where',
  beginningOfChatHistoryPolicyExpenseChatPartTwo: 'will submit expenses to',
  beginningOfChatHistoryPolicyExpenseChatPartThree: 'workspace. Just use the + button.',

What alternative solutions did you explore? (Optional)

Do not add spaces on usage here

`${welcomeMessage.phrase1}${ReportUtils.getDisplayNameForParticipant(report?.ownerAccountID)}${welcomeMessage.phrase2}${ReportUtils.getPolicyName(
                report,
            )} ${welcomeMessage.phrase3}`

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS report displays double spacing before&after user name/id

What is the root cause of that problem?

The welcome message text contains an extra space because welcomeMessage.phrase1 and welcomeMessage.phrase2 in getWelcomeMessage include spaces. As a result, the newly created string retains an extra space.

For getWelcomeMessage, we have 2 issue related extra space.

1. The welcome message text L552 contains extra spaces because welcomeMessage.phrase1 and welcomeMessage.phrase2 n the translation include spaces.

App/src/languages/en.ts

Lines 674 to 675 in 652d2ff

	beginningOfChatHistoryPolicyExpenseChatPartOne: 'This is where ',
	beginningOfChatHistoryPolicyExpenseChatPartTwo: ' will submit expenses to ',

App/src/libs/SidebarUtils.ts

Lines 549 to 552 in 652d2ff

	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartOne');
	welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartTwo');
	welcomeMessage.phrase3 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartThree');
	welcomeMessage.messageText = `${welcomeMessage.phrase1} ${ReportUtils.getDisplayNameForParticipant(report?.ownerAccountID)} ${welcomeMessage.phrase2} ${ReportUtils.getPolicyName(

2 The welcome message text L596 if welcome message phrase1 that is beginningOfChatHistory

App/src/languages/en.ts

Line 673 in 652d2ff

beginningOfChatHistory: 'This chat is with ',

App/src/libs/SidebarUtils.ts

Line 571 in 652d2ff

welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistory');

App/src/libs/SidebarUtils.ts

Line 596 in 652d2ff

welcomeMessage.messageText = displayNamesWithTooltips.length ? `${welcomeMessage.phrase1} ${displayNamesWithTooltipsText}` : '';

For getRoomWelcomeMessage, we still have issue related extra space if welcome message phrase1 beginningOfArchivedRoomPartOne and beginningOfChatHistoryUserRoomPartOne

App/src/languages/en.ts

Line 661 in 652d2ff

beginningOfArchivedRoomPartOne: 'You missed the party in ',

App/src/languages/en.ts

Line 669 in 652d2ff

beginningOfChatHistoryUserRoomPartOne: 'This chat room is for anything ',

App/src/libs/SidebarUtils.ts

Line 614 in 652d2ff

welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfArchivedRoomPartOne');

App/src/libs/SidebarUtils.ts

Line 641 in 652d2ff

welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryUserRoomPartOne');

App/src/libs/SidebarUtils.ts

Line 644 in 652d2ff

welcomeMessage.messageText = `${welcomeMessage.phrase1} ${welcomeMessage.showReportName ? ReportUtils.getReportName(report) : ''} ${welcomeMessage.phrase2 ?? ''}`;

What changes do you think we should make in order to solve the problem?

To resolve this issue, we should create a function to remove extra spaces because there are many cases where the translation text includes spaces, while some translations do not. We shouldn't remove spaces from welcomeMessage.messageText, because we need to handle cases where welcomeMessage.phrase1 contains a space and cases where it does not. The code example would look something like this:

src/libs/SidebarUtils.ts#534
+        function ensureSingleSpacing(text: string) {
+                return text.replace(/\s+/g, ' ').trim();
+        }
src/libs/SidebarUtils.ts#552
-        welcomeMessage.messageText = `${welcomeMessage.phrase1} ${ReportUtils.getDisplayNameForParticipant(report?.ownerAccountID)} ${welcomeMessage.phrase2} ${ReportUtils.getPolicyName(
-                report,
-            )} ${welcomeMessage.phrase3}`;

+        welcomeMessage.messageText = ensureSingleSpacing(
+                `${welcomeMessage.phrase1} ${ReportUtils.getDisplayNameForParticipant(report?.ownerAccountID)} ${welcomeMessage.phrase2} ${ReportUtils.getPolicyName(report)} ${
+                        welcomeMessage.phrase3
+                }`,
+        );

src/libs/SidebarUtils.ts#602
-    welcomeMessage.messageText = displayNamesWithTooltips.length ? `${welcomeMessage.phrase1} ${displayNamesWithTooltipsText}` : '';
+    welcomeMessage.messageText = displayNamesWithTooltips.length ? ensureSingleSpacing(`${welcomeMessage.phrase1} ${displayNamesWithTooltipsText}`) : '';

src/libs/SidebarUtils.ts#644
-    welcomeMessage.messageText = `${welcomeMessage.phrase1} ${welcomeMessage.showReportName ? ReportUtils.getReportName(report) : ''} ${welcomeMessage.phrase2 ?? ''}`;
+    welcomeMessage.messageText = ensureSingleSpacing(`${welcomeMessage.phrase1} ${welcomeMessage.showReportName ? ReportUtils.getReportName(report) : ''} ${welcomeMessage.phrase2 ?? ''}`);

[melvin-bot]

@sakluger, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

I'll review in few hours

[ishpaul777]

Proposal from @huult is complete and fixes all such double spacing issues hollistically. lets assign them!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @huult 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[huult]

Thank you all. I will create a PR within 24 hours

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix remove double spacing in LHN report welcome text #51752

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @huult requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

@ishpaul777 @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sakluger]

Hey @ishpaul777 please make sure to finish the BZ checklist before the payment date tomorrow.

[sakluger]

Summarizing payment on this issue:

Contributor: @huult $250, paid via Upwork
Contributor+: @ishpaul777 $250, will pay via Upwork once BZ checklist is done

[ishpaul777]

i'll fill out first thing tmrw 🙇

[sakluger]

@ishpaul777 any updates?

[ishpaul777]

sorry was OOO past few days

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/44667/files#r1844938947

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: It was pretty small almost unnoticable, not critical

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

For same reason as above no regression test needed also the fix implemented will make sure this doesn't happen anymore with other welcome message copies

[sakluger]

Thanks! I paid out the remaining Upwork contract, we're good to close.