Start showing the beginningOfChatHistory in other room types #44667

nkdengineer · 2024-07-01T03:36:17Z

Details

Fixed Issues

$ #44146
PROPOSAL: #44146 (comment)

Tests

Login as new user
Create a new workspace
Verify that: the workspace room has subtitle in LHN instead of 'No activity yet'

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login as new user
Create a new workspace
Verify that: the workspace room has subtitle in LHN instead of 'No activity yet'

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-01T08:31:40Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.ts

src/libs/SidebarUtils.ts

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

src/libs/SidebarUtils.ts

src/libs/ReportUtils.ts

src/libs/SidebarUtils.ts

trjExpensify · 2024-07-08T11:25:51Z

@nkdengineer can you address the comments today, please?

nkdengineer · 2024-07-08T13:57:47Z

I'll update today

nkdengineer · 2024-07-08T16:50:17Z

@s77rt i updated, please check again

src/libs/SidebarUtils.ts

s77rt · 2024-07-08T18:32:51Z

src/libs/SidebarUtils.ts

@@ -385,38 +395,14 @@ function getOptionData({
        } else {
            result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : ReportActionsUtils.getLastVisibleMessage(report.reportID, {}, lastAction)?.lastMessageText;
            if (!result.alternateText) {
-                result.alternateText = Localize.translate(preferredLocale, 'report.noActivityYet');
+                // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+                result.alternateText = ReportUtils.formatReportLastMessageText(getWelcomeMessage(report).concatMessage || Localize.translateLocal('report.noActivityYet'));


Based on the above comment ^ Do we still have a case where we would return report.noActivityYet

I just updated and we still have some case messageText is undefined like chat thread or task report.

nkdengineer · 2024-07-10T15:26:28Z

@s77rt I updated your suggestion, please help to check again.

src/components/ReportWelcomeText.tsx

s77rt · 2024-07-10T16:05:47Z

src/libs/SidebarUtils.ts

+    if (ReportUtils.isChatThread(report) || ReportUtils.isTaskReport(report)) {
+        return welcomeMessage;
+    }


Where is this logic coming from?

For these cases, I think it doesn't make sense to display the message This is the beginning of your chat with in LHN for the chat thread or task report.

s77rt · 2024-07-10T18:30:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

s77rt

NAB comments

src/libs/SidebarUtils.ts

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

melvin-bot · 2024-07-11T14:51:56Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2024-07-11T14:52:31Z

I'm trying to get another internal reviewer assigned as Aldo is OoO. 🤔

trjExpensify · 2024-07-11T14:53:21Z

Sorry, @s77rt, looks like you'll need to approve again. @mountiny, am I out of luck here?

s77rt · 2024-07-11T21:43:57Z

@nkdengineer Looks we have conflicts, can you please check

mountiny

Changes look good to me, thanks

OSBotify · 2024-07-12T15:06:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:04:38Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:13:22Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:19:28Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:50:02Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2024-11-16T08:46:53Z

src/libs/SidebarUtils.ts

+            welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartOne');
+            welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartTwo');
+            welcomeMessage.phrase3 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartThree');
+            welcomeMessage.messageText = `${welcomeMessage.phrase1} ${ReportUtils.getDisplayNameForParticipant(report?.ownerAccountID)} ${welcomeMessage.phrase2} ${ReportUtils.getPolicyName(


Coming from #51409 {BZ checklist}, there was small regession, the translation keys have spacing at end already and we addeed spacing here also resulting in double spacing

nkdengineer and others added 5 commits June 27, 2024 16:22

display begining chat history message in LHN

9f2d5a2

Merge branch 'Expensify:main' into fix/44146

7595c30

fix lint

e32567e

fix lint

0051894

run prettier

b23327b

nkdengineer marked this pull request as ready for review July 1, 2024 08:31

nkdengineer requested a review from a team as a code owner July 1, 2024 08:31

melvin-bot bot requested review from s77rt and removed request for a team July 1, 2024 08:31

nkdengineer mentioned this pull request Jul 1, 2024

[HOLD for payment 2024-07-24] [$250] [FT] Start showing the beginningOfChatHistory in other room types and not just selfDMs #44146

Closed

s77rt suggested changes Jul 1, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

fix logic get welcome text

91d090c

s77rt suggested changes Jul 2, 2024

View reviewed changes

src/libs/SidebarUtils.ts Show resolved Hide resolved

src/libs/SidebarUtils.ts Show resolved Hide resolved

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

nkdengineer and others added 2 commits July 3, 2024 15:52

Update src/libs/SidebarUtils.ts

d3c7f13

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

fix: logic get begin of chat history

d949ba0

s77rt reviewed Jul 3, 2024

View reviewed changes

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

nkdengineer added 2 commits July 5, 2024 11:19

Merge branch 'main' into fix/44146

8d331c5

consistent logic

208bd88

s77rt suggested changes Jul 5, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

nkdengineer added 4 commits July 8, 2024 21:03

Merge branch 'main' into fix/44146

3ae6b87

fix lint

3cf8483

fix: remove useless function

15ad9f4

fix lint

8270b23

s77rt suggested changes Jul 8, 2024

View reviewed changes

nkdengineer added 2 commits July 10, 2024 21:50

Merge branch 'main' into fix/44146

6106529

refactor: cleanup function

f4ea209

s77rt suggested changes Jul 10, 2024

View reviewed changes

use messageHtml field

57e761e

s77rt suggested changes Jul 10, 2024

View reviewed changes

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

src/libs/SidebarUtils.ts Outdated Show resolved Hide resolved

nkdengineer and others added 2 commits July 11, 2024 10:44

Update src/libs/SidebarUtils.ts

229402a

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

Update src/libs/SidebarUtils.ts

b7c57ec

Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>

s77rt approved these changes Jul 11, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify July 11, 2024 09:20

trjExpensify requested a review from a team July 11, 2024 14:51

melvin-bot bot requested review from s77rt and removed request for a team July 11, 2024 14:51

s77rt approved these changes Jul 11, 2024

View reviewed changes

resolve conflict

5afc41d

mountiny assigned nkdengineer Jul 12, 2024

mountiny approved these changes Jul 12, 2024

View reviewed changes

mountiny merged commit 73093f5 into Expensify:main Jul 12, 2024
14 checks passed

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

ishpaul777 reviewed Nov 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start showing the beginningOfChatHistory in other room types #44667

Start showing the beginningOfChatHistory in other room types #44667

nkdengineer commented Jul 1, 2024

melvin-bot bot commented Jul 1, 2024

trjExpensify commented Jul 8, 2024

nkdengineer commented Jul 8, 2024 •

edited

Loading

nkdengineer commented Jul 8, 2024

s77rt Jul 8, 2024

nkdengineer Jul 10, 2024

nkdengineer commented Jul 10, 2024

s77rt Jul 10, 2024

nkdengineer Jul 10, 2024

s77rt commented Jul 10, 2024 •

edited

Loading

s77rt left a comment

melvin-bot bot commented Jul 11, 2024

trjExpensify commented Jul 11, 2024

trjExpensify commented Jul 11, 2024

s77rt commented Jul 11, 2024

mountiny left a comment

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

ishpaul777 Nov 16, 2024

Start showing the beginningOfChatHistory in other room types #44667

Start showing the beginningOfChatHistory in other room types #44667

Conversation

nkdengineer commented Jul 1, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 1, 2024

trjExpensify commented Jul 8, 2024

nkdengineer commented Jul 8, 2024 • edited Loading

nkdengineer commented Jul 8, 2024

s77rt Jul 8, 2024

Choose a reason for hiding this comment

nkdengineer Jul 10, 2024

Choose a reason for hiding this comment

nkdengineer commented Jul 10, 2024

s77rt Jul 10, 2024

Choose a reason for hiding this comment

nkdengineer Jul 10, 2024

Choose a reason for hiding this comment

s77rt commented Jul 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 11, 2024

trjExpensify commented Jul 11, 2024

trjExpensify commented Jul 11, 2024

s77rt commented Jul 11, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 12, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

ishpaul777 Nov 16, 2024

Choose a reason for hiding this comment

nkdengineer commented Jul 8, 2024 •

edited

Loading

s77rt commented Jul 10, 2024 •

edited

Loading