[HOLD for payment 2024-11-07] Report fields - "Enabled/Disabled" does not align with header "Status" in list value page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes in Hybrid iOS
Email or phone of affected tester (no customers): applausetester+kh2010001@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has list type report field with some list values.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Report fields.
3. Click on the list type report field.
4. Click List values.

Expected Result:

"Enabled/Disabled" will align with header "Status".

Actual Result:

"Enabled/Disabled" does not align with header "Status" in list value page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6645373_1729849785470.list.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #wave-control

[izarutskaya]

Production

bandicam.2024-10-25.13-00-16-098.mp4

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-10-25 11:35:49 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Report fields - "Enabled/Disabled" does not align with header "Status" in list value page

What is the root cause of that problem?

• Min width is not set.
  

  App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx

  Lines 166 to 167 in 904e715

  	<Text style={styles.searchInputStyle}>{translate('common.name')}</Text>
  	<Text style={[styles.searchInputStyle, styles.textAlignCenter]}>{translate('statusPage.status')}</Text>

What changes do you think we should make in order to solve the problem?


• Wrap status text in a view and pass style={[StyleUtils.getMinimumWidth(60)]}.
• Same as we do in workspace tags page and other similar pages.
  

  App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

  Lines 130 to 140 in 904e715

  	const getCustomListHeader = () => {
  	const header = (
  	<View style={[styles.flex1, styles.flexRow, styles.justifyContentBetween, canSelectMultiple && styles.ml3]}>
  	<View>
  	<Text style={[styles.searchInputStyle]}>{translate('common.name')}</Text>
  	</View>
  	<View style={[StyleUtils.getMinimumWidth(60)]}>
  	<Text style={[styles.searchInputStyle, styles.textAlignCenter]}>{translate('statusPage.status')}</Text>
  	</View>
  	</View>
  	);

• We should also check other missing styles and make them consistent and we should also check other similar components to fix the same bug.

What alternative solutions did you explore? (Optional)

Result

[MarioExpensify]

Hardly a deploy blocker. Will check if we have any recent PR affecting this and revert it if needed. If not we'll move with an External task.

[Krishna2323]

@MarioExpensify, I think this is the offending PR.

[ChavdaSachin]

Coming from my PR, I can raise a quick fix here.

[ChavdaSachin]

We have created a new component CustomListHeader in this PR which I missed to apply on ReportFieldsListValuePage and WorkspaceViewTagsPage, applying the same will solve the issue.

[ChavdaSachin]

Fix is ready, thanks @Krishna2323 for pointing out.

[MarioExpensify]

Thank you @ChavdaSachin for quickly hopping in! And thanks @Krishna2323 for finding which was the affecting commit.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix header on ReportFieldsListValuePage #51495

If no regressions arise, payment will be issued on 2024-11-07. 🎊

[melvin-bot]

@MarioExpensify @johncschuster The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

Discussing with @MarioExpensify

[johncschuster]

Payment Summary:

Contributor+: @rushatgabhane due $250 via NewDot

[johncschuster]

@ChavdaSachin / @MarioExpensify / @rushatgabhane, can one of you complete the BZ Checklist above when you get a moment?

[johncschuster]

BugZero Checklist:

• @rushatgabhane Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• @rushatgabhane The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• @rushatgabhane If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• @rushatgabhane If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[johncschuster]

@rushatgabhane bump on the above!

[johncschuster]

Bumped in Slack

[rushatgabhane]

1. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Changed default visibility for caret - ListItemRightCaretWithLabel #51225 (comment)

2. If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not critical

3. If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - Not needed because it was a missed case during implementation

[garrettmknight]

$250 approved for @rushatgabhane