Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-10-25 #51448

Closed
49 tasks done
github-actions bot opened this issue Oct 25, 2024 · 16 comments
Closed
49 tasks done

Deploy Checklist: New Expensify 2024-10-25 #51448

github-actions bot opened this issue Oct 25, 2024 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Release Version: 9.0.54-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 25, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.54-0 🚀

@MarioExpensify
Copy link
Contributor

#51457 is just an alignment issue, dismissing as deploy blocker.

@Julesssss
Copy link
Contributor

Demoting #51465 as a blocker

@kavimuru
Copy link

Regression is at 63%
We have PRs to validate in 1 or 2 platforms for the unchecked PRs

@kavimuru
Copy link

Regression is at 80%.
Unchecked PRs: All the android slots pending verification due to this issue #51454
#47971 - Pending validation android
#49677 - Pending validation in android and Desktop
#50208 - Pending validation in android
#50766 - Pending validation in Android and iOS
#50770 - Pending validation in android and iOS
#50991 Pending validation in android
#51169 Pending validation in Android and mweb
#51213 Failing with original KI
#51225 Pending validation is Android
#51332 Pending validation
#51376 failing with #51526 repro in PROD checking it off

@Beamanator Beamanator self-assigned this Oct 28, 2024
@Beamanator
Copy link
Contributor

@Beamanator
Copy link
Contributor

marked #51543 NAB

@kavimuru
Copy link

Regression is 7% left (Android slots)
Unchecked PRs:
#49677 - Android validation is pending
#51169 - Android validation is pending, failing with #51542 in mweb
#51332 failing with #51532 repro in production checking it off
#51376 failing with #51526 in iOS, repro in PROD checking it off
#51213 failing with original KI #51213 (comment)

@kavimuru
Copy link

Regression is completed
unchecked PR:
#51169 - failing with #51542 in mweb
#51213 failing with original KI #51213 (comment)

@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 28, 2024
@jasperhuangg
Copy link
Contributor

#51584 was fixed by #51590

@NikkiWines
Copy link
Contributor

#51527 was also fixed by #51590

@Beamanator
Copy link
Contributor

Checking off #51169 b/c #51542 was decided as intentional

@Beamanator
Copy link
Contributor

Checking off #51213 b/c it didn't cause any additional blockers

@Beamanator
Copy link
Contributor

Checking off #51471 b/c a revert from yesterday fixed it!

@Beamanator
Copy link
Contributor

Beamanator commented Oct 29, 2024

Checked off #51482 and #51464 after discussing in slack - not big enough blockers, and we haven't deployed yesterday so we're calling these NAB to get the deploy out

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants