Handle optimistic data when creating new expenses in Control w/ Instant Submit #49677

youssef-lr · 2024-09-25T01:19:22Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/411554

Tests

Verify that no errors appear in the JS console

Create a Control workspace with Advanced Approvals
As the admin run this snippet in the console from the workspace admin page: Policy.getCurrent().policy.autoReportingFrequency = 'instant'; Policy.getCurrent().save();
And this one Policy.getCurrent().policy.isPolicyExpenseChatEnabled = true; Policy.getCurrent().save();
Configure the policy as in the screenshot below these test steps.
Submit an expense in NewDot
Login as the approver and approve it (it should be now forwarded to the admin)
Now log back in as the submitter and create another expense
Make sure a new report preview got created, and the expense is now in a new report.

Offline tests

The same steps as above, go offline before requesting, make sure a new report preview is created optimistically when the existing report is already approved.

QA Steps

Verify that no errors appear in the JS console

Create a Control workspace with Advanced Approvals
As the admin run this snippet in the console from the workspace admin page: Policy.getCurrent().policy.autoReportingFrequency = 'instant'; Policy.getCurrent().save();
And this one Policy.getCurrent().policy.isPolicyExpenseChatEnabled = true; Policy.getCurrent().save();
Configure the policy as in the screenshot below these test steps.
Submit an expense in NewDot
Login as the approver and approve it (it should be now forwarded to the admin)
Now log back in as the submitter and create another expense
Make sure a new report preview got created, and the expense is now in a new report.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…l approval

melvin-bot · 2024-09-25T01:19:27Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2024-09-27T12:23:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

49677.Android.mp4

49677.Android.Offline.mp4

Android: mWeb Chrome

49677.mWeb-Chrome.mp4

49677.mWeb-Chrome.Offline.mp4

iOS: Native

49677.iOS.mov

iOS: mWeb Safari

49677.mWeb-Safari.mov

MacOS: Chrome / Safari

49677.Web.mp4

MacOS: Desktop

49677.Desktop.mp4

mollfpr · 2024-09-27T15:52:10Z

Configure the policy as in the screenshot below these test steps.

@youssef-lr I don't see the screenshot, could you help me this? Thanks!

mollfpr · 2024-10-09T06:54:25Z

Configure the policy as in the screenshot below these test steps.

@youssef-lr I assume the configuration has another account that acts as a second approver? Is that correct?

49677.Web.mp4

Also, could you pull the latest main? Thank you!

youssef-lr · 2024-10-16T23:51:18Z

@youssef-lr I assume the configuration has another account that acts as a second approver? Is that correct?

That's correct. I merged main. Please check again @mollfpr

mollfpr

LGTM!

melvin-bot · 2024-10-18T09:30:45Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-10-18T09:30:48Z

🎯 @mollfpr, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #51075.

OSBotify · 2024-10-23T23:18:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-25T02:08:11Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-10-26T13:53:35Z

@jasperhuangg @mollfpr Can you please share the advance approval set up?

Configure the policy as in the screenshot below these test steps.

mollfpr · 2024-10-26T15:08:02Z

@kavimuru configuration should have another user forward the expense, similar to this.

github-actions · 2024-10-29T09:13:51Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

github-actions · 2024-10-29T11:38:08Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

youssef-lr added 3 commits September 25, 2024 01:30

Only add to an existing processing report if it's awaiting first leve…

607bdce

…l approval

Uew new helper function when deciding to create a new report

e0b4fab

Bug fix

8e8c6a2

youssef-lr requested a review from a team as a code owner September 25, 2024 01:19

melvin-bot bot requested review from mollfpr and removed request for a team September 25, 2024 01:19

youssef-lr changed the title ~~Youssef reports awaiting first level approval~~ Handle optimistic data when creating new expenses in Control w/ Instant Submit Sep 25, 2024

youssef-lr added 2 commits September 25, 2024 03:02

Cleanup

ddfa634

Fix test

f5bab22

Merge branch 'main' into youssef_reports_awaiting_first_level_approval

8d47250

youssef-lr mentioned this pull request Oct 16, 2024

Remove "submit expense" from the create menu in reports that can't be edited by the submitter #50734

Open

mollfpr approved these changes Oct 18, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg October 18, 2024 09:30

melvin-bot bot mentioned this pull request Oct 18, 2024

[Payment due Nov 5th] Payment issue for E/App PR#49677 #51075

Open

jasperhuangg approved these changes Oct 23, 2024

View reviewed changes

jasperhuangg merged commit 52b9984 into main Oct 23, 2024
17 checks passed

jasperhuangg deleted the youssef_reports_awaiting_first_level_approval branch October 23, 2024 23:08

github-actions bot mentioned this pull request Oct 25, 2024

Deploy Checklist: New Expensify 2024-10-25 #51448

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle optimistic data when creating new expenses in Control w/ Instant Submit #49677

Handle optimistic data when creating new expenses in Control w/ Instant Submit #49677

youssef-lr commented Sep 25, 2024 •

edited

Loading

melvin-bot bot commented Sep 25, 2024

mollfpr commented Sep 27, 2024 •

edited

Loading

mollfpr commented Sep 27, 2024

mollfpr commented Oct 9, 2024

youssef-lr commented Oct 16, 2024

mollfpr left a comment

melvin-bot bot commented Oct 18, 2024

melvin-bot bot commented Oct 18, 2024

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

kavimuru commented Oct 26, 2024

mollfpr commented Oct 26, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

Handle optimistic data when creating new expenses in Control w/ Instant Submit #49677

Handle optimistic data when creating new expenses in Control w/ Instant Submit #49677

Conversation

youssef-lr commented Sep 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 25, 2024

mollfpr commented Sep 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr commented Sep 27, 2024

mollfpr commented Oct 9, 2024

youssef-lr commented Oct 16, 2024

mollfpr left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 18, 2024

melvin-bot bot commented Oct 18, 2024

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

kavimuru commented Oct 26, 2024

mollfpr commented Oct 26, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

youssef-lr commented Sep 25, 2024 •

edited

Loading

mollfpr commented Sep 27, 2024 •

edited

Loading