Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Revert "Search suffix tree implementation""" #51590

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Revert "Revert "Revert "Search suffix tree implementation""" #51590

merged 1 commit into from
Oct 28, 2024

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Oct 28, 2024 •
edited
Loading

Reverts #51332

$ #51584

@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51590/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51590/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51590/NewExpensify.dmg https://51590.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@jasperhuangg jasperhuangg mentioned this pull request Oct 28, 2024
Open
8 tasks
@jasperhuangg jasperhuangg self-assigned this Oct 28, 2024
@jasperhuangg
Copy link
Contributor Author

Confirmed here that the revert should fix the linked deploy blocker

@jasperhuangg jasperhuangg marked this pull request as ready for review October 28, 2024 19:12
@jasperhuangg jasperhuangg requested a review from a team as a code owner October 28, 2024 19:12
@melvin-bot melvin-bot bot requested a review from arosiclair October 28, 2024 19:13
@jasperhuangg jasperhuangg removed the request for review from arosiclair October 28, 2024 19:13
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 28, 2024

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 28, 2024 19:13
NikkiWines
NikkiWines approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasperhuangg jasperhuangg merged commit c2ef291 into main Oct 28, 2024
14 of 17 checks passed
@jasperhuangg jasperhuangg deleted the revert-51332-reapply-suffix-search-tree branch October 28, 2024 19:13
@melvin-bot melvin-bot bot added the Emergency label Oct 28, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 28, 2024

@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@jasperhuangg
Copy link
Contributor Author

Straight revert

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 28, 2024
@jasperhuangg @OSBotify
Merge pull request #51590 from Expensify/revert-51332-reapply-suffix-…
90d8615 
…search-tree

Revert "Revert "Revert "Search suffix tree implementation"""

(cherry picked from commit c2ef291)

(CP triggered by AndrewGable)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 28, 2024
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Closed
49 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.0.54-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄 skipped 🚫

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄 skipped 🚫

@hannojg
Copy link
Contributor

hannojg commented Oct 29, 2024

@jasperhuangg when testing the adhoc build i can still reproduce the issue (video is a bit long but you can see that i actually test the build from this PR and can reproduce the crash):

output.mp4

The code of the search PR is never invoked in this testing flow so its not related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

Assignees

@jasperhuangg jasperhuangg

Labels
CP Staging marks PRs that have been CP'd to staging Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasperhuangg @OSBotify @hannojg @NikkiWines