-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search - Email address not found when searching without the special characters #51532
Comments
Triggered auto assignment to @mallenexpensify ( |
@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
@lanitochka17, I’ve tested the email search on the site, and it is working correctly. The email address is successfully found even when searching without special characters. Uploading (3) New Expensify - Google Chrome 2024-10-27 18-01-19 (1).mp4… |
📣 @D-01576! 📣
|
Contributor details |
|
Contributor details |
|
Contributor details |
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@lanitochka17, I’ve tested the email search on the site, and it is working correctly. The email address is successfully found even when searching without special characters. 3.New.Expensify.-.Google.Chrome.2024-10-27.18-01-19.1.mp4 |
I think this is expected. |
@FitseTLT, Yes but it is working |
That is exactly what I am saying. |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
I think this issue relates to this PR as mentioned in the issue title:
So it seems to be a bug that was introduced in that PR. That PR has already been reverted, so by now, it should be removed from staging and prod. |
After looking into that i think the problem is that the backend doesn't handle searches without special characters correctly. So a better reproduction is:
Here is a recording: CleanShot.2024-10-30.at.13.55.50.mp4This PR had nothing to do with that behaviour, as it also occurs on production with these reproduction steps: |
@hannojg, Yes, you are right |
Thanks @hannojg ! I see this above
Is that still correct? (asking cuz I think that was in reference to a previous offending PR) |
No it isn't, i think this has been identified as a backend (so internal) issue? |
Thanks @hannojg , labeled @muttmuure for prioritizing as part of #quality, here's the issue from Hanno above.
|
Bumped to weekly , I'm back from OOO on Nov 14th, not assigning another BZ, if one is needed please add or post in #contributor-plus to ask for one to be added, thx. |
Doesn't seem like the highest priority so leaving |
Waiting to get picked up. I don't think people search for emails without special characters often |
Checking on next steps here |
@Guccio163 can you comment here so I can assign to you, to work on after you've finished a couple other priorities. Thx |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+bm10@applause.expensifail.com
Issue reported by: Applause - Internal Team
Issue found when executing PR #51332
Action Performed:
) without special characters (e.g., hannomargeloio).
Expected Result:
The email address should be found
Actual Result:
The email address is not found
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6646745_1729955840283.1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: