Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Email address not found when searching without the special characters #51532

Open
2 of 8 tasks
lanitochka17 opened this issue Oct 26, 2024 · 29 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+bm10@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #51332

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Search for an email address (e.g., hanno@margelo.io
    ) without special characters (e.g., hannomargeloio).

Expected Result:

The email address should be found

Actual Result:

The email address is not found

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6646745_1729955840283.1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 26, 2024
Copy link

melvin-bot bot commented Oct 26, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@D-01576
Copy link

D-01576 commented Oct 27, 2024

@lanitochka17, I’ve tested the email search on the site, and it is working correctly. The email address is successfully found even when searching without special characters.

Uploading (3) New Expensify - Google Chrome 2024-10-27 18-01-19 (1).mp4…

Copy link

melvin-bot bot commented Oct 27, 2024

📣 @D-01576! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@D-01576
Copy link

D-01576 commented Oct 27, 2024

Contributor details
Your Expensify account email: waqarahmedchandio98@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016cece86c58b33bb5

Copy link

melvin-bot bot commented Oct 27, 2024

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

@D-01576
Copy link

D-01576 commented Oct 27, 2024

Contributor details
Your Expensify account email: waqarahmedchandio98@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016cece86c58b33bb5

Copy link

melvin-bot bot commented Oct 27, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@D-01576
Copy link

D-01576 commented Oct 27, 2024

Contributor details
Your Expensify account email: waqarahmedchandio98@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016cece86c58b33bb5

Copy link

melvin-bot bot commented Oct 27, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@D-01576
Copy link

D-01576 commented Oct 27, 2024

Contributor details
Your Expensify account email: waqarahmedchandio98@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~016cece86c58b33bb5

Copy link

melvin-bot bot commented Oct 27, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@D-01576
Copy link

D-01576 commented Oct 27, 2024

@lanitochka17, I’ve tested the email search on the site, and it is working correctly. The email address is successfully found even when searching without special characters.

3.New.Expensify.-.Google.Chrome.2024-10-27.18-01-19.1.mp4

@FitseTLT
Copy link
Contributor

I think this is expected.

@D-01576
Copy link

D-01576 commented Oct 29, 2024

I think this is expected.

@FitseTLT, Yes but it is working

@FitseTLT
Copy link
Contributor

I think this is expected.

@FitseTLT, Yes but it is working

That is exactly what I am saying.

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Oct 30, 2024

Weird that both @FitseTLT and @D-01576 aren't able to reproduce. I am on desktop, staging, Version 9.0.55-6 . And... before I searched via their email I tried hannomargeloio and nothing surfaced.

2024-10-29_17-01-55.mp4

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2024
@mallenexpensify mallenexpensify added Needs Reproduction Reproducible steps needed Overdue labels Oct 30, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@hannojg
Copy link
Contributor

hannojg commented Oct 30, 2024

I think this issue relates to this PR as mentioned in the issue title:

Issue found when executing PR #51332

So it seems to be a bug that was introduced in that PR. That PR has already been reverted, so by now, it should be removed from staging and prod.
I am working on a new PR soon to fix this (and other) issues!

@hannojg
Copy link
Contributor

hannojg commented Oct 30, 2024

After looking into that i think the problem is that the backend doesn't handle searches without special characters correctly.

So a better reproduction is:

  1. Create a new account
  2. Search for "hannomargeloio" (paste the value at once, don't type it out) -> notice that you don't find anything (see network tab)
  3. Search for "hanno@margelo.io" -> notice that now the correct result is returned
  4. Only now has the search result been added to your local application data
  5. Now the local search will work as well

Here is a recording:

CleanShot.2024-10-30.at.13.55.50.mp4

This PR had nothing to do with that behaviour, as it also occurs on production with these reproduction steps:

CleanShot 2024-10-30 at 13 59 07

@D-01576
Copy link

D-01576 commented Oct 30, 2024

@hannojg, Yes, you are right

@mallenexpensify
Copy link
Contributor

Thanks @hannojg ! I see this above

I am working on a new PR soon to fix this (and other) issues!

Is that still correct? (asking cuz I think that was in reference to a previous offending PR)

@mallenexpensify mallenexpensify removed the Needs Reproduction Reproducible steps needed label Nov 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@hannojg
Copy link
Contributor

hannojg commented Nov 4, 2024

I am working on a new PR soon to fix this (and other) issues!

Is that still correct?

No it isn't, i think this has been identified as a backend (so internal) issue?

@mallenexpensify mallenexpensify added the Internal Requires API changes or must be handled by Expensify staff label Nov 5, 2024
@mallenexpensify
Copy link
Contributor

Thanks @hannojg , labeled Internal.

@muttmuure for prioritizing as part of #quality, here's the issue from Hanno above.

the backend doesn't handle searches without special characters correctly.

@melvin-bot melvin-bot bot removed the Overdue label Nov 5, 2024
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Nov 6, 2024
@mallenexpensify
Copy link
Contributor

Bumped to weekly , I'm back from OOO on Nov 14th, not assigning another BZ, if one is needed please add or post in #contributor-plus to ask for one to be added, thx.

@melvin-bot melvin-bot bot added the Overdue label Nov 15, 2024
@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Nov 19, 2024
@muttmuure muttmuure added the Hot Pick Ready for an engineer to pick up and run with label Nov 19, 2024
@mallenexpensify
Copy link
Contributor

Doesn't seem like the highest priority so leaving Medium and Weekly

@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
@mallenexpensify
Copy link
Contributor

Waiting to get picked up. I don't think people search for emails without special characters often

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2024
@mallenexpensify
Copy link
Contributor

Checking on next steps here

@melvin-bot melvin-bot bot removed the Overdue label Dec 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Dec 23, 2024

@Guccio163 can you comment here so I can assign to you, to work on after you've finished a couple other priorities. Thx

@melvin-bot melvin-bot bot removed the Overdue label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

7 participants