-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedupe multiple UpdateComment requests #51149
Dedupe multiple UpdateComment requests #51149
Conversation
All contributors have signed the CLA ✍️ ✅ |
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have read the CLA Document and I hereby sign the CLA |
you need to link issue like this:
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-22.at.11.28.59.movAndroid: mWeb ChromeScreen.Recording.2024-10-22.at.11.20.49.moviOS: NativeScreen.Recording.2024-10-22.at.11.26.48.moviOS: mWeb SafariScreen.Recording.2024-10-22.at.11.17.31.movMacOS: Chrome / Safariweb-resize.mp4MacOS: Desktopdesktop.mp4 |
@zirgulis Can you update the video/screenshot for other platforms? Thanks |
@zirgulis 3 tests are failed |
@zirgulis please merge main |
d3757cf
to
6bbc963
Compare
@mountiny I've merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Not clear to me why the check is failing right now |
Perfect, thanks! |
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Tests were passing, not an emergency |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.54-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.54-11 🚀
|
Details
Problem:
When there's no internet connection,
UpdateComment
network requests get serialized in Onyx. When internet connection is back multipleUpdateComment
network request are posted to the backend even though only the lastUpdateComment
takes effect.Solution:
Dedupe multiple UpdateComment requests
Changes:
resolveDuplicationConflictAction
to accept therequestMatcher
function which does the filtering.resolveDuplicationConflictAction
usage in the codeUpdateComment
request when persisting to Onyx.Fixed Issues
$ #50074
PROPOSAL:
Tests
Offline tests
UpdateComment
sent to BE.QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android_browser.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios_browser.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
electron.mp4