[HOLD for payment 2024-11-28] [$250] When a row is selected in the chat switcher, it doesn't have rounded edges

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.58-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

1. Go to staging.new.expensify.com
2. Click Search > chats
3. Click chat finder and enter key word to search
4. Use the arrow keys on the keyboard to select a search result

Expected Result:

Row's selected style should have the rounded edges

Actual Result:

Row's selected style doesn't have the rounded edges

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854327558552515894
• Upwork Job ID: 1854327558552515894
• Last Price Increase: 2024-11-07
• Automatic offers:
• rayane-djouah | Reviewer | 104845398

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854327558552515894

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

When a row is selected in the chat switcher, it doesn't have rounded edges

What is the root cause of that problem?

styles.br2 is not added to listItemWrapperStyle prop.

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Line 268 in 580bf69

listItemWrapperStyle={[styles.pr3, styles.pl3]}

What changes do you think we should make in order to solve the problem?


• Add styles.br2 to listItemWrapperStyle prop.
• We might need to change the border radius value.
• We can also remove wrapperStyle: [styles.pr3, styles.pl3] from the line below because wrapperStyle won't be applied.
• Minor adjustments can be made in the PR. We can also consider removing pressableStyle, but we will test thoroughly before removing the styles. If we remove the styles then we can directly pass recentSearchesData without creating a new array styledRecentReports.
  

  App/src/components/Search/SearchRouter/SearchRouterList.tsx

  Line 202 in 580bf69

  const styledRecentReports = recentReports.map((item) => ({...item, pressableStyle: styles.br2, wrapperStyle: [styles.pr3, styles.pl3]}));

  
  

  App/src/components/SelectionList/BaseSelectionList.tsx

  Line 516 in afa7b33

  wrapperStyle={listItemWrapperStyle}

What alternative solutions did you explore? (Optional)

Result

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The highlighted row in the search router list is not rounded.

What is the root cause of that problem?

The structure of the row is Pressable > View. The border-radius isn't applied because the View has the same size as the pressable and the background overflow the Pressable.

App/src/components/SelectionList/BaseListItem.tsx

Lines 75 to 113 in afa7b33

	<PressableWithFeedback
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...bind}
	ref={pressableRef}
	onLongPress={() => {
	onLongPressRow?.(item);
	}}
	onPress={(e) => {
	if (isMouseDownOnInput) {
	e?.stopPropagation(); // Preventing the click action
	return;
	}
	if (shouldPreventEnterKeySubmit && e && 'key' in e && e.key === CONST.KEYBOARD_SHORTCUTS.ENTER.shortcutKey) {
	return;
	}
	onSelectRow(item);
	}}
	disabled={isDisabled && !item.isSelected}
	interactive={item.isInteractive}
	accessibilityLabel={item.text ?? ''}
	role={CONST.ROLE.BUTTON}
	hoverDimmingValue={1}
	hoverStyle={[!item.isDisabled && styles.hoveredComponentBG, hoverStyle]}
	dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: true}}
	onMouseDown={(e) => e.preventDefault()}
	id={keyForList ?? ''}
	style={[
	pressableStyle,
	isFocused && StyleUtils.getItemBackgroundColorStyle(!!item.isSelected, !!isFocused, !!item.isDisabled, theme.activeComponentBG, theme.hoverComponentBG),
	]}
	onFocus={onFocus}
	onMouseLeave={handleMouseLeave}
	tabIndex={item.tabIndex}
	wrapperStyle={pressableWrapperStyle}
	>
	<View
	style={[
	wrapperStyle,
	isFocused && StyleUtils.getItemBackgroundColorStyle(!!item.isSelected, !!isFocused, !!item.isDisabled, theme.activeComponentBG, theme.hoverComponentBG),

We already apply a padding to it, but it's applied to the wrapper (View), which means the View still has the same size.

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Line 268 in afa7b33

listItemWrapperStyle={[styles.pr3, styles.pl3]}

What changes do you think we should make in order to solve the problem?

We can set overflow: hidden to the pressable, but it still doesn't fix the blue outline cut off.

Instead, we can apply the padding to the pressable, just like with the "Recent searches" section.

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 106 to 109 in afa7b33

	return (
	<UserListItem
	pressableStyle={[styles.br2]}
	// eslint-disable-next-line react/jsx-props-no-spreading

pressableStyle={[styles.br2, styles.ph3]}

And set the wrapper padding to 0.

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Line 268 in afa7b33

listItemWrapperStyle={[styles.pr3, styles.pl3]}

listItemWrapperStyle={[styles.pr0, styles.pl0]}

[thishura]

@m-natarajan It looks like the same UI issue is consistent across all options in the left sidebar when using the search function and scrolling with the arrow keys

Expensify240711-1.mp4

[melvin-bot]

📣 @thishura! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rayane-d]

@bernhardoj's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @rayane-djouah

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix search item highlight doesn't have rounded edges #52351

If no regressions arise, payment will be issued on 2024-11-28. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @rayane-djouah requires payment automatic offer (Reviewer)

[melvin-bot]

@rayane-djouah @isabelastisser @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[bernhardoj]

Requested in ND.

[rayane-d]

BugZero Checklist:

• Classify the bug:

  Bug classification

  Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

  Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

  Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/49984/files#r1863672328

• If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [@isabelastisser] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

#### Precondition:

- N/A

#### Test:

1. Click the Search icon at the top to open the search modal.
2. Use the keyboard's down arrow key to navigate and highlight the recent search items.
3. Verify that the highlighted or focused items have rounded edges.

Do we agree 👍 or 👎

[melvin-bot]

@luacmartins, @isabelastisser, @bernhardoj, @rayane-djouah Eep! 4 days overdue now. Issues have feelings too...

[isabelastisser]

I was OOO last week; I will complete this today.

[isabelastisser]

Payment summary:

@bernhardoj requires payment through NewDot Manual Requests PENDING $250
@rayane-djouah paid in Upwork: automatic offer (Reviewer) $250

[isabelastisser]

All set!

[JmillsExpensify]

$250 approved for @bernhardoj