[HOLD for payment 2024-12-12] [$250] Critical: LHN says unavailable workspace

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproducing
Reproducible in production?: Needs Reproducing
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @heyjennahay
Slack conversation (hyperlinked to channel name): ts_external_expensify_migrate

Action Performed:

Prerequisite: Login as a expelled member of workspace and paymant received for submitted expense

1. Go to staging.new.expensify.com
2. Observe the LHN
3. Open the workspace to view the expenses

Expected Result:

The workspace chat is displayed as archived

Actual Result:

The workspace displayed as unavailable in LHN and refreshing the page resolves the issue

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

{
    "chatType": "policyExpenseChat",
    "currency": "USD",
    "description": "",
    "errorFields": {},
    "hasOutstandingChildRequest": false,
    "hasOutstandingChildTask": false,
    "isCancelledIOU": false,
    "isOwnPolicyExpenseChat": true,
    "isPinned": true,
    "isWaitingOnBankAccount": false,
    "lastActionType": "REPORTPREVIEW",
    "lastActorAccountID": "2012843",
    "lastMessageHtml": "paid £199.04",
    "lastMessageText": "paid £199.04",
    "lastReadSequenceNumber": 0,
    "lastReadTime": "2024-11-11 22:07:48.215",
    "lastVisibleActionCreated": "2024-11-11 21:52:20.625",
    "lastVisibleActionLastModified": "2024-11-11 21:52:20.625",
    "managerID": 0,
    "nonReimbursableTotal": 0,
    "notificationPreference": "always",
    "oldPolicyName": "",
    "ownerAccountID": 2840332,
    "participants": {
        "2840332": {
            "hidden": false,
            "notificationPreference": "always"
        },
        "9645353": {
            "hidden": false,
            "notificationPreference": "always"
        },
        "10903701": {
            "hidden": false,
            "notificationPreference": "always"
        }
    },
    "permissions": [],
    "policyAvatar": "",
    "policyID": "A5F944A401046336",
    "policyName": "Expenses - Expensify UK",
    "private_isArchived": "",
    "reportID": "7246397494396164",
    "reportName": "Chat Report",
    "stateNum": 0,
    "statusNum": 0,
    "total": 0,
    "type": "chat",
    "unheldNonReimbursableTotal": 0,
    "unheldTotal": 0,
    "welcomeMessage": "",
    "writeCapability": "all"
}

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856829046221721338
• Upwork Job ID: 1856829046221721338
• Last Price Increase: 2024-11-20
• Automatic offers:
• dominictb | Reviewer | 105008545

Issue Owner

Current Issue Owner: @dominictb

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021856829046221721338

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

[puneetlath]

The LHN says "unavailable workspace" part of this should be able to be handled externally. It seems to me to be a front-end issue.

I'm going to separate out the 404 receipts part of this.

[flaviadefaria]

@puneetlath I'll keep you assigned here as the BZ assignee but will look internally for someone to work on the backend part of this.

[flaviadefaria]

Updated this GH so that it only focuses on the "The LHN says 'unavailable workspace' part which can be handled externally.

[mkzie2]

@puneetlath Can you also share the json data of policy that is related to the policy expense chat and the transaction data with receipt 404? It's helpful to find the RCA.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[pac-guerreiro]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[pac-guerreiro]

Today I added test steps and filled my checklist. I need to add screenshots / screen recordings tomorrow.

[melvin-bot]

@puneetlath, @pac-guerreiro, @dominictb Eep! 4 days overdue now. Issues have feelings too...

[pac-guerreiro]

I added the remaining screenshots except the ones for iOS because I'm getting an issue importing the onyx state on the simulator.

I'll be off next week, but someone from my team will address any feedback reported here 😄

[JKobrynski]

Hi, I'm Julian from Callstack and I'm going to work on this issue in Pedro's absence.

[dominictb]

@JKobrynski I tried reproducing the bugs with steps from PR #53094 on main but couldn't. Also could you please elaborate on the root cause and the solution of this problem?

[JKobrynski]

This is what Pedro sent me:

• Root cause

If a user is removed from a workspace, he’ll still have access to the workspace chat history but some expense reports will show Unavailable workspace .

• Solution

I already created a PR with a possible fix for this by getting the workspace name from the parent report of the expense report.

Hope this answers your question, let me know if you need any additional details!

CC: @dominictb

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.71-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [$250] Critical: LHN says unavailable workspace #53094

If no regressions arise, payment will be issued on 2024-12-12. 🎊

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)
• @dominictb requires payment automatic offer (Reviewer)

[melvin-bot]

@dominictb @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[puneetlath]

@heyjennahay could you confirm that this has been fixed for you?

[heyjennahay]

Confirming I am no longer seeing the 404 error! Thanks!

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[bfitzexpensify]

Hey @dominictb - please complete the BZ checklist here and then I'll process the payment here

[dominictb]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/44970/files#r1881891874

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  Cannot find consistent reproducible steps so no need for regression test.

[bfitzexpensify]

Thanks! Payment complete.