Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users land on the wrong VBA flow step if coming from a redirect from the deprecated /bank-accounts/requestor route #5263

Closed
luacmartins opened this issue Sep 15, 2021 · 3 comments
Assignees
Labels

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Sep 15, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Coming from here #5081 (comment)

  1. Navigate to /bank-account/requestor, you will get redirected (router redirection) to /bank-account/personal-information.
  2. If you enter directly to /bank-account/personal-information or just reload the page after getting redirected, it will take you to the wrong step.

Expected Result:

  1. User should land on the correct step.
  2. Entering a wrong URL such as /bank-account/requestor should bring the user to the first step.

Actual Result:

User lands on BankAccountStep.

Workaround:

Do not use the deprecated /bank-account/requestor url.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@luacmartins luacmartins added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Sep 15, 2021
@luacmartins luacmartins self-assigned this Sep 15, 2021
@MelvinBot
Copy link

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 15, 2021
@luacmartins luacmartins added the Reviewing Has a PR in review label Sep 15, 2021
@botify botify closed this as completed Sep 15, 2021
@botify
Copy link

botify commented Sep 15, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@botify
Copy link

botify commented Sep 15, 2021

🚀 Deployed to staging by @thienlnam in version: 1.0.98-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants