Change "Requestor Information" to "Personal Information" and make requirements clearer in VBA flow

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem

The "Requestor Information" step of the VBA flow has a few opportunities to improve:

• "Requestor Information" does not immediately clarify that we want someone's personal info, and it's somewhat of a technical term.
• Unlike other flows in the VBA setup process, there is no line clarifying below the header that explains what we want the user to do at this step. To that end, users often get confused that we want their information at this step, so this is an opportunity to make that clearer.
• The [learn more / is my data safe?] links are shown after a user has provided their personal info. Chances are they want these links when deciding whether or not to provide this info at all (see highlight in screenshot)

Reproduction Steps

1. Create Workspace
2. Select Get Started and begin going through VBA steps with test credentials in (2)
3. Arrive at "Requestor Info" step

Solution

1. change Requestor Information to Personal Information
2. Update URL from new.expensfiy.com/bank-account/requestor to new.expensfiy.com/bank-account/personal-information
3. Add a clarifying line of what we're asking for at this step, like we do for company info (Screenshot below for reference), and move the Learn More and Is my data safe? into this line so it's at the top of the page, and not the bottom.

Please provide your personal information Learn more | Is my data safe?

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @MitchExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MitchExpensify]

I assume you are also proposing a URL change to this step too @kevinksullivan ? (Currently /requestor)

[kevinksullivan]

Updated the OP to incorporate that change @MitchExpensify . Is this going to be external or internal?

[MitchExpensify]

Let's go internal! Easy fix and quicker for us to grab

[botify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[botify]

🚀 Deployed to staging by @Julesssss in version: 1.0.95-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[JmillsExpensify]

Woo! Thanks @luacmartins for the quick work.

[aldo-expensify]

I just noticed that this change added the following behaviour:

Navigate to /bank-account/requestor, you will get redirected (router redirection) to /bank-account/personal-information

If you enter directly to /bank-account/personal-information or just reload the page after getting redirected, it will take you to the wrong step. I think this is happening because the PR missed to update the route here:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 127 to 128 in bf6d1d0

	case 'requestor':
	return CONST.BANK_ACCOUNT.STEP.REQUESTOR;

When you enter directly to /bank-account/personal-information, it takes to the "Add Bank Account" step, but the url stays the same.

[luacmartins]

Nice catch @aldo-expensify! Thank you so much!

Fix here #5264.