Change "Requestor Information" to "Personal Information" and make requirements clearer in VBA flow #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about adding just a little more separation between the blue links and the line above? Maybe try adding |
|
This is how it looks with |
|
Nice, I like that better! What are your thoughts? |
|
It does look better. I'll make the change and update the images. Thanks @shawnborton! |
Julesssss
reviewed
Sep 9, 2021
| <View style={[styles.mb5, styles.mt1, styles.dFlex, styles.flexRow]}> | ||
| <TextLink | ||
| style={[styles.textMicro]} | ||
| // eslint-disable-next-line max-len |
There was a problem hiding this comment.
Do we still need this line? I thought that we increased the max line count.
Julesssss
reviewed
Sep 9, 2021
| <Text style={[styles.textMicroSupporting]}>{' | '}</Text> | ||
| <TextLink | ||
| style={[styles.textMicro, styles.textLink]} | ||
| // eslint-disable-next-line max-len |
Julesssss
approved these changes
Sep 9, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
14 tasks
|
🚀 Deployed to staging by @Julesssss in version: 1.0.95-2 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR changes
Requestor informationtoPersonal information, as well as updates the URL to the step and adds a clarifying line below the header text.Fixed Issues
$ #5081
Tests
Settings > Select Workspace > Get StartedPersonal informationstep. You can add these credentials if needed.QA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android