-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-19] [$150] IOS/Android-Verify account-Inconsistent behavior when returning from Let's make sure it is you #52959
Comments
Triggered auto assignment to @VictoriaExpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOS/Android-Verify account-Inconsistent behavior when returning from Let's make sure it is you What is the root cause of that problem?It's because the ValidateCodeActionModal is wrapped inside ScrollView component App/src/pages/ReimbursementAccount/BankAccountStep.tsx Lines 228 to 243 in 8d69d60
I can see like inside Profile page the ValidateCodeActionModal got dismissed properly when we click the back button because the ValidateCodeActionModal is not wrapped by ScrollView App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx Lines 156 to 180 in 8d69d60
But in the other side like inside Bank account page the ValidateCodeActionModal is not get dismissed properly because it's wrapped by ScrollView, example here: App/src/pages/ReimbursementAccount/BankAccountStep.tsx Lines 228 to 243 in 8d69d60
Copilot
App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx Lines 76 to 88 in 8d69d60
App/src/components/HeaderPageLayout.tsx Lines 101 to 107 in 8d69d60
What changes do you think we should make in order to solve the problem?We should put the ValidateCodeActionModal outside the ScrollView App/src/pages/ReimbursementAccount/BankAccountStep.tsx Lines 228 to 243 in 8d69d60
And we can do the same approach for other pages also ResultScreen.Recording.2024-11-22.at.07.02.17.movWhat alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Inconsistent behavior on some pages that use the magic code validation modal. What is the root cause of that problem?For the copilot and bank account validation modal, the validation modal is wrapped inside a ScrollView. App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx Lines 76 to 88 in a35df5b
App/src/components/HeaderPageLayout.tsx Lines 101 to 107 in a35df5b
App/src/pages/ReimbursementAccount/BankAccountStep.tsx Lines 228 to 242 in a35df5b
ScrollView by default will dismiss the keyboard first when tapping on it, so we need to press the back button again to close the modal. Compared to the issue new card confirm page, the modal is outside the scroll view, so it doesn't have this problem. What changes do you think we should make in order to solve the problem?In a normal case, we won't have this problem because a header is usually not wrapped in a scroll view. But in this case, it's a bit different because the modal is put inside the scroll view, so the whole modal is affected. To fix this, we can
It's the same as what we did on the contact method details page. App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx Lines 244 to 273 in a35df5b
This is especially useful for cases like the copilot confirm page because it uses HeaderPageLayout and the children is always wrapped with a scroll view. For other cases, if it's possible to put the modal outside the scroll view, then we put it outside the scroll view. It's technically possible for the copilot confirm page too by doing it like this:
But I think it would be cleaner to just apply Also, there are other pages that put the modal inside the scroll view too which we may need to fix too, such as the CodesStep. App/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx Lines 172 to 186 in a35df5b
|
Hmm ok so I think this is a pretty minor issue, but because we do want everything to be consistent, we should fix it. My feeling is that this is a pretty easy fix so I'm going to lower the bounty on this one. If I'm missing anything to do with the complexity here, please let me know. |
Job added to Upwork: https://www.upwork.com/jobs/~021861312036312016837 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
Upwork job price has been updated to $150 |
@bernhardoj's proposal looks good to me! 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
assigned |
PR is ready cc: @thesahindia @VictoriaExpensify btw, I think we can keep the price at a normal price (250) since we need to fix this at 3 pages, so we need to test more too. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-19. 🎊 For reference, here are some details about the assignees on this issue:
|
@thesahindia @VictoriaExpensify @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Payment Summary
BugZero Checklist (@VictoriaExpensify)
|
Payment summary: |
Requested in ND. |
$250 approved for @bernhardoj |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.65.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #52232
Action Performed:
precondition: user has enabled Expensify card
Expected Result:
User is navigated to the previous screen after tapping the back icon on "Let's make sure it is you" in the flows where code validation is required
Actual Result:
When tapping the back icon on "Let's make sure it is you" step in the Add copilot and Add bank account flows (steps 4 and 9), the keyboard gets dismissed while in the other flows (Issue a new card, Add new contact method, Reveal card details) user is returned to the previous screen immediately (steps 12 and 15)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6672434_1732229158372.video_2024-11-21_17-41-09.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @VictoriaExpensifyThe text was updated successfully, but these errors were encountered: