[HOLD for payment of bonus-only 2021-12-06] VBA- disabling future dates in the date picker

[SofiedeVreese]

Coming from #5722

---

Creating a new issue for disabling future dates in the date picker and assigning that to @Santhosh-Sellavel per CME @puneetlath 's comment here.

[SofiedeVreese]

@Santhosh-Sellavel proposal:

Proposal

In DatePicker add a new prop maximumDate

For iOS & Android Native files we can use maximumDate prop to restrict.

For Web/Desktop:
We have a max attribute for input type date to restrict the maximum range.
Also similarly we can customize it for minimumDate also if needed additionally.

We can take advantage of these props to avoid unnecessary min & max date range validation.

Screens

[SofiedeVreese]

Exported to Upwork: https://www.upwork.com/jobs/~010a6aab5d586f3145

[SofiedeVreese]

Hey @Santhosh-Sellavel are you still wanting to work on this one?

[Santhosh-Sellavel]

Yes @SofiedeVreese assign me this one.

Applied on upwork!

[SofiedeVreese]

Perfect thanks @Santhosh-Sellavel- I've just hired you in Upwork!

[Santhosh-Sellavel]

@puneetlath

I've have added props to restrict date selection for the picker.

Default props value are null for both min & max. So no restriction by default.

For incorporation date picker, what is the min, max date.

[SofiedeVreese]

@Santhosh-Sellavel Puneet is OOO this week, I'll try and see if I can find another CME to help you out with this!

@Luke9389 would you be able to help out with Santosh' query above in Puneet's OOO?

[Luke9389]

@Santhosh-Sellavel I don't think we have a minimum date. The maximum should be now right? The issue is specifically focused on disallowing future dates for the incorporation date.

[Santhosh-Sellavel]

Yes maximum should be now or earlier. Just need a confirmation.

Also no minimumDate, I'll submit a PR tomorrow!

[SofiedeVreese]

Hey @Santhosh-Sellavel I'm so sorry but @Luke9389 and I realised there are a couple of double-ups and your proposal is being tackled in another PR.

To avoid dupe solutions, we're going to close this one, so no need to work on your PR. I will be paying you out for your efforts, and will close the Upwork contract upon payment.

[SofiedeVreese]

Upwork job closed, payment completed.

[Santhosh-Sellavel]

May I know which PR, @Luke9389 or @SofiedeVreese

[Luke9389]

Yep, it's this one #5939

It was decided here to split the issue up into two parts, but the other contributor ended up implementing both (mistakenly I'm sure). Because their PR is already in review, and the code change that overlaps with this one looks fine in that PR, we've opted to just keep it instead of undoing the changes in that PR and then merging both PRs on the same file. It's easier to manage and cleaner this way.

[Santhosh-Sellavel]

Thanks, @Luke9389

But what I am proposing is different from what has been done in #5939
Refer to my proposal in a comment here -> #5922 (comment)

The solution I proposed is to handle the restriction in the date picker component itself just by using minDate & maxDate props, so the user won't be able to pick the future date.

But why do we need the changes in PR #5939,

Even if we disable the future dates in picker since the user doesn't have to use the picker in Web or Desktop

So only the issue was split up into two parts as said here

I think there is some misunderstanding here.
If you are aware of all the above, then we are good here!

[PrashantMangukiya]

@Santhosh-Sellavel you are right.

You are implementing to disable future date in date picker, and my implementation in PR #5939 is to validate date during form submit and not allow future date and show error message etc.

So me and @Santhosh-Sellavel solving same problem but via different implementation as decided here to split issue #5722 (comment) as both solution is need.

So solution implemented in PR #5939 is different than @Santhosh-Sellavel solution and @Santhosh-Sellavel solution also need.

cc @Luke9389 @SofiedeVreese

[puneetlath]

@SofiedeVreese @Luke9389 I'm back from vacation now. What @PrashantMangukiya said is correct. I recommended that we split the implementation of the validation and the date picker changes here which is why there are separate issues and they are submitting separate PRs.

[Luke9389]

Ah OK so let me see if I have this straight. We are adding the following line in @PrashantMangukiya's PR because they don't have to use the date picker:

return testDate.isValid() && testDate.isBetween(pastDate, currentDate);

In @Santhosh-Sellavel's PR we'll be making changes to the DatePicker component itself to make future dates unselectable.

Is that correct @puneetlath?

[puneetlath]

That's correct!

[Luke9389]

OK cool!
Sorry to have thrown a wrench in the works here, heh.
@Santhosh-Sellavel please feel free to resume your PR.

[SofiedeVreese]

No updates on this: open PR.

[SofiedeVreese]

Not overdue, PR is open.

[puneetlath]

@SofiedeVreese the PR has been merged. Let's make sure to add the company offsite bonus for @Santhosh-Sellavel when you pay this one out. Thanks!

[SofiedeVreese]

This job was already paid out as we closed it due to a suspected double-up. But I'll pay out the bonus amount 7 days from successful deploy!

[SofiedeVreese]

Deployed to Prod- as the original amount was already paid out, only the Offsite hold bonus is remaining which I'll pay out 7 days from today.

[SofiedeVreese]

Hey @Santhosh-Sellavel I've just paid out the remaining bonus amount of $250 for the company offsite hold.

I've paid out the bonus via the original contract.

Closing GH.