[$250] iOS - VBA - Unable to see dates clearly or missing altogether in company /personal info page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app and login with an applause.expensifail account
2. Select account workspace
3. Navigate to “connect bank account”
4. Log in with chase credentials
5. Proceed to company info page
6. Navigate to incorporation date and select a random date
7. Add all required details and select continue
8. Navigate to Date of birth in personal info page

Expected Result:

Months, year and day would be listed clearly in drop down or missing altogether

Actual Result:

For incorporation date - Only month displayed is December, displayed day starts from 24 and displayed year starts from 2022
For Date Of Birth - Dates are completely missing

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.16-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5342304_IMG_1735.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Two potential candidates that may have caused this regression since they deal with the date picker:

#5939
#6192

If I had to guess I'd say this one is more likely the cause since it's adding a maximumDate attribute and I have no idea what the expected behavior for that should be:

https://github.com/Expensify/App/pull/6192/files

[marcaaron]

I think it is this package @react-native-community/datetimepicker but then just shoved inside a Popover component here:

App/src/components/DatePicker/index.ios.js

Lines 82 to 112 in 3ac6de4

	<Popover
	isVisible={this.state.isPickerVisible}
	onClose={this.selectDate}
	>
	<View style={[
	styles.flexRow,
	styles.justifyContentBetween,
	styles.borderBottom,
	styles.pb1,
	styles.ph4,
	]}
	>
	<Button
	title={this.props.translate('common.reset')}
	color={themeColors.textError}
	onPress={this.reset}
	/>
	<Button
	title={this.props.translate('common.done')}
	color={themeColors.link}
	onPress={this.selectDate}
	/>
	</View>
	<RNDatePicker
	value={this.state.selectedDate}
	mode="date"
	display="spinner"
	onChange={this.updateLocalDate}
	locale={this.props.preferredLocale}
	maximumDate={this.props.maximumDate}
	/>

[marcaaron]

Going to try to reproduce this now and see if reverting either of those PRs fixes the issue.

[sketchydroide]

Sorry for a moment I thought this was the old app, and then I understood my misunderstanding and deleted the comment shamefully

[marcaaron]

Haha all good thanks 😂

[marcaaron]

Sorry. I'm not able to reproduce this at all so unsure how to continue investigating.

[marcaaron]

Need to update Xcode to test this - will look at the linked library issues - based on this comment most likely there is some issue with iOS 15 and nothing wrong with any new code that we have written.

[chiragsalian]

Looks like the issue is reproducible on production so i'm removing the DeployBlockerCash label. Gonna still keep it as daily since its important to address soon.

[kidroca]

Seems very similar to this: react-native-datetimepicker/datetimepicker#526 and this react-native-datetimepicker/datetimepicker#524

It's likely a problem with the library itself
Since we have DatePicker/index.ios.js maybe we can switch to a different library to address this faster

[MelvinBot]

Huh... This is 4 days overdue. Who can take care of this?

[marcaaron]

Another short term option would be to switch back to a regular text input on iOS 15 until this has been resolved.

[marcaaron]

I'm not able to repro this on iOS sim running iOS 15. Going to drop this down to a weekly. We can bump it back up if anyone is able to repro locally and wants to fix.

[melvin-bot]

📣 @JosueEchandiaAsto You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Beamanator]

Hiring @JosueEchandiaAsto as I also like their proposal 👍

@mallenexpensify yes I think we should compensate $250 for reproduction steps & $250 for the fix

[JosueEchandiaAsto]

PR Created 🎉 #9599

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Beamanator]

PR merged a week ago, still waiting for deployment. Changing priority back to Weekly

[laurenreidexpensify]

Merged and on staging, should hit prod this week

[laurenreidexpensify]

heh this hit prod 7 days ago. I'll issue payment tomorrow

[laurenreidexpensify]

@JosueEchandiaAsto @parasharrajat have just sent offers in Upwork - sorry for the delay! As soon as those are accepted I'll issue payment and close this out. Sorry that this wasn't the smoothest - the automation trigger failed here and that slowed us down from closing this out!

[laurenreidexpensify]

all paid 👍🏽

[JosueEchandiaAsto]

Hi @laurenreidexpensify The compensation for the reproduction steps is pending 🥲
#6438 (comment)

[JosueEchandiaAsto]

some news?.. @laurenreidexpensify

CC: @mallenexpensify @Beamanator

[parasharrajat]

Bump @mallenexpensify Maybe you can help @JosueEchandiaAsto here.

[mallenexpensify]

Thanks for the ping @parasharrajat , for some reason I didn't see the post from you two days ago @JosueEchandiaAsto . Apologies for the delay in payment. I just issued you a $250 bonus on the same Upwork job. Thanks for the help!

[JosueEchandiaAsto]

Thanks @mallenexpensify