[HOLD for payment 2022-01-17] Chat - Indentation is not preserved in comments

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to any chat
2. Send a message with indentation
3. Some item
   i. Some sub-item
   ii. Some other sub-item
4. Some other item

Expected Result:

Message should be received with indentation

Actual Result:

Format is not persisting

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.20-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1639498323234800

View all open jobs on GitHub

view this job on upwork

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jboniface]

https://www.upwork.com/jobs/~010dbb053733c33760

[MelvinBot]

Triggered auto assignment to @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

Aha, it seems straightforward so I like to propose here.

1. Enable this flag

   App/src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js

   Line 304 in d012bea

   dangerouslyDisableWhitespaceCollapsing={false}

   .

It will disable the whitespace collapsing.

[roryabraham]

@jsamr Any chance you can provide context on why that dangerouslyDisableWhitespaceCollapsing is dangerous?

[deetergp]

@parasharrajat Your proposal seems like an easy fix, let's do it!

I'm curious why it's marked dangerous. Following it to its source in react-native-render-html module it looks like they have a convention of naming any of their experimental methods and properties as dangerous….

[parasharrajat]

I can't give you the proper reason why it was marked as dangerous but I think works great for our app and there are no apparant regressions to me.

[jsamr]

@jsamr Any chance you can provide context on why that dangerouslyDisableWhitespaceCollapsing is dangerous?

Good spot, that is not documented. It is marked dangerous because its side effects are undetermined (have not been assessed thoroughly, appart from the obvious effect of preserving all whitespaces). "dangerous" here means "use it knowingly and with care, strange things could happen"...

[deetergp]

Reviewed, approved, & merged.

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.26-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Preserve the whitespace in the mesages #6975

If no regressions arise, payment will be issued on 2022-01-17. 🎊

[jboniface]

@parasharrajat looks like we never hired on upwork and the job closed itself. i sent a new one.

[jboniface]

paid but forgot to close