Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve the whitespace in the mesages #6975

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Preserve the whitespace in the mesages #6975

merged 1 commit into from
Jan 5, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jan 1, 2022 •
edited
Loading

Details

Fixed Issues

$ #6769

Tests | QA Steps

  1. Send some message which has whitespace.
  2. Whitespace should be preserved.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

Screenshot 2022-01-04 22:34:19

iOS

Android

Screenshot 2022-01-04 23:18:02

@parasharrajat parasharrajat marked this pull request as ready for review January 5, 2022 12:19
@parasharrajat parasharrajat requested a review from a team as a code owner January 5, 2022 12:19
@botify botify requested a review from deetergp January 5, 2022 12:19
@MelvinBot MelvinBot removed the request for review from a team January 5, 2022 12:19
deetergp
deetergp approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes tests; LGTM!

@deetergp deetergp merged commit 6f97362 into Expensify:main Jan 5, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jan 5, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jan 5, 2022
Closed
21 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2022

🚀 Deployed to staging by @deetergp in version: 1.1.25-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Jan 10, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.26-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@aldo-expensify aldo-expensify mentioned this pull request May 17, 2022
Closed
@aldo-expensify aldo-expensify mentioned this pull request May 26, 2022
Merged
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @deetergp