Remove whitespace: pre because of extra empty lines bug #9195

aldo-expensify · 2022-05-26T22:29:08Z

Details

This PR needs the changes from the PR: https://github.com/Expensify/Web-Expensify/pull/33993 . This PR without PR#33993 shouldn't break anything.

This PR is reverting partially what was done here: https://github.com/Expensify/App/pull/9025/files

There are email clients like outlook that add a bunch of \n in between the html of the email. The whitespace: pre cause these \n to be rendered as empty lines.

This PR is applying whitespace: pre to messages that don't have source: "email" and whitespace: normal for messages that have it. Email clients don't use whitespace: pre when showing the email body, they use &nbsp to force/keep whitespaces.

When testing / QA we should make sure that the test / QA from these PRs also passes:

Fixed Issues

$ #8088

Tests

Create two accounts, one using a free email from https://outlook.live.com/
Log in into NewDot with one of these accounts and create a chat with the other, save the chat ID: http://localhost:8080/r/<chat ID>
Send a comment with the following content (without codeblock):
```
0 spaces
 1 spaces
  2 spaces
   3 spaces
    4 spaces
 
```

Send another comment with the following content (including a code block)

0 spaces
 1 spaces
  2 spaces
   3 spaces
    4 spaces

```
some code
```

You should see that whitespaces are respected and that there aren't extra white lines added
Send an email from the outlook email account so it gets converted as a message in the chat you just created. This SO is useful to get that going in DEV. You should be sending an email with:
- To: "Expensify rID:<replace-chat-id-here>" <postmaster@sandboxbdd8eb86efaa4dd68b56e83b7b379bd9.mailgun.org>
- Subject: What ever you configured (for example, in my case I use "ALDO_TESTING_CREATE_REPORT_COMMENT")
- Body: type some message with some line jumps like this:
The email should appear in the new dot conversation
You should see that it doesn't have an excessive amount of empty lines

QA (Production)

Create two accounts, one using a free email from https://outlook.live.com/
Log in into NewDot with one of these accounts and create a chat with the other, save the chat ID: https://new.expensify.com/r/<chat ID>
Send a comment with the following content (without codeblock):
```
0 spaces
 1 spaces
  2 spaces
   3 spaces
    4 spaces
 
```

Send another comment with the following content (including a code block)

0 spaces
 1 spaces
  2 spaces
   3 spaces
    4 spaces

```
some code
```

You should see that whitespaces are respected and that there aren't extra white lines added
Send an email from the outlook email account so it gets converted as a message in the chat you just created. You should be sending an email with:
- To: replies+<replace-your-chat-id-here>@expensify.com
- Subject: Anything
- Body: type some message with some line jumps like this:
The email should appear in the new dot conversation
You should see that it doesn't have an excessive amount of empty lines

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

Verify that no errors appear in the JS console

Screenshots

Web

Before fix	After fix

Mobile Web

Desktop

iOS

Android

Before fix	After fix

aldo-expensify · 2022-05-26T22:51:07Z

@parasharrajat since you are somewhat familiarized with the problem... do you know of any regressions this PR could cause by removing whiteSpace: 'pre',?

aldo-expensify · 2022-05-26T23:53:20Z

Update: ❗ I think this is not avoid copy/pasting or not... is about a message containing a code block or not

I can see that this breaks in some cases when you copy/paste HTML stuff that had white spaces. I.e. copy the sample text from test step 3) and paste it as comment using CMD + SHIFT + V, whitespaces will be lost:

The whitespaces are simply gone when looking at the DOM. The spaces seem to be getting lost in the rendering process because I can see them coming from the backend in the Report_History:

"0 spaces<br /> 1 spaces<br />  2 spaces<br />   3 spaces<br />    4 spaces<br /> <pre>some code</pre><pre>some more      code<br /><br />asdad asd asd. asda.       asd</pre><br />1. Some item<br />    i. Some subitem 1<br />    ii. Some subitem 2<br />2. Some item 2"

And this is one that looks fine:

"0 space<br />  2 spaces<br />    4 spaces<br />      6 spaces"

I'm not sure about what is the difference yet.

Update: ❗ I think this is not avoid copy/pasting or not... is about a message containing a code block or not

parasharrajat · 2022-06-03T20:52:34Z

I will dig this over the weekend and let you know. Thanks for waiting.

…aldo_fix-empty-lines

aldo-expensify · 2022-06-04T01:14:25Z

The easiest way to reproduce is to add this line in the promise handler for DeprecatedAPI.Report_GetHistory here:

            data.history = [{"person":[{"type":"TEXT","style":"strong","text":"aldo+test-spacing1@expensifail.com"}],"actorEmail":"aldo+test-spacing1@expensifail.com","actorAccountID":11030556,"message":[{"type":"COMMENT","html":"     <div class=\"WordSection1\"> <p class=\"MsoNormal\">Hi SomeName, <\/p><p><\/p> <p class=\"MsoNormal\"><\/p><p>\u00a0<\/p> <p class=\"MsoNormal\">Will tomorrow at 34 est. work?<\/p><p><\/p> <p class=\"MsoNormal\"><\/p><p>\u00a0<\/p> <p class=\"MsoNormal\">Thanks,  Test<\/p><p><\/p> <p class=\"MsoNormal\"><\/p><p>\u00a0<\/p> <\/div>xxxxxx xxxxxxxx xx xxx: xxxx x-xxxx xxx xxxxxxxxxx xx xxxxxxxxxxxxx xx xxxxxxxxxxxx xxxxx x.x. xxx, xx xxx xxxxxxx xxxxxxx xx xx xxxxxxxxx xx xxxxxxx x xxxxxxxxxx xxxxxxx xx xxxxxxx. xxx xxx xxxxxx xxx xx xxxxxxx xxxxxxxxxxx xxx xxxxxxxxxxx xxxxxxxx xxxx xxxxx  xxx (xxxxxx xxx xxx xxxxx.xxx xxxxxxx, xxxxx xxxxxx x-xxxx xxxxxxxxxxx xxxxxxx x xxxxxxxx xxxxxxx) xx xxxx x-xxxx xxxxxxx xx xxxxxxxxxx xxxx xxxxxxx xx xxxxxxxxxxxxxxxx@xxxxx.xxx. xx xxx xx xx, xxx xxxxxx xx xxxx xxxxxxx xxxx xx xxxxxxxx xxxxxxxx. xxx xxxxxxxxx  xxxxxx xxxxxxx xx 225 x xxxxxx xxxxx, xxxxx 2600, xxxxxxx, xx 60602-4903.  xxxx xxxxx xxxxxxx xx xxxx xxxxx xxx xx xxx xx xxx xxxxxxxxxxxx xxx xxx xxxxxxx xxxxxxxxxx xx xxxxxxxxxxxx xxxxxxxxxxx  xx xxxxx xxxxxxxxxxx xxxxxx xxxx xxxxxxxxxx xxxxx xxxxxxxxxx xxx. xx xxx xxx xxx xxx xxxxxxxx xxxxxxxxx, xxxxxx xxxxxx xxx xxxxxx xx xxxxx xxxxx xxxxxxxxxxx xxx xxxxxx xxxx xxxxxxx xxxxxxx xxxxxxx xxxxxxx xx xxxxxxxxxx xx xxxxxx. xxxx xxxxx xx xxx xxxxxxxx  xx xx x xxxxxxxx xx xxxxx xxxxxxx xxxxxxx xxxxxxxxxx, xxx xxx xxx xxxxxx xxxxxxxxx xx xxxx xxxxx xxxxxx xxx xx xxxxxxxxx xx x xxxxxx xxx xxxxxxx xxxxxx xxxxxxxxx xxxxxx. xxxxx xxx.xxxxx.xxx\/xxxxxxxxxx xxx xxxx xxxxxxxxxxx xxxxx xxxxx xxx xxx xxx xxxxxxxxxxxx.     ","text":"      Hi SomeName,  \u00a0 Will tomorrow at 34 est. work? \u00a0 Thanks,  Test \u00a0 xxxxxx xxxxxxxx xx xxx: xxxx x-xxxx xxx xxxxxxxxxx xx xxxxxxxxxxxxx xx xxxxxxxxxxxx xxxxx x.x. xxx, xx xxx xxxxxxx xxxxxxx xx xx xxxxxxxxx xx xxxxxxx x xxxxxxxxxx xxxxxxx xx xxxxxxx. xxx xxx xxxxxx xxx xx xxxxxxx xxxxxxxxxxx xxx xxxxxxxxxxx xxxxxxxx xxxx xxxxx  xxx (xxxxxx xxx xxx xxxxx.xxx xxxxxxx, xxxxx xxxxxx x-xxxx xxxxxxxxxxx xxxxxxx x xxxxxxxx xxxxxxx) xx xxxx x-xxxx xxxxxxx xx xxxxxxxxxx xxxx xxxxxxx xx xxxxxxxxxxxxxxxx@xxxxx.xxx. xx xxx xx xx, xxx xxxxxx xx xxxx xxxxxxx xxxx xx xxxxxxxx xxxxxxxx. xxx xxxxxxxxx  xxxxxx xxxxxxx xx 225 x xxxxxx xxxxx, xxxxx 2600, xxxxxxx, xx 60602-4903.  xxxx xxxxx xxxxxxx xx xxxx xxxxx xxx xx xxx xx xxx xxxxxxxxxxxx xxx xxx xxxxxxx xxxxxxxxxx xx xxxxxxxxxxxx xxxxxxxxxxx  xx xxxxx xxxxxxxxxxx xxxxxx xxxx xxxxxxxxxx xxxxx xxxxxxxxxx xxx. xx xxx xxx xxx xxx xxxxxxxx xxxxxxxxx, xxxxxx xxxxxx xxx xxxxxx xx xxxxx xxxxx xxxxxxxxxxx xxx xxxxxx xxxx xxxxxxx xxxxxxx xxxxxxx xxxxxxx xx xxxxxxxxxx xx xxxxxx. xxxx xxxxx xx xxx xxxxxxxx  xx xx x xxxxxxxx xx xxxxx xxxxxxx xxxxxxx xxxxxxxxxx, xxx xxx xxx xxxxxx xxxxxxxxx xx xxxx xxxxx xxxxxx xxx xx xxxxxxxxx xx x xxxxxx xxx xxxxxxx xxxxxx xxxxxxxxx xxxxxx. xxxxx xxx.xxxxx.xxx\/xxxxxxxxxx xxx xxxx xxxxxxxxxxx xxxxx xxxxx xxx xxx xxx xxxxxxxxxxxx.     ","isEdited":false}],"originalMessage":{"html":"     <div class=\"WordSection1\"> <p class=\"MsoNormal\">Hi SomeName, <\/p><p><\/p> <p class=\"MsoNormal\"><\/p><p>\u00a0<\/p> <p class=\"MsoNormal\">Will tomorrow at 34 est. work?<\/p><p><\/p> <p class=\"MsoNormal\"><\/p><p>\u00a0<\/p> <p class=\"MsoNormal\">Thanks,  Test<\/p><p><\/p> <p class=\"MsoNormal\"><\/p><p>\u00a0<\/p> <\/div>xxxxxx xxxxxxxx xx xxx: xxxx x-xxxx xxx xxxxxxxxxx xx xxxxxxxxxxxxx xx xxxxxxxxxxxx xxxxx x.x. xxx, xx xxx xxxxxxx xxxxxxx xx xx xxxxxxxxx xx xxxxxxx x xxxxxxxxxx xxxxxxx xx xxxxxxx. xxx xxx xxxxxx xxx xx xxxxxxx xxxxxxxxxxx xxx xxxxxxxxxxx xxxxxxxx xxxx xxxxx  xxx (xxxxxx xxx xxx xxxxx.xxx xxxxxxx, xxxxx xxxxxx x-xxxx xxxxxxxxxxx xxxxxxx x xxxxxxxx xxxxxxx) xx xxxx x-xxxx xxxxxxx xx xxxxxxxxxx xxxx xxxxxxx xx xxxxxxxxxxxxxxxx@xxxxx.xxx. xx xxx xx xx, xxx xxxxxx xx xxxx xxxxxxx xxxx xx xxxxxxxx xxxxxxxx. xxx xxxxxxxxx  xxxxxx xxxxxxx xx 225 x xxxxxx xxxxx, xxxxx 2600, xxxxxxx, xx 60602-4903.  xxxx xxxxx xxxxxxx xx xxxx xxxxx xxx xx xxx xx xxx xxxxxxxxxxxx xxx xxx xxxxxxx xxxxxxxxxx xx xxxxxxxxxxxx xxxxxxxxxxx  xx xxxxx xxxxxxxxxxx xxxxxx xxxx xxxxxxxxxx xxxxx xxxxxxxxxx xxx. xx xxx xxx xxx xxx xxxxxxxx xxxxxxxxx, xxxxxx xxxxxx xxx xxxxxx xx xxxxx xxxxx xxxxxxxxxxx xxx xxxxxx xxxx xxxxxxx xxxxxxx xxxxxxx xxxxxxx xx xxxxxxxxxx xx xxxxxx. xxxx xxxxx xx xxx xxxxxxxx  xx xx x xxxxxxxx xx xxxxx xxxxxxx xxxxxxx xxxxxxxxxx, xxx xxx xxx xxxxxx xxxxxxxxx xx xxxx xxxxx xxxxxx xxx xx xxxxxxxxx xx x xxxxxx xxx xxxxxxx xxxxxx xxxxxxxxx xxxxxx. xxxxx xxx.xxxxx.xxx\/xxxxxxxxxx xxx xxxx xxxxxxxxxxx xxxxx xxxxx xxx xxx xxx xxxxxxxxxxxx.     "},"avatar":"https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/avatar_2.png","created":"May 28 2022 9:10am PDT","timestamp":1653754210,"automatic":false,"sequenceNumber":3,"actionName":"ADDCOMMENT","shouldShow":true,"clientID":"","reportActionID":"63777"},{"person":[{"type":"TEXT","style":"strong","text":"aldo+test-spacing1@expensifail.com"}],"actorEmail":"aldo+test-spacing1@expensifail.com","actorAccountID":11030556,"message":[{"type":"COMMENT","html":"0 spaces<br \/> 1 spaces<br \/>  2 spaces<br \/>   3 spaces<br \/>    4 spaces<br \/> <pre>Test<\/pre>","text":"0 spaces  1 spaces   2 spaces    3 spaces     4 spaces  Test","isEdited":false}],"originalMessage":{"clientID":"1654303872951187","html":"0 spaces<br \/> 1 spaces<br \/>  2 spaces<br \/>   3 spaces<br \/>    4 spaces<br \/> <pre>Test<\/pre>"},"avatar":"https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/avatar_2.png","created":"Jun 3 2022 5:51pm PDT","timestamp":1654303873,"automatic":false,"sequenceNumber":2,"actionName":"ADDCOMMENT","shouldShow":true,"clientID":"1654303872951187","reportActionID":"63776"},{"person":[{"type":"TEXT","style":"strong","text":"aldo+test-spacing1@expensifail.com"}],"actorEmail":"aldo+test-spacing1@expensifail.com","actorAccountID":11030556,"message":[{"type":"COMMENT","html":"0 spaces<br \/> 1 spaces<br \/>  2 spaces<br \/>   3 spaces<br \/>    4 spaces","text":"0 spaces  1 spaces   2 spaces    3 spaces     4 spaces","isEdited":false}],"originalMessage":{"clientID":"1654303847866358","html":"0 spaces<br \/> 1 spaces<br \/>  2 spaces<br \/>   3 spaces<br \/>    4 spaces"},"avatar":"https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/avatar_2.png","created":"Jun 3 2022 5:50pm PDT","timestamp":1654303855,"automatic":false,"sequenceNumber":1,"actionName":"ADDCOMMENT","shouldShow":true,"clientID":"1654303847866358","reportActionID":"63775"},{"actionName":"CREATED","created":"Jun 3 2022 5:39pm PDT","timestamp":1654303194,"avatar":"https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/avatar_3.png","message":[{"type":"TEXT","style":"strong","text":"__FAKE__"},{"type":"TEXT","style":"normal","text":" created this report"}],"person":[{"type":"TEXT","style":"strong","text":"__FAKE__"}],"automatic":false,"sequenceNumber":0,"shouldShow":true}];

You should have the exact same messages I have.

Without the changes from this PR you should see:

With the change (remove whitespace:pre) from this PR you will see:

parasharrajat · 2022-06-07T18:45:12Z

Sorry, I wasn't able to look into this on the weekend but I will follow up tomorrow. For now, I see that there is a issue with whitespace:pre as you mentioned. But I am shocked to see that whitespaces are preserved without it. Will debug this and let you know.

parasharrajat · 2022-06-08T18:18:57Z

Looking at the code, I can say that removing whitespace:pre is not completely safe. It will not preserve whitespaces in HTML. Your explanation is correct #8088 (comment).

What if we convert the   to normal whitespace on client side? But again, where will we parse the message. It is directly comming from backend. So atlast, I would say best option would be prepare the message on backend.

When a user replies via email, parse the message and do the necessary conversion before saving.

aldo-expensify · 2022-06-08T18:23:49Z

That is exactly an option I was considering, I'll test it today later

…

On Wed, Jun 8, 2022, 11:19 Rajat Parashar ***@***.***> wrote: Looking at the code, I can say that removing whitespace:pre is not completely safe. It will not preserve whitespaces in HTML. Your explanation is correct #8088 (comment) <#8088 (comment)>. What if we convert the   to normal whitespace. — Reply to this email directly, view it on GitHub <#9195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU2LVBU5RKQF3Q2TCPRWWHDVODPZZANCNFSM5XCRBU7Q> . You are receiving this because you were assigned.Message ID: ***@***.***>

aldo-expensify · 2022-06-08T18:55:00Z

I gave it a try to converting the   to normal spaces, but it looks the same. We still have empty divs taking space.

For the purpose of testing it quicker, I did it in the front here (ReportActionItemFragment):

I also tested adding enableExperimentalBRCollapsing and enableExperimentalGhostLinesPrevention to TRenderEngineProvider, but didn't help.

parasharrajat · 2022-06-08T19:18:00Z

Got it. Then backend would be the only viable option.

aldo-expensify · 2022-06-08T19:21:28Z

Got it. Then backend would be the only viable option.

Not necessarily. I'm somewhat confident in that email replies will very often contain &nbsp. We could check if they contain that, and if they do don't force the white-space: pre;

And by "backend would be the only viable option", what kind of processing would you suggest? because now we know that just replacing the   by ' ' won't work

parasharrajat · 2022-06-08T19:24:07Z

because now we know that just replacing the by ' ' won't work

Yeah, it would be too much work. Normally Markup of emails is complex.

We could check if they contain that, and if they do don't force the white-space: pre;

Sounds like it will work. Remove the styles from baseFont and apply it to the wrapper.

A comment flag with source = 'email' should be displayed with whitespace: 'normal';

This happens when you type a new message and the message getting rendered is the optimistic data

aldo-expensify · 2022-06-10T23:15:45Z

src/libs/SelectionScraper/index.js

@@ -103,7 +103,7 @@ const replaceNodes = (dom) => {
        }

        // Adding a new line after each comment here, because adding after each range is not working for chrome.
-        if (dom.attribs[tagAttribute] === 'comment') {
+        if (dom.attribs[tagAttribute] === 'comment' || dom.attribs[tagAttribute] === 'email-comment') {


Maybe we should have a function like

function isCommentTag(nodeTag) { return nodeTag === 'email-comment' || nodeTag === 'comment'; }

aldo-expensify · 2022-06-20T22:29:53Z

cc @tgolen since you participated in this convo and in case you want to have a look

Julesssss · 2022-06-21T09:44:56Z

I'll try and remember to check this, but please remind me if I forget to review this once the other PR is merged.

aldo-expensify · 2022-06-24T17:52:56Z

cc @roryabraham can you have a look a this too? since it is related to https://github.com/Expensify/Web-Expensify/pull/33993 😬

src/pages/home/report/ReportActionItemFragment.js

Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>

aldo-expensify · 2022-06-28T21:48:15Z

Update: DRYer code

src/pages/home/report/ReportActionItemFragment.js

aldo-expensify · 2022-06-28T23:47:17Z

I'll try and remember to check this, but please remind me if I forget to review this once the other PR is merged.

@Julesssss I merged the other PR, just letting you know in case you want to review this

Julesssss

Nice fix, looking good 👍

aldo-expensify · 2022-07-06T18:21:31Z

Removed hold for https://github.com/Expensify/Web-Expensify/pull/33993 (it has been deployed to production).. fixing conflicts now.

…ines

aldo-expensify · 2022-07-06T22:02:29Z

Update: had to resolve conflicts

aldo-expensify · 2022-07-14T20:14:03Z

Bump, had to resolve conflicts, need an approval again to get this merged :)

src/pages/home/report/ReportActionItemFragment.js

Julesssss

👍

OSBotify · 2022-07-15T08:23:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-07-25T17:21:59Z

🚀 Deployed to production by @luacmartins in version: 1.1.85-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove whitespace: pre because extra empty lines bug

eac55be

aldo-expensify self-assigned this May 26, 2022

Merge branch 'aldo_fix-empty-lines' of github.com:Expensify/App into …

5f1457f

…aldo_fix-empty-lines

aldo-expensify mentioned this pull request Jun 4, 2022

Formatting of email responses in NewDot isn't pretty #8088

Closed

WIP Use flag for comments coming from email reply

c7e2d84

A comment flag with source = 'email' should be displayed with whitespace: 'normal';

aldo-expensify force-pushed the aldo_fix-empty-lines branch from 3a62b03 to c7e2d84 Compare June 9, 2022 20:31

aldo-expensify added 4 commits June 10, 2022 13:28

Remove comment and bg color for debugging

db4ae6b

Avoid crash if action.originalMessage is missing

0b9a43f

This happens when you type a new message and the message getting rendered is the optimistic data

Merge with main, resolve conflicts

6712ca6

Apply same logic for email-comment and comment

66d1e79

aldo-expensify commented Jun 10, 2022

View reviewed changes

aldo-expensify changed the title ~~Remove whitespace: pre because of extra empty lines bug~~ [HOLD] Remove whitespace: pre because of extra empty lines bug Jun 10, 2022

aldo-expensify changed the title ~~[HOLD] Remove whitespace: pre because of extra empty lines bug~~ [HOLD https://github.com/Expensify/Web-Expensify/pull/33993] Remove whitespace: pre because of extra empty lines bug Jun 10, 2022

aldo-expensify marked this pull request as ready for review June 20, 2022 22:29

aldo-expensify requested a review from a team as a code owner June 20, 2022 22:29

melvin-bot bot requested review from Julesssss and removed request for a team June 20, 2022 22:34

roryabraham reviewed Jun 24, 2022

View reviewed changes

src/pages/home/report/ReportActionItemFragment.js Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionItemFragment.js Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionItemFragment.js Outdated Show resolved Hide resolved

aldo-expensify and others added 2 commits June 28, 2022 14:21

Update comment

a732f4b

Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>

DRY code

de3301c

roryabraham previously approved these changes Jun 28, 2022

View reviewed changes

src/pages/home/report/ReportActionItemFragment.js Show resolved Hide resolved

Julesssss previously approved these changes Jun 29, 2022

View reviewed changes

aldo-expensify changed the title ~~[HOLD https://github.com/Expensify/Web-Expensify/pull/33993] Remove whitespace: pre because of extra empty lines bug~~ Remove whitespace: pre because of extra empty lines bug Jul 6, 2022

Merge branch 'main' of github.com:Expensify/App into aldo_fix-empty-l…

65fe23e

…ines

aldo-expensify dismissed stale reviews from Julesssss and roryabraham via 65fe23e July 6, 2022 22:01

roryabraham requested changes Jul 14, 2022

View reviewed changes

src/pages/home/report/ReportActionItemFragment.js Show resolved Hide resolved

roryabraham approved these changes Jul 15, 2022

View reviewed changes

Julesssss approved these changes Jul 15, 2022

View reviewed changes

Julesssss merged commit fc352dd into main Jul 15, 2022

Julesssss deleted the aldo_fix-empty-lines branch July 15, 2022 08:18

OSBotify mentioned this pull request Jul 18, 2022

Deploy Checklist: New Expensify 2022-07-18 #9970

Closed

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove whitespace: pre because of extra empty lines bug #9195

Remove whitespace: pre because of extra empty lines bug #9195

aldo-expensify commented May 26, 2022 •

edited

Loading

aldo-expensify commented May 26, 2022

aldo-expensify commented May 26, 2022 •

edited

Loading

parasharrajat commented Jun 3, 2022

aldo-expensify commented Jun 4, 2022

parasharrajat commented Jun 7, 2022 •

edited

Loading

parasharrajat commented Jun 8, 2022 •

edited

Loading

aldo-expensify commented Jun 8, 2022 via email

aldo-expensify commented Jun 8, 2022

parasharrajat commented Jun 8, 2022

aldo-expensify commented Jun 8, 2022

parasharrajat commented Jun 8, 2022

aldo-expensify Jun 10, 2022

aldo-expensify commented Jun 20, 2022

Julesssss commented Jun 21, 2022

aldo-expensify commented Jun 24, 2022

aldo-expensify commented Jun 28, 2022

aldo-expensify commented Jun 28, 2022

Julesssss left a comment

aldo-expensify commented Jul 6, 2022

aldo-expensify commented Jul 6, 2022

aldo-expensify commented Jul 14, 2022

Julesssss left a comment

OSBotify commented Jul 15, 2022

OSBotify commented Jul 25, 2022

Remove whitespace: pre because of extra empty lines bug #9195

Remove whitespace: pre because of extra empty lines bug #9195

Conversation

aldo-expensify commented May 26, 2022 • edited Loading

Details

Fixed Issues

Tests

QA (Production)

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web

Desktop

iOS

Android

aldo-expensify commented May 26, 2022

aldo-expensify commented May 26, 2022 • edited Loading

parasharrajat commented Jun 3, 2022

aldo-expensify commented Jun 4, 2022

parasharrajat commented Jun 7, 2022 • edited Loading

parasharrajat commented Jun 8, 2022 • edited Loading

aldo-expensify commented Jun 8, 2022 via email

aldo-expensify commented Jun 8, 2022

parasharrajat commented Jun 8, 2022

aldo-expensify commented Jun 8, 2022

parasharrajat commented Jun 8, 2022

aldo-expensify Jun 10, 2022

Choose a reason for hiding this comment

aldo-expensify commented Jun 20, 2022

Julesssss commented Jun 21, 2022

aldo-expensify commented Jun 24, 2022

aldo-expensify commented Jun 28, 2022

aldo-expensify commented Jun 28, 2022

Julesssss left a comment

Choose a reason for hiding this comment

aldo-expensify commented Jul 6, 2022

aldo-expensify commented Jul 6, 2022

aldo-expensify commented Jul 14, 2022

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 15, 2022

OSBotify commented Jul 25, 2022

aldo-expensify commented May 26, 2022 •

edited

Loading

aldo-expensify commented May 26, 2022 •

edited

Loading

parasharrajat commented Jun 7, 2022 •

edited

Loading

parasharrajat commented Jun 8, 2022 •

edited

Loading