Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploys sometimes fail silently when automerge-action times out #6789

Closed
roryabraham opened this issue Dec 15, 2021 · 6 comments
Closed

Deploys sometimes fail silently when automerge-action times out #6789

roryabraham opened this issue Dec 15, 2021 · 6 comments
Assignees
Labels
Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

Related issue: pascalgn/automerge-action#122

Problem

In workflow runs such as this one, a production deploy silently failed to run because the https://github.com/pascalgn/automerge-action silently failed.

Why this is important

We need to be notified when this action fails so we can be made aware of the failed deploy and address it if necessary.

Solution

Fix the issue in the linked repo, then update this repo to use the patched version.

@roryabraham roryabraham added Weekly KSv2 Improvement Item broken or needs improvement. labels Dec 15, 2021
@roryabraham roryabraham self-assigned this Dec 15, 2021
@roryabraham
Copy link
Contributor Author

We later discovered that the automerge action was likely failing because we had enabled a GitHub setting which requires all commits to be signed, but we did not have all unsigned commits from OSBotify merged into production before enabling that setting. So we disabled the setting, merged that PR, and should be able to re-enable the setting without issues now.

@roryabraham
Copy link
Contributor Author

I submitted a pull request to make the action fail loudly. Should we point our repo at the fork in the meantime?

@roryabraham
Copy link
Contributor Author

No movement on the PR. We could still test with our fork. This is no longer critical because we figured out the root cause. Going to switch this to monthly.

@MelvinBot MelvinBot removed the Overdue label Dec 29, 2021
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Dec 29, 2021
@roryabraham
Copy link
Contributor Author

Saw a tiny bit of movement on the pull request 3 days ago, I'm very hopeful that it will be merged soon.

@roryabraham
Copy link
Contributor Author

This keeps biting us, I'm going to put up a PR to test my fork.

@roryabraham
Copy link
Contributor Author

Got a PR up with an alternate solution – just ditch the community action and use the GH CLI!

@roryabraham roryabraham added the Reviewing Has a PR in review label Mar 10, 2022
@botify botify closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants