-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GH CLI instead of community actions #8063
Conversation
|
Tagging in @deetergp since he's pretty familiar with GitHub Actions stuff at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only used the gh
CLI tool for checkout PRs on our contributors' forked repos, I didn't realize it was this powerful. Very nic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I'll DEFINITELY defer to @deetergp and @AndrewGable as I'm not very familiar with this at all.
@AndrewGable Updated and ready for re-review. |
Use GH CLI instead of community actions (cherry picked from commit 3af29ff)
…8063 🍒 Cherry pick PR #8063 to staging 🍒
Nice, seems this worked like a charm ☘️ |
🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.44-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Details
This should solve the linked issue by removing the use of the pascalgn/automerge-action community action. The GH CLI will exit with a non-zero status code if something doesn't happen as expected.
I also removed other similarly unnecessary community actions both for consistency and because of what @rafecolton said here
We could continue making similar changes throughout our GH Actions code (and I think it would be a good idea to do that incrementally), but I thought this was a sufficient for now because it can be tested pretty easily.
Fixed Issues
$ #6789
Tests
I did a fair amount of local testing using the GH CLI and https://github.com/Andrew-Test-Org/Public-Test-Repo to validate these changes. I also validated that you can set a workflow-level environment variable, override it in just one step, and that doesn't affect other steps (they still get the workflow-level environment variable.
PR Review Checklist
Contributor (PR Author) Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)Styling.md
) for all style edits I madeSTYLE.md
)Avatar
, I verified the components usingAvatar
are working as expected)main
branch)PR Reviewer Checklist
main
### Fixed Issues
section abovesrc/languages/*
files (if applicable)STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)main
branch)QA Steps
Merge this PR with the CP staging label. That will test both the
updatedProtectedBranch
workflow and thecherryPick
workflow.