Deploy Checklist: New Expensify 2022-03-17

[OSBotify]

Release Version: 1.1.44-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Use GH CLI instead of community actions #8063

  • QA
  • Accessibility

• [NoQA] Fix the new contributor PR comment #8082

  • QA
  • Accessibility

• remove character counter #8145

  • QA
  • Accessibility

• [No QA] Remove dead code associated with AuthenticateWithAccountID #8149

  • QA
  • Accessibility

• Style and remove "Save" button for Default Room Settings #8164

  • QA
  • Accessibility

• disable future dates for DOB date picker #8176

  • QA
  • Accessibility

• [No QA] update PR checklist #8184

  • QA
  • Accessibility

• [CP Stg] Fix autoComplete crash #8186

  • QA
  • Accessibility

• update Avatars #8187

  • QA
  • Accessibility

• Add text styles #8190

  • QA
  • Accessibility

• Revert "[NoQA] Fix the new contributor PR comment" #8191

  • QA
  • Accessibility

• [No QA] Remove unnecessary checks for InlineErrorText #8194

  • QA
  • Accessibility

• Exit to the proper page when transitioning #8204

  • QA
  • Accessibility

• [No QA] Fix deploy announce in slack #8211

  • QA
  • Accessibility

• Sign in, out, or navigate on transition mount #8257

  • QA
  • Accessibility

Deploy Blockers:

• mWeb - Future dates for DOB date picker are not disabled in personal info page #8215

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.44-0 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.44-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.44-1 has been deployed to staging 🎉

[roryabraham]

Checked off #8063 since it passed QA 👍

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.44-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.44-2 has been deployed to staging 🎉

[roryabraham]

Maybe a regression in our checklist logic: #8186 was deployed in the last cycle, should not have been included in this checklist.

[marcaaron]

Just tested #8204 on staging and verified it fixes the issue reported here https://github.com/Expensify/Expensify/issues/201705

[roryabraham]

Checking off #8215 as it was closed by @neil-marcellini

[mvtglobally]

Regression is complete
#8176 is not fixed in mWeb, but it seems Safari limitation. Checking off #8215
Issues
#8212
#8220

Validating last PR and will update shortly

[neil-marcellini]

#8204 is not working on staging currently.

[mvtglobally]

#8204 (comment)

[mvtglobally]

@AndrewGable Anything we can do to help and move this checklist forward.. #8204 is the only pending item. Does it block checklist?

[AndrewGable]

Latest updates are here: https://github.com/Expensify/Expensify/issues/201705

Yes, I believe it needs to pass, @neil-marcellini is working on a fix.

[neil-marcellini]

Update: I have a draft PR up as a potential fix. I'm going through the process of testing out all the flows, so that part is a little bit time consuming.

[neil-marcellini]

My PR for #8204 is ready for review.

[mvtglobally]

@AndrewGable let's see if we can push this checklist today. QA is on standby for any validations needed

[roryabraham]

I'm actively working on the OldDot -> NewDot transition. @mvtglobally It would be very helpful if you could link me to all the existing regression tests we have to cover this flow.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.44-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.44-4 has been deployed to staging 🎉

[marcaaron]

Heads up we CP'd a couple of PRs to fix the NewDot Transition. Would be good if we can get some of those flows re-tested on staging web. I tested and they seem to be working well.

The only thing that does not seem to work well is transitioning from OldDot while logged in to NewDot with a different account. While testing this flow I kept getting logged out shortly after the transition happens. That particular flow isn't really a mainline flow though it should be working. The flow works on dev for me so I have a hunch it will get sorted with the next release. But I do not see an obvious reason why it should fail.

[mvtglobally]

@AndrewGable #8257 is pass aside of this issue. Its repro in PROD so not sure if its a blocker #8295

[AndrewGable]

If it's already in production then no it is not a deploy blocker, thank you, I will deploy shortly!

[AndrewGable]

[OSBotify]

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[AndrewGable]

[mountiny]

Just noticed that none of the PRs in this deployed got a Production deploy message from Botify, which also meant that the contributor issues were not labelled as waiting for payment. Has this been investigated? 👀 cc @AndrewGable

For example this.

[AndrewGable]

I have not investigated this no, I am not sure if this is related to the new bot or GitHub outages or what

[mountiny]

Thanks for confirming! I have went through all the contributor PRs and updated them accordingly so they are paid out on time 👍

Also, I checked and it seems that this was being deployed at the time of the Github outage last week. The list was closed at 16:41 GMT:

And Github status page says that that time they had problems

Let's assume it was this case since all seems to work in the next deploys :) Thanks!

[Stutikuls]

Checked all PRs and created accessibility issues for all PRs where accessibility issue were found.
The non-applicable PRs are - #8063, #8082, #8149, #8184, #8186, #8191, #8204 ,#8211, #8257
logged Issues - #8387 , #8388 , #8389, #8383, #8384, #8385, #8382