Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[NoQA] Fix the new contributor PR comment" #8191

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Revert "[NoQA] Fix the new contributor PR comment" #8191

merged 1 commit into from
Mar 16, 2022

Conversation

roryabraham
Copy link
Contributor

Reverts #8082

@roryabraham roryabraham self-assigned this Mar 16, 2022
@roryabraham roryabraham requested a review from a team as a code owner March 16, 2022 21:37
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team March 16, 2022 21:37
@roryabraham
Copy link
Contributor Author

cc @mountiny

@roryabraham
Copy link
Contributor Author

Broken workflow run: https://github.com/Expensify/App/actions/runs/1995172499

chiragsalian
chiragsalian approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit a6c2cf6 into main Mar 16, 2022
@chiragsalian chiragsalian deleted the revert-8082-vit-fixIsExpensifyEmployee branch March 16, 2022 21:42
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 17, 2022
Closed
31 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.44-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

@MariaHCD MariaHCD Awaiting requested review from MariaHCD

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @chiragsalian