[No QA] Fix deploy announce in slack #8211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
requested changes
Mar 17, 2022
roryabraham
reviewed
Mar 17, 2022
roryabraham
approved these changes
Mar 17, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Monitor here to see if this worked |
|
Didn't seem to work https://expensify.slack.com/archives/C07J32337/p1647557985727479 😭 |
|
Actually it looks like the workflow run I pointed you towards didn't pick up these changes. We'll just need to wait for another deploy then. I can manually CP this to test if you want? |
|
Manually CP'ing this to test it. |
OSBotify
pushed a commit
that referenced
this pull request
Mar 17, 2022
(cherry picked from commit 6a3442c)
OSBotify
added a commit
that referenced
this pull request
Mar 17, 2022
…ng-8211 🍒 Cherry pick PR #8211 to staging 🍒
|
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.44-3 🚀
|
This was referenced Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
cc @roryabraham @AndrewGable
Fixed Issues
$ #8199
Tests
The Slack announcement includes the correct deploy version
The success message is only posted once
If any platform fails to deploy, no success message is posted and we see a failure announcement instead.
Verify that no errors appear in the JS console