-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Stg] Fix autoComplete crash #8186
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[CP Stg] Fix autoComplete crash (cherry picked from commit ace1836)
🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.43-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.43-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀
|
Details
Fixes this crash (maybe only visible to mobile deployers)
Fixed Issues
$ #8177
Tests
Make sure Web-Expensify and Web-Secure are up-to-date
Make sure that your
.env
follows the example and has aSECURE_NGROK_URL
Run
ngrok.sh <your_name>
andngrok.sh <your_name> --secure
in separate tabsRun the Android app.
Sign into an account with a workspace, or create a new workspace if needed.
Go to
Settings -> <Your workspace> -> Connect Bank Account
Choose
Connect online with Plaid
Choose Wells Fargo
Enter
user_good
andpass_good
into the sandbox, then continue.Select an account and hit
Save and continue
No crash should occur.
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectionsrc/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
property(i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectionsrc/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
property(i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)QA Steps
Screenshots
Android
Screen.Recording.2022-03-16.at.2.06.57.PM.mov