Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Connect bank account - App is crashed after selecting Save & Continue button #8177

Closed
kbecciv opened this issue Mar 16, 2022 · 13 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the test app and log in with a applause.expensifail account (that does not have any bank account already added)
  2. Enable staging Web secure server in Account Preferences
  3. Navigate to Workspace editor page
  4. Select Connect bank account
  5. Select Connect online with Plaid
  6. Select Wells Fargo bank
  7. Enter the test credentials
  8. Choose the savings account "Plaid Saving11122XXXXXX111"
  9. Select Save & Continue button

Expected Result:

Able to add bank account successfully.

Actual Result:

App is crashed after selecting Save & Continue button. Unable to add a bank account.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.43.1

Reproducible in staging?: Yes

Reproducible in production?: No (unable to check VBA flow in Prod, last Regression didn't have issue)

Email or phone of affected tester (no customers): applausetester+ab2@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5493022_screen-20220316-125906.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 16, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thesahindia
Copy link
Member

Also reproducible on Add debit card page.

@bondydaa bondydaa removed their assignment Mar 16, 2022
@roryabraham roryabraham self-assigned this Mar 16, 2022
@roryabraham
Copy link
Contributor

Going to try to take a crack at this issue

@nickmurray47
Copy link
Contributor

@roryabraham let me know if you need any help digging, too, I'm familiar with how our Plaid flow is supposed to work

@roryabraham
Copy link
Contributor

Yeah @nickmurray47 more eyes would be great to get this resolved as fast as possible!

@nickmurray47
Copy link
Contributor

FYI I don't have a physical Android device, so not sure if it's possible for me to test Android staging myself?

@roryabraham
Copy link
Contributor

#7813 seems to be the most likely culprit. Going to try investigating that first

@roryabraham
Copy link
Contributor

FYI I don't have a physical Android device, so not sure if it's possible for me to test Android staging myself?

I don't either, going to see if we can reproduce on dev

@roryabraham
Copy link
Contributor

roryabraham commented Mar 16, 2022

You can make the dev app communicate with staging or production APIs too if you want, though I'm going to just use the VM to start.

@nickmurray47
Copy link
Contributor

nickmurray47 commented Mar 16, 2022

Let me know if you're able to reproduce @roryabraham.

Something to note looking at the tester's screencap is that they appear to be in Plaid's sandbox environment still? logs here

Wells Fargo is one of the bank connections that uses Plaid's upgraded sign-in route where we actually take you to the Wells Fargo site and then bring you back to Expensify. From the tester's video, it looks like they just went through the old sign-in route. If you try to use Wells Fargo through staging.new.expensify.com you can see what the flow is supposed to look like on prod.

@roryabraham
Copy link
Contributor

Saw this after PlaidLink was completed:

image

@roryabraham
Copy link
Contributor

Yep, as expected found the cause:

image

Going to have a fix up for CP momentarily. Crashlytics was very useful in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants