Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Desktop app is crashing #7642

Closed
mvtglobally opened this issue Feb 9, 2022 · 22 comments
Closed

[$1000] Desktop app is crashing #7642

mvtglobally opened this issue Feb 9, 2022 · 22 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. App has been opened for a while,
  2. Background app,
  3. Bring it up to foreground using cmd+space
  4. Type New..

Expected Result:

App to open

Actual Result:

App is crashed Uh-oh, something went wrong!

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: 1.1.37-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-02-08T233757 214
image - 2022-02-08T233753 229
image - 2022-02-08T233742 074
image - 2022-02-08T233739 540

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644343981504179

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcochavezf
Copy link
Contributor

I wasn't able to reproduce it, but according to the slack convo seems it's still happening. I'm going to mark it as External in case an external contributor is able to reproduce it, also I'm going to change it to Weekly because seems to be an edge-case and the user can re-open the app if it crashes.

@marcochavezf marcochavezf added Weekly KSv2 Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 Weekly KSv2 labels Feb 10, 2022
@MelvinBot
Copy link

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@marcochavezf marcochavezf removed their assignment Feb 10, 2022
@kadiealexander
Copy link
Contributor

I'm also not able to reproduce this! I've reached out here to see if anyone is still experiencing this.

@roryabraham
Copy link
Contributor

This looks to me like it might be a react-navigation issue. If it really is reproducible only on desktop but not web, it's possible that the new Electron architecture I implemented in this PR isn't playing nice with react-navigation (particularly linkingConfig/parsing URLs).

Disclaimer: The above comments are purely speculation. If we can't reproduce this I'd recommend we add it to weekly KI retests.

@kadiealexander
Copy link
Contributor

@roryabraham I haven't had any further reports of people able to reproduce this. How do I add it to the KI retests?

@MelvinBot MelvinBot removed the Overdue label Feb 16, 2022
@roryabraham
Copy link
Contributor

I think we can just ask @Expensify/applauseleads to add it to the KI retests

@MelvinBot
Copy link

@kadiealexander Huh... This is 4 days overdue. Who can take care of this?

@kadiealexander
Copy link
Contributor

@MelvinBot MelvinBot removed the Overdue label Feb 22, 2022
@mvtglobally
Copy link
Author

We are able to reproduce it, Just FYI

@kadiealexander
Copy link
Contributor

Thanks Maria!

@roryabraham should we go ahead and get this on Upwork since it's reproducible?

@roryabraham
Copy link
Contributor

Yeah, let's move it to upwork.

@botify botify removed the Daily KSv2 label Feb 23, 2022
@MelvinBot MelvinBot added the Weekly KSv2 label Feb 23, 2022
@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@MelvinBot MelvinBot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 23, 2022
@MelvinBot
Copy link

Triggered auto assignment to @AndrewGable (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mallenexpensify
Copy link
Contributor

Posted to Upwork since I was reviewing this. @kadiealexander , leaving you assigned as CM https://www.upwork.com/jobs/~011c3d7b7ee5f47ac1

@kadiealexander
Copy link
Contributor

Thanks Matt! I had it on the list but customers came first today so far!

@kadiealexander
Copy link
Contributor

kadiealexander commented Mar 3, 2022

Doubled the price!

@kadiealexander kadiealexander changed the title Desktop app is crashing [$500] Desktop app is crashing Mar 3, 2022
@kadiealexander kadiealexander changed the title [$500] Desktop app is crashing [$1000] Desktop app is crashing Mar 10, 2022
@kadiealexander
Copy link
Contributor

Doubled again 💰💰

@ctkochan22
Copy link
Contributor

ctkochan22 commented Mar 11, 2022

A similar issue with the same console error was fixed recently: #7907

Can we double check if this is still happening?

Also @mvtglobally, you mentioned that this is reproducible -- #7642 (comment) What are those reproduction steps? Are they ?

App has been opened for a while,
Background app,
Bring it up to foreground using cmd+space
Type New..

@kadiealexander
Copy link
Contributor

@mvtglobally could you please confirm if this issue is still reproducible? I haven't been able to reproduce it on my end.

@ctkochan22 ctkochan22 self-assigned this Mar 16, 2022
@MelvinBot MelvinBot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 16, 2022
@ctkochan22 ctkochan22 added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 16, 2022
@mvtglobally
Copy link
Author

Issue not reproducible during KI retests. (First week)

@ctkochan22
Copy link
Contributor

Cool I think this is fixed. Whoo! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants