-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Desktop app is crashing #7642
Comments
Triggered auto assignment to @marcochavezf ( |
I wasn't able to reproduce it, but according to the slack convo seems it's still happening. I'm going to mark it as |
Triggered auto assignment to @kadiealexander ( |
I'm also not able to reproduce this! I've reached out here to see if anyone is still experiencing this. |
This looks to me like it might be a react-navigation issue. If it really is reproducible only on desktop but not web, it's possible that the new Electron architecture I implemented in this PR isn't playing nice with react-navigation (particularly linkingConfig/parsing URLs). Disclaimer: The above comments are purely speculation. If we can't reproduce this I'd recommend we add it to weekly KI retests. |
@roryabraham I haven't had any further reports of people able to reproduce this. How do I add it to the KI retests? |
I think we can just ask @Expensify/applauseleads to add it to the KI retests |
@kadiealexander Huh... This is 4 days overdue. Who can take care of this? |
We are able to reproduce it, Just FYI |
Thanks Maria! @roryabraham should we go ahead and get this on Upwork since it's reproducible? |
Yeah, let's move it to upwork. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
Triggered auto assignment to @AndrewGable ( |
Posted to Upwork since I was reviewing this. @kadiealexander , leaving you assigned as CM https://www.upwork.com/jobs/~011c3d7b7ee5f47ac1 |
Thanks Matt! I had it on the list but customers came first today so far! |
Doubled the price! |
Doubled again 💰💰 |
A similar issue with the same console error was fixed recently: #7907 Can we double check if this is still happening? Also @mvtglobally, you mentioned that this is reproducible -- #7642 (comment) What are those reproduction steps? Are they ?
|
@mvtglobally could you please confirm if this issue is still reproducible? I haven't been able to reproduce it on my end. |
Issue not reproducible during KI retests. (First week) |
Cool I think this is fixed. Whoo! Closing |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App to open
Actual Result:
App is crashed Uh-oh, something went wrong!
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.37-0
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644343981504179
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: