[HOLD for payment 2022-06-16] [$1,000] mWeb - Split Money - First digit of split amount is cut off

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/[](javascript:)
2. Log in to account applausetester+0707abb@applause.expensifail.com/Feya87Katya
3. Tap on Fab menu
4. Tap Split Bill
5. Put amount and tap Continue
6. Select user [applausetester+1226abb@applause.expensifail.com]
7. Tap Split $ amount

Expected Result:

All the digits in the split amount is fully visible

Actual Result:

First digit of split amount is partially cut off

Workaround:

Visual

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.41.5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5485930_IMG_3748.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause (Exploratory)
Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[NicMendonca]

Upwork job: https://www.upwork.com/jobs/~01175a4deca6e9f963

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mnm967]

My proposal for fixing the issue as an external contributor from Upwork:

The error occurs on the text when you return/enter the page, however if you enter a key, the text returns to normal once again. By using setState to set the amount equal to itself in the componentDidMount, it should re-render the page before the user even sees it and fix the issue. Additionally, using setState in componentDidMount is not an anti-pattern according to React docs. See here: https://reactjs.org/docs/react-component.html#componentdidmount

[rushatgabhane]

Looks like it's a mWeb on safari iOS only problem.

@mnm967 hmm that didn't quite fix it

Screen.Recording.2022-03-16.at.3.50.27.AM.mov

[sbendary25]

Looks like it's a mWeb safari only problem

I managed to recreate the bug on iOS Chrome as well. Doesn't seem isolated to safari

[NicMendonca]

@sbendary25 are you keen to submit a proposal for this?

[pecanoro]

Not overdue, waiting for proposals.

[NicMendonca]

doubled price: https://www.upwork.com/jobs/~01175a4deca6e9f963

[pecanoro]

Not overdue, waiting for proposals.

[rushatgabhane]

@pecanoro Issue isn't reproducible as per #8158 (comment) , so we should do nothing, right?

[aneequeahmad]

@mvtglobally i can still reproduce this issue on staging and production for mWeb

cc: @rushatgabhane

[rushatgabhane]

@aneequeahmad you're right! issue is reproducible on production.
mWeb v1.1.57-17
iPhone 13 - iOS 15.4

[rushatgabhane]

@aneequeahmad Please raise a PR as soon as you can. Thanks!

Daily updates on weekdays are highly recommended. If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there. Any issue that doesn't receive an update for 1 full week may be considered abandoned and the original contract terminated https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#begin-coding-your-solution-in-a-pull-request

[aneequeahmad]

@rushatgabhane got it. Raising a PR ASAP. Thanks

[aneequeahmad]

@rushatgabhane PR is raised. Thanks

[rushatgabhane]

@aneequeahmad I think the PR is incorrectly linked. So it isn't shown over here.

[aneequeahmad]

@rushatgabhane Oh i've raised the PR here is the link #9102
Am i missing something so its not appearing here

[rushatgabhane]

Am i missing something so its not appearing here

Sorry, I can't help with that. I'd just create a new PR 😄

Make sure that you follow the instructions in the PR description -

It should look like this
$ https://github.com/Expensify/App/issues/<number-of-the-issue>

Do NOT only link the issue number like this: $ #<number-of-the-issue>

[rushatgabhane]

Anyway, we're waiting on @aneequeahmad to upload the screenshots.
But @aneequeahmad seems to have some trouble getting the app running.

[aneequeahmad]

@rushatgabhane Will upload screenshots today in a few hours i have another machine setup or VM.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• split digit cut off fix #9102

If no regressions arise, payment will be issued on 2022-06-16. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[NicMendonca]

@rushatgabhane @aneequeahmad paid - thanks!!