[$2000] Content off screen and keyboard opens when navigating to default rooms

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create workspace
2. Navigate to default room

Expected Result:

Navigating to a default room shows the chat content within the page

Actual Result:

Navigating to a default room shows the chat content half off screen and the keyboard opens
Issue is repro when no chats in the room

Workaround:

unknown

Platform:

Where is this issue occurring?

• Mobile Web - Safari

Version Number: 1.1.44-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1647980292349759

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Beamanator]

Looks like a good issue to be solved externally 👍

[adelekennedy]

Internal
External

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tgolen]

Still waiting for proposals

[adelekennedy]

time to DOUBLE!

[adelekennedy]

And it's time to double again

[adelekennedy]

It's time to double again!

[anboia]

Proposal

Remove the autoFocus, when the room has just been created (no action history)

Overview

What is causing this issue, is when you open a room, and there is no action on that report, except the "CREATED" actionName, this enables autoFocus

App/src/pages/home/report/ReportActionCompose.js

Line 507 in e7565c1

autoFocus={this.shouldFocusInputOnScreenFocus || _.size(this.props.reportActions) === 1}

as you can see in this line, the autoFocus is being tiggered by _.size(this.props.reportActions) === 1 condition.

Solution

Removes the _.size(this.props.reportActions) === 1 condition, this will open the report screen without autofocusing the text input, and the issue will be gone.

This will change the behavior of having the autofocus when you open a room without any previous action. but it will keep consistency with other rooms that have already an action history (list of messages).

@tgolen

[parasharrajat]

Looking at it now.

[mdneyazahmad]

@parasharrajat I have raised a PR upstream to add the drawer events feature. I just don't know what the maintainer thinks about those events. if those get accepted. I believe it will be easier to implement in the app. Thank you!

[parasharrajat]

I don't think they will be interested to look into this issue that you tagged on that PR.
Instead, try to create a new issue on RN that is not related to this app and link that instead.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tgolen]

Where do we stand with the proposal on this? I like the idea of getting those events put into the upstream code, but what does that mean for this issue in the meantime? Are we going to place it on hold, or move forward with DrawerProgress? I actually really like the look of DrawerProgress so I'd be cool with moving forward on that while we wait to see if we can get those events added upstream. If they ever get added upstream, then we can come back here and remove DrawerProgress eventually.

[parasharrajat]

Some time back, due to a lack of proper fix, we decided on slack to ignore the focus on the mobile web platforms. But then the issue received a new proposal claiming to achieve it as well.

I looked at a different issue where the same DrawerProgress based proposal was being discussed and so far the conclusion on that issue is suggesting to implement this kind of change upstream #9253 (comment). Meanwhile, @mdneyazahmad created a new PR that tries to implement the new drawer animation events on react-navigation. I am following that as well.

Latest update on the other issue: - #9253 (comment).

I will wait a few more days and see if we have to move forward with DrawerProgress implementation.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[parasharrajat]

latest update #9253 (comment)

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[parasharrajat]

the other issue is on now put on HOLD #9253 (comment).

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[tgolen]

I'm going to go ahead and close this

[dylanexpensify]

@adelekennedy just checking, did we get @parasharrajat paid out for this (context)

[parasharrajat]

@dylanexpensify Nope. https://www.upwork.com/jobs/Content-off-screen-and-keyboard-opens-when-navigating-default-rooms-8292-Expensify_~016d3e6e7bdef8f679