Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [$500] Keyboard doesn't appear for the "Room Name" field on web/safari #11762

Closed
kbecciv opened this issue Oct 12, 2022 · 19 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 12, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #11587

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login with expensifail account, for example applausetester+pd1005@applause.expensifail.com/ Password1
  3. Create a Workspace
  4. Tap "+"
  5. Tap "New Room"

Expected Result:

"Room name" field should be focused and I suppose keyboard should be already on the screen to start typing

Actual Result:

"Room name" filed is focused, but no keyboard on the screen to start typing room name. Additional tap is required to pop up keyboard.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • mWeb/safari

Version Number: 1.2.13.2

Reproducible in staging?: Yes

Reproducible in production?: n/a

Email or phone of affected tester (no customers): any expensifail accounts

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5773619_11587_mweb_ios.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2022
@danieldoglas
Copy link
Contributor

ok, this can be external

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2022
@danieldoglas danieldoglas added the External Added to denote the issue can be worked on by a contributor label Oct 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Triggered auto assignment to @miljakljajic (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Triggered auto assignment to @jasperhuangg (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title mWeb/safari - Keyboard is not popped up for "Room Name" field to start typing [$250] mWeb/safari - Keyboard is not popped up for "Room Name" field to start typing Oct 17, 2022
@danieldoglas danieldoglas removed their assignment Oct 17, 2022
@miljakljajic
Copy link
Contributor

Is there a slack discussion anywhere for this one?

@eVoloshchak
Copy link
Contributor

Is there a slack discussion anywhere for this one?

Couldn't find anything by searching on slack, there's probably none since it was found while testing another issue

@miljakljajic miljakljajic changed the title [$250] mWeb/safari - Keyboard is not popped up for "Room Name" field to start typing [$250] Keyboard is not appearing for the "Room Name" field on web/safari Oct 18, 2022
@miljakljajic miljakljajic changed the title [$250] Keyboard is not appearing for the "Room Name" field on web/safari [$250] Bug: Keyboard is not appearing for the "Room Name" field on web/safari Oct 18, 2022
@miljakljajic miljakljajic changed the title [$250] Bug: Keyboard is not appearing for the "Room Name" field on web/safari Bug: Keyboard doesn't appear for the "Room Name" field on web/safari Oct 18, 2022
@miljakljajic
Copy link
Contributor

Job posted to Upwork.

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@jasperhuangg
Copy link
Contributor

We're still waiting for proposals on this one, correct?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 21, 2022
@jasperhuangg jasperhuangg added the Weekly KSv2 label Oct 24, 2022
@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2022
@jasperhuangg jasperhuangg added Overdue and removed Daily KSv2 labels Oct 24, 2022
@jasperhuangg
Copy link
Contributor

Demoting to Weekly as we're still waiting for proposals on this one.

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2022
@miljakljajic
Copy link
Contributor

That's correct, thanks Jasper!

@miljakljajic
Copy link
Contributor

Doubled to $500.

@miljakljajic miljakljajic changed the title Bug: Keyboard doesn't appear for the "Room Name" field on web/safari Bug: [$500] Keyboard doesn't appear for the "Room Name" field on web/safari Oct 31, 2022
@StefanNemeth
Copy link
Contributor

StefanNemeth commented Oct 31, 2022

Safari on iOS is a bit more strict regarding the virtual keyboard than Chrome or other browsers on Android. The keyboard may only open when an input element is focused on a click event. So the solution would be to focus on the click event that occurs when clicking on the plus button (using autoFocus might also work here).

@eVoloshchak
Copy link
Contributor

So the solution would be to focus on the click event that occurs when clicking on the plus button (using autoFocus might also work here).

Thanks for the proposal, this hack would indeed work, but we generally try to avoid such workarounds unless necessary

@eVoloshchak
Copy link
Contributor

I think this might have the same reason as #8292 (comment), which ultimately came down to implementing custom events for the drawer, which would allow us to focus the keyboard after all of the drawer animations are finished.
This change was going to be implemented in #9253, but after that, it was decided to discuss if continuing to use a drawer navigator is a good idea.

Should this also be put on hold?