-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: [$500] Keyboard doesn't appear for the "Room Name" field on web/safari #11762
Comments
Triggered auto assignment to @danieldoglas ( |
ok, this can be external |
Triggered auto assignment to @miljakljajic ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
Triggered auto assignment to @jasperhuangg ( |
Is there a slack discussion anywhere for this one? |
Couldn't find anything by searching on slack, there's probably none since it was found while testing another issue |
We're still waiting for proposals on this one, correct? |
Demoting to |
That's correct, thanks Jasper! |
Doubled to $500. |
Safari on iOS is a bit more strict regarding the virtual keyboard than Chrome or other browsers on Android. The keyboard may only open when an input element is focused on a click event. So the solution would be to focus on the click event that occurs when clicking on the plus button (using autoFocus might also work here). |
Thanks for the proposal, this hack would indeed work, but we generally try to avoid such workarounds unless necessary |
I think this might have the same reason as #8292 (comment), which ultimately came down to implementing custom events for the drawer, which would allow us to focus the keyboard after all of the drawer animations are finished. Should this also be put on hold? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #11587
Action Performed:
Expected Result:
"Room name" field should be focused and I suppose keyboard should be already on the screen to start typing
Actual Result:
"Room name" filed is focused, but no keyboard on the screen to start typing room name. Additional tap is required to pop up keyboard.
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.13.2
Reproducible in staging?: Yes
Reproducible in production?: n/a
Email or phone of affected tester (no customers): any expensifail accounts
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5773619_11587_mweb_ios.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: