fix "Cursor disappear if we choose the same currency from the currency selector" #11794

aimane-chnaif · 2022-10-13T06:06:20Z

Details

We should focus input only when select currency modal closed and input screen is active again

Fixed Issues

$ #11095
PROPOSAL: #11095 (comment)

Tests

Click FAB -> Request/Send money or Go to any chat -> Request/Send money
Choose the currency which is already selected
Verify that cursor doesn't disappear

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Click FAB -> Request/Send money or Go to any chat -> Request/Send money
Choose the currency which is already selected
Verify that cursor doesn't disappear

Verify that no errors appear in the JS console

Screenshots

Web

web.mov

Mobile Web - Chrome

mchrome.mp4

Mobile Web - Safari

msafari.mov

NOTE: This doesn't work on mobile safari even if choose different currency from currency selector before this fix, so it's not a regression. We can handle mobile safari issue in separated GH.

Desktop

desktop.mov

iOS

ios.mov

Android

android.mp4

…y selector"

aimane-chnaif · 2022-10-13T09:09:25Z

If you prefer using withNavigationFocus, I can update accordingly, though it has same performance.

    componentDidMount() {
        this.focusTextInput();
-       this.unsubscribe = this.props.navigation.addListener('focus', () => {
-           this.focusTextInput();
-       });
    }

-   componentWillUnmount() {
-       this.unsubscribe();
-   }
+   componentDidUpdate(prevProps) {
+       if (this.props.isFocused && !prevProps.isFocused) {
+           this.focusTextInput();
+       };
+   }

export default compose(
    withLocalize,
    withOnyx({
        iou: {key: ONYXKEYS.IOU},
    }),
- )(IOUAmountPage);
+ )(withNavigationFocus(IOUAmountPage));

parasharrajat · 2022-10-16T00:42:52Z

src/pages/iou/steps/IOUAmountPage.js

+        this.unsubscribe = this.props.navigation.addListener('focus', () => {
+            this.focusTextInput();
+        });


Suggested change

this.unsubscribe = this.props.navigation.addListener('focus', () => {

this.focusTextInput();

});

this.unsubscribeNavFocus = this.props.navigation.addListener('focus', () => {

this.focusTextInput();

});

parasharrajat · 2022-10-16T00:43:26Z

src/pages/iou/steps/IOUAmountPage.js

@@ -69,14 +69,13 @@ class IOUAmountPage extends React.Component {

    componentDidMount() {
        this.focusTextInput();
+        this.unsubscribe = this.props.navigation.addListener('focus', () => {


Add a comment over it explaining why we need this.

aimane-chnaif · 2022-10-16T11:16:05Z

It seems github bug. I re-requested review from @parasharrajat but automatically removed request for @thienlnam

parasharrajat

LGTM.

cc: @thienlnam

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

screen-2022-10-16_19.42.44.mp4

🔲 Android / Chrome

screen-2022-10-16_20.02.48.mp4

🔲 Android / native

screen-2022-10-16_20.06.24.mp4

🎀 👀 🎀 C+ reviewed

src/pages/iou/steps/IOUAmountPage.js

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

thienlnam

Changes look good, thank you!

melvin-bot · 2022-10-16T22:11:07Z

@thienlnam looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

thienlnam · 2022-10-16T22:11:32Z

Tests passed

OSBotify · 2022-10-16T23:31:12Z

🚀 Deployed to staging by @thienlnam in version: 1.2.16-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2022-10-17T12:03:19Z

@aimane-chnaif
Do we need to create a new GH issue for mWeb/Safari base on your note below? Please let me know.
NOTE: This doesn't work on mobile safari even if choose different currency from currency selector before this fix, so it's not a regression. We can handle mobile safari issue in separated GH.

11794.mWeb.mp4

aimane-chnaif · 2022-10-17T12:25:03Z

I think mobile safari issue is similar to these issues:
#10414
#11762 (from #11507 (comment))
#11089
#11762

and the root cause might be the same

@parasharrajat @thienlnam what do you think?

@kbecciv Answer to your question:

Do we need to create a new GH issue for mWeb/Safari base on your note below? Please let me know.

yes I think so. And maybe we need to set a tracking GH of mobile safari keyboard not open issue and these kinds of issues belong to this.
Similar to these tracking issues: #10273 (keyboard), #11768 (navigation)

parasharrajat · 2022-10-17T13:16:28Z

@kbecciv So we don't have to create a new issue for now. There are many similar issues for the problem.
I agree to create a tracking issue for these. cc: @thienlnam

kbecciv · 2022-10-17T14:05:47Z

Sounds good! Thank you both for quick reply. @parasharrajat @aimane-chnaif

OSBotify · 2022-10-17T17:50:00Z

🚀 Deployed to production by @sketchydroide in version: 1.2.16-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix "Cursor disappear if we choose the same currency from the currenc…

83ab2e7

…y selector"

aimane-chnaif requested a review from a team as a code owner October 13, 2022 06:06

melvin-bot bot requested review from parasharrajat and thienlnam and removed request for a team October 13, 2022 06:06

parasharrajat suggested changes Oct 16, 2022

View reviewed changes

add comment for navigation listener on IOUAmountPage

83d6eff

aimane-chnaif requested review from parasharrajat and removed request for thienlnam October 16, 2022 11:15

parasharrajat previously approved these changes Oct 16, 2022

View reviewed changes

parasharrajat reviewed Oct 16, 2022

View reviewed changes

src/pages/iou/steps/IOUAmountPage.js Outdated Show resolved Hide resolved

aimane-chnaif dismissed parasharrajat’s stale review via 657bd5b October 16, 2022 21:05

Update comment

657bd5b

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

thienlnam approved these changes Oct 16, 2022

View reviewed changes

thienlnam merged commit 36666ba into Expensify:main Oct 16, 2022

melvin-bot bot added the Emergency label Oct 16, 2022

thienlnam removed the Emergency label Oct 16, 2022

OSBotify mentioned this pull request Oct 16, 2022

Deploy Checklist: New Expensify 2022-10-14 #11880

Closed

14 tasks

melvin-bot bot mentioned this pull request Oct 17, 2022

[HOLD for payment 2022-10-24] [$250] Cursor disappear if we choose the same currency from the currency selector - reported by @daraksha-dk #11095

Closed

parasharrajat mentioned this pull request Oct 20, 2022

[$250] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) #10414

Closed

This was referenced Nov 3, 2022

[$4000] iPad (safari) - Change password, new chat & new group page the field gets focused but the keyboard doesn't open - reported by @thesahindia #11089

Closed

Bug: [$500] Keyboard doesn't appear for the "Room Name" field on web/safari #11762

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix "Cursor disappear if we choose the same currency from the currency selector" #11794

fix "Cursor disappear if we choose the same currency from the currency selector" #11794

aimane-chnaif commented Oct 13, 2022

aimane-chnaif commented Oct 13, 2022

parasharrajat Oct 16, 2022

parasharrajat Oct 16, 2022

aimane-chnaif commented Oct 16, 2022

parasharrajat left a comment

thienlnam left a comment

melvin-bot bot commented Oct 16, 2022

thienlnam commented Oct 16, 2022

OSBotify commented Oct 16, 2022

kbecciv commented Oct 17, 2022

aimane-chnaif commented Oct 17, 2022 •

edited

Loading

parasharrajat commented Oct 17, 2022

kbecciv commented Oct 17, 2022 •

edited

Loading

OSBotify commented Oct 17, 2022

fix "Cursor disappear if we choose the same currency from the currency selector" #11794

fix "Cursor disappear if we choose the same currency from the currency selector" #11794

Conversation

aimane-chnaif commented Oct 13, 2022

Details

Fixed Issues

Tests

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

aimane-chnaif commented Oct 13, 2022

parasharrajat Oct 16, 2022

Choose a reason for hiding this comment

parasharrajat Oct 16, 2022

Choose a reason for hiding this comment

aimane-chnaif commented Oct 16, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

thienlnam left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 16, 2022

thienlnam commented Oct 16, 2022

OSBotify commented Oct 16, 2022

kbecciv commented Oct 17, 2022

aimane-chnaif commented Oct 17, 2022 • edited Loading

parasharrajat commented Oct 17, 2022

kbecciv commented Oct 17, 2022 • edited Loading

OSBotify commented Oct 17, 2022

aimane-chnaif commented Oct 17, 2022 •

edited

Loading

kbecciv commented Oct 17, 2022 •

edited

Loading