Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-10-14 #11880

Closed
14 tasks done
roryabraham opened this issue Oct 15, 2022 · 16 comments
Closed
14 tasks done

Deploy Checklist: New Expensify 2022-10-14 #11880

roryabraham opened this issue Oct 15, 2022 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 17, 2022
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.16-4 🚀

@mvtglobally
Copy link

mvtglobally commented Oct 17, 2022

Regression is completed

Checking off #11782 (comment)
PR #11857 is failing due to #11892. repro in PROD. There were few blockers with OldDot Concierge. Are we ok to check this off?
PR #11718 is failing due to #11883. Checking off
#11794 (comment)

@sketchydroide
Copy link
Contributor

#11884 is not a blocker, the issue was web side, there is a PR to fix it.

@sketchydroide
Copy link
Contributor

#11887 also not a deploy blocker.

@sketchydroide
Copy link
Contributor

@mvtglobally @kavimuru can we test again please 🙇🏼

Also I think we can check #11857 off

@mvtglobally
Copy link

@sketchydroide Are you asking us to run another regression?

@mvtglobally
Copy link

@sketchydroide
Both issues doesn't seem to be repro any more

split_fixed.mp4

Screen Shot 2022-10-17 at 10 39 54 AM

@sketchydroide
Copy link
Contributor

I think we can also check off #11794

@mvtglobally
Copy link

@sketchydroide We are checked off. All seem to be completed

@sketchydroide
Copy link
Contributor

#11527 - has been reverted, so we are checking it off

@OSBotify
Copy link
Contributor

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.16-5 🚀

@sketchydroide
Copy link
Contributor

#11909 checking it off as it's the revert to #11527 -

@sketchydroide
Copy link
Contributor

#11858 is not a bloker, there was some confusion whit it, but it's currently in prod.

@sketchydroide
Copy link
Contributor

:shipit:

@OSBotify
Copy link
Contributor

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.16-5 has been deployed to staging 🎉

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants