Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-03-30 #8378

Closed
47 tasks done
OSBotify opened this issue Mar 30, 2022 · 15 comments
Closed
47 tasks done

Deploy Checklist: New Expensify 2022-03-30 #8378

OSBotify opened this issue Mar 30, 2022 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 30, 2022

Release Version: 1.1.49-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

@MelvinBot
Copy link

📣 @OSBotify! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

@OSBotify OSBotify reopened this Mar 30, 2022
@OSBotify
Copy link
Contributor Author

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 30, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.49-0 🚀

@mvtglobally
Copy link

@timszot We did not get Android build. Team still sees 1.1.47-0. Can you please check if it is still pending with Google and re-push?

@timszot
Copy link
Contributor

timszot commented Mar 31, 2022

1.1.49-0 should be uploaded now!

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.49-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.49-1 has been deployed to staging 🎉

@mvtglobally
Copy link

Blockers
#8379

PR #7580 failing due to #8379
PR #8301 failing due to #8394. Its not a blocker, can we check off?
PR #8338 is failing on IOS due to #7869. Rest are pass. Are we good to check off?

Issues logged
#8420
#8396
#8404
#8380
#8381
#8420

Comments added
#8270 (comment)
Checking off #8315 (comment)

@roryabraham
Copy link
Contributor

PR #8301 failing due to #8394. Its not a blocker, can we check off?

Looks like it, going to check this off as NAB.

PR #8338 is failing on IOS due to #7869. Rest are pass. Are we good to check off?

Yep, all those other platforms passing is good enough for me!

@roryabraham
Copy link
Contributor

@mvtglobally Added a comment on #8328

@MelvinBot MelvinBot added the Monthly KSv2 label Apr 4, 2022
@roryabraham
Copy link
Contributor

Checking off #8270 because it's Production QA

@mvtglobally
Copy link

We are only left with #7580 failing due to Blocker #8379

@roryabraham
Copy link
Contributor

roryabraham commented Apr 5, 2022

I demoted #8379 from deploy blocker to regular bug, and determined that #7580 works, other than that known issue. Checking them both off, and going to proceed with the deploy.

@roryabraham
Copy link
Contributor

:shipit:

@Stutikuls
Copy link

Stutikuls commented Apr 13, 2022

Checked all PRs and created accessibility issues for all PRs where accessibility issue were found.
The non-applicable PRs are - #8137, #8221, #8270, #8306, #8310, #8312, #8314, #8322, #8328, #8343, #8365, #8412
logged Issues - #8605, #8385, #8555, #8614, #8387, #8615, #8385, #8614, #8617, #8619, #8480, #8620, #8553, #8479, #8621, #8623, #8479, #8624, #8428, #8554, #8625, #8428, #8554, #8625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants