Revert changes related to #7623

[marcaaron]

cc @luacmartins @thienlnam

Details

• Original PR here broke the error boundary and storybook https://github.com/Expensify/App/pull/8196/files
• Fix PR applied an unnecessary solution (IMO) and did not actually fix the error boundary https://github.com/Expensify/App/pull/8365/files

I'm CP'ing this to staging so we can fix the broken error boundary ASAP.

I don't know what we want to do about the original issue but having the error boundary work is 1000x more valuable than the issue and this has wasted valuable time.

Fixed Issues

Related to #7623

Tests

Apply this diff:

diff --git a/src/libs/Navigation/AppNavigator/AuthScreens.js b/src/libs/Navigation/AppNavigator/AuthScreens.js
index 944dcfa52..acb1752c9 100644
--- a/src/libs/Navigation/AppNavigator/AuthScreens.js
+++ b/src/libs/Navigation/AppNavigator/AuthScreens.js
@@ -127,6 +127,8 @@ class AuthScreens extends React.Component {
         BankAccounts.fetchFreePlanVerifiedBankAccount();
         BankAccounts.fetchUserWallet();

+        throw new Error('derp');
+
         // Load policies, maybe creating a new policy first.
         Linking.getInitialURL()
             .then((url) => {

Run app see that error boundary is triggered:

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[OSBotify]

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.49-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.49-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅