Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-06-08] [$1000] Support markdown in hyperlink #8426

Closed
mvtglobally opened this issue Apr 1, 2022 · 34 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

mvtglobally commented Apr 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to any chat
  2. Send few links with markdown - Strikethrough/bold/italic

Expected Result:

Markdown formatting should work on links

Actual Result:

Markdown formatting doesn't work on links

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-03-31T233251 688

A markdown - [~Hi~ **Hello** _Expensify_](expensify.com) is expected to render as

Screenshot 2022-04-08 at 12 21 12 PM

Expensify/Expensify Issue URL:
Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648572567876889

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 1, 2022

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@cead22
Copy link
Contributor

cead22 commented Apr 4, 2022

For context, it looks like this works the same on slack, so maybe this warrants a convo in #product
image

@MelvinBot
Copy link

@MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MonilBhavsar
Copy link
Contributor

Yes, Slack doesn't support this, but Github does.
I feel like we should do it. Can post in #product after your thoughts

@MelvinBot MelvinBot removed the Overdue label Apr 5, 2022
@cead22
Copy link
Contributor

cead22 commented Apr 5, 2022

Can post in #product after your thoughts

Go for it

@MonilBhavsar
Copy link
Contributor

Posted here in slack

@MonilBhavsar MonilBhavsar changed the title Strike trough formatting doesn't work on links Support markdown in hyperlink Apr 8, 2022
@MonilBhavsar
Copy link
Contributor

As per the discussion, we want to support all possible markdown in hyperlinks. Updated issue title and body.

@MonilBhavsar MonilBhavsar added the External Added to denote the issue can be worked on by a contributor label Apr 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@adelekennedy
Copy link

external
internal

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Support markdown in hyperlink [$250] Support markdown in hyperlink Apr 8, 2022
@melvin-bot melvin-bot bot added the Overdue label Apr 18, 2022
@NikkiWines
Copy link
Contributor

Yep, agreed - this looks good. @adelekennedy can you hire @mdneyazahmad for this job please?

@NikkiWines
Copy link
Contributor

@adelekennedy friendly bump here

@adelekennedy
Copy link

Ah jeez - somehow totally missed these bumps! @mdneyazahmad can you apply to the job here?

@mdneyazahmad
Copy link
Contributor

@adelekennedy applied

@adelekennedy
Copy link

@mdneyazahmad hired!

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2022
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 16, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2022

📣 @mdneyazahmad You have been assigned to this job by @adelekennedy!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@adelekennedy adelekennedy added Weekly KSv2 and removed Daily KSv2 labels May 16, 2022
@mdneyazahmad
Copy link
Contributor

@parasharrajat PR is ready for review Expensify/expensify-common#446 and #9022

@melvin-bot melvin-bot bot added the Overdue label May 26, 2022
@NikkiWines
Copy link
Contributor

Not overdue, second PR is in review

@melvin-bot melvin-bot bot removed the Overdue label May 26, 2022
@NikkiWines NikkiWines added the Reviewing Has a PR in review label May 30, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 1, 2022
@melvin-bot melvin-bot bot changed the title [$1000] Support markdown in hyperlink [HOLD for payment 2022-06-08] [$1000] Support markdown in hyperlink Jun 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.70-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-06-08. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 7, 2022
@adelekennedy
Copy link

Payday! I had to reopen the job here @mdneyazahmad do you mind applying there? I'll handle payment as soon as you do

@mdneyazahmad
Copy link
Contributor

@adelekennedy applied.

@adelekennedy
Copy link

paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants