-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-06-08] [$1000] Support markdown in hyperlink #8426
Comments
Triggered auto assignment to @MonilBhavsar ( |
@MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Yes, Slack doesn't support this, but Github does. |
Go for it |
Posted here in slack |
As per the discussion, we want to support all possible markdown in hyperlinks. Updated issue title and body. |
Triggered auto assignment to @adelekennedy ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Triggered auto assignment to @NikkiWines ( |
Yep, agreed - this looks good. @adelekennedy can you hire @mdneyazahmad for this job please? |
@adelekennedy friendly bump here |
Ah jeez - somehow totally missed these bumps! @mdneyazahmad can you apply to the job here? |
@adelekennedy applied |
@mdneyazahmad hired! |
📣 @mdneyazahmad You have been assigned to this job by @adelekennedy! |
@parasharrajat PR is ready for review Expensify/expensify-common#446 and #9022 |
Not overdue, second PR is in review |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.70-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-06-08. 🎊 |
Payday! I had to reopen the job here @mdneyazahmad do you mind applying there? I'll handle payment as soon as you do |
@adelekennedy applied. |
paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Markdown formatting should work on links
Actual Result:
Markdown formatting doesn't work on links
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
A markdown -
[~Hi~ **Hello** _Expensify_](expensify.com)
is expected to render asExpensify/Expensify Issue URL:
Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648572567876889
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: