-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add markdown format to link text #9022
Conversation
We can't merge this PR until changes are merged upstream. Change the PR title so that it depicts what are we fixing here. |
@parasharrajat agree we have to wait till the related PR is merged. |
@mdneyazahmad Please update this PR with latest code and change e-common to latest. |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on npm i
my package-lock.json was different from yours. Only one hash was different. Did you run npm i
with npm V6?
@parasharrajat I always get the larger diff. Could you tell me exact version of |
All good now. I updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @NikkiWines in version: 1.1.70-0 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.1.70-1 🚀
|
This PR introduced an edge case regression #16475 in which a link containing special characters (e.g., https://www.facebook.com/hashtag/__main/?__eep__=6) is not rendered correctly. As a result, we had to disable formatting when the text is a link. |
Details
This PR tries to add a feature to apply markdown formatting in the link text.
Fixed Issues
$ #8426
Tests
[~Hi~ *Hello* _Expensify_](http://expensify.com)
HiHello Expensify[~strikethrough~ *bold* _italic_](expensify.com)
strikethroughbold italic[~strikethrough~ *bold* _italic_ test.com](expensify.com)
strikethroughbold italic test.com[~strikethrough~ *bold* _italic_ https://test.com](https://expensify.com)
strikethroughbold italic https://test.com[https://www.text.com/_root_folder/1](https://www.text.com/_root_folder/1)
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
[~Hi~ *Hello* _Expensify_](http://expensify.com)
HiHello Expensify[~strikethrough~ *bold* _italic_](expensify.com)
strikethroughbold italic[~strikethrough~ *bold* _italic_ test.com](expensify.com)
strikethroughbold italic test.com[~strikethrough~ *bold* _italic_ https://test.com](https://expensify.com)
strikethroughbold italic https://test.com[https://www.text.com/_root_folder/1](https://www.text.com/_root_folder/1)
Screenshots
Web
Mobile Web
Desktop
iOS
Android