[HOLD for payment 2022-12-20] [$8000] iOS Safari - Blue text selection persists in the compose box even after message is sent @metehanozyurt

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

In iOS Settings, Go to General > Keyboard and enable autocorrection

1. Go to https://new.expensify.com on Safari iOS
2. Log in with any account and select any chat
3. Enter incorrectly spelled word in the compose box and let the autocorrection warn you with the blue text selection.
4. Send the message

Expected Result:

Compose box should be cleared and empty blue selection shouldn't persist.

Actual Result:

Blue text selection still exist.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web (safari)

Version Number: 1.1.92.0 (Matt A retested 8/26/22)

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): n/a

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

1.mp4

2.mp4

Expensify/Expensify Issue URL:

Issue reported by: @metehanozyurt

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648452635209129

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @cdraeger11 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

@cdraeger11 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@cdraeger11 Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@cdraeger11 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MonilBhavsar]

Can't seem to reproduce on Safari web, but can reproduce on iOS simulator

[MonilBhavsar]

Asked for confirmation on a PR which I think caused this.

[parasharrajat]

Looked at the issue. Tried a few things to see if those fix it but no luck. I will try more tomorrow.

[melvin-bot]

@MonilBhavsar Huh... This is 4 days overdue. Who can take care of this?

[MonilBhavsar]

Will get back to this

[MonilBhavsar]

@parasharrajat since this seems like a regression, do you want to give it a try to fix this?

[parasharrajat]

I would be happy to do that but I have been preoccupied with other stuff. I will try to debug this over the weekend and let you know by Monday.

[MonilBhavsar]

PR is on staging

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix blue highlight issue by disabling autoCorrect  #13231

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR: Keep focus on the Composer when send button is clicked #8091
• [@parasharrajat / @MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Keep focus on the Composer when send button is clicked #8091 (comment)
• [@parasharrajat / @MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1673618904167379
• [@arielgreen] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/256136

[mallenexpensify]

Hi all, this is a 🐯 of an issue (over 200 comments) and we need to suss out payments.

1. @parasharrajat are you able to help?
2. If so... have you been assigned since the beginning, looks like it? (asking cuz, if you've invested time all along, include reviewing the PR, I imagine your compensation rate would be higher.)
3. If yes to the above, and you've invested a considerable amount of time, is there any reason you wouldn't/shouldn't be due the original $8000 job price?
4. Here's where things might get tricky. We made this issue internal, @MonilBhavsar and @parasharrajat , did we use a substantial amount of code from any previously submitted proposals? If so, can you link to them, tag the contributor and guesstimate how much of their code you used? (in increments of 25%, 50% or ~100%).
5. Once we have details from Moving files and folders a little #4 we'll work on potential compensation amounts.

[parasharrajat]

did we use a substantial amount of code from any previously submitted proposals?

@mallenexpensify I am discussing that @MonilBhavsar and I will let you know.

If so... have you been assigned since the beginning, looks like it? (asking cuz, if you've invested time all along, including reviewing the PR, I imagine your compensation rate would be higher.)

I am happy to go with the existing process and thus no need to go higher than the eligible amount.

[mallenexpensify]

have you been assigned since the beginning, looks like it? (asking cuz, if you've invested time all along, including reviewing the PR, I imagine your compensation rate would be higher.)

@parasharrajat, what I meant here is, assuming we have the option for payments of $1000k (standard), 100%, 50% and 25% of the job amount. I'm suggesting that your pay would be in the higher bracket.

Let me know when you and @MonilBhavsar reach consensus on if any code was used. Thx

[parasharrajat]

@mallenexpensify I think proposal should be eligible for some compensation. Although, it was rejected initially because we wanted to solve the main issue instead of disabling the feature at that time, the ultimate changes that were done to close this issue match with the approach in that proposal.

So in good faith and as per our policy, I think we can pay 25% to @songlang1994 which was the first to propose it.

A lot of research and investigation was done on other proposals but none of them was implemented. We decided to take it internal for competing with internal priorities. Considering the urgency of WAQ, and very fewer users affected by the bug, we decided to disable the feature and close this issue.

[mallenexpensify]

Thanks @parasharrajat
Can I get one... last... final confirmation from @MonilBhavsar and @parasharrajat before I pay?

• @parasharrajat $8000 for proposals and PR review
• @songlang1994 $2000 for 25% compensation for code submitted that ended up being used.

Sound good?!?!?
Please apply and I'll get paid once we confirm
https://www.upwork.com/jobs/~019b27cbf20756346d

[mallenexpensify]

@MonilBhavsar ping for confirmation on the above when you're back. Thx

[MonilBhavsar]

This plan looks good to me 👍

[mallenexpensify]

Thanks @MonilBhavsar
@parasharrajat can you please accept the job and reply here once you have?
@songlang1994 please apply and confirm when you have.
https://www.upwork.com/jobs/~019b27cbf20756346d

[metehanozyurt]

@mallenexpensify May I have the reporting bonus for this one?

[arielgreen]

@metehanozyurt yes; can you please apply to the job?

[arielgreen]

@parasharrajat payment issued.

[metehanozyurt]

I applied, thank you @arielgreen .

[arielgreen]

Also sent offer to @songlang1994

[songlang1994]

Offer accepted. Thank you @arielgreen

[arielgreen]

Excellent, all parties have been paid.

[arielgreen]

@parasharrajat @MonilBhavsar can you please review the checklist?

[MonilBhavsar]

Done!

[arielgreen]

Thank you! Reviewing adding a regression test to this, then we'll be set to close it out.

[arielgreen]

Proposed test here.