-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Upgrade OnFido SDK to 8.0.0 #8652
Comments
Triggered auto assignment to @jboniface ( |
Triggered auto assignment to @marcaaron ( |
@marcaaron can you help confirm that this is eligible for |
Where does it need to be upgraded? Everywhere or only New Expensify? |
Agree this can be |
Triggered auto assignment to @MitchExpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
Triggered auto assignment to @marcochavezf ( |
I just searched for where we're using the package, and it looks like it's in Web-Secure in addition to App. So perhaps this should stay internal after all? |
cc @nkuoch or @chiragsalian for your input too, since you both were involved in the last SDK update for OnFido. Seems we still are uncertain about whether this is internal or external. |
Not overdue, waiting for proposals |
Should we be doubling price of this job @MitchExpensify ? |
Yes I will today @michaelhaxhiu |
Doubled! Upwork Job |
ProposalLooking at the change logs there doesn’t seem to be any breaking changes. So we can just update the packages and test for regressions. |
Proposalit is a straightforward change of the updating package, need to update to the latest version of onfido-sdk-ui, as at this time it is 8.0.0, and then need to test in web and desktop , that update the package is working fine or not |
Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
Current assignee @marcochavezf is eligible for the Exported assigner, not assigning anyone new. |
There is no C+ on this issue since Rushat un-assigned himself, so I'm triggering re-assignment. |
@jayeshmangwani is right, this is now 8.0.0. Updated the issue title and our internal tracker. |
This SDK seems to be updating pretty frequently, and consecutively each week... is this the norm? If so, I wonder if this is best handled internally after all? |
I agree. I think whoever does Web-Secure internally could do App at the same time - it's not much more work. |
Is this still external? or internal? @michaelhaxhiu |
@Santhosh-Sellavel I'm working on making this internal right now, based on the comments above. |
Sorry for the confusion on this GH @jayeshmangwani and @Regaron, we are closing this external job and will fix this internally instead. Thanks for your interest, feel free to browse other available jobs here |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
Please update the Onfido UI SDK and Onfido React Native SDK in E/App
Actual Result:
OnFido SDK isn't updated to the latest.
Workaround:
Platform:
Where is this issue occurring?
Version Number:
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/206694
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: