Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Upgrade OnFido SDK to 8.0.0 #8652

Closed
michaelhaxhiu opened this issue Apr 15, 2022 · 30 comments
Closed

[$500] Upgrade OnFido SDK to 8.0.0 #8652

michaelhaxhiu opened this issue Apr 15, 2022 · 30 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@michaelhaxhiu
Copy link
Contributor

michaelhaxhiu commented Apr 15, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Please update the Onfido UI SDK and Onfido React Native SDK in E/App

### Fixed in 6.20.1

- Public: Fix useLiveDocumentCapture onComplete not working (cross device capture `variant` missing)

Actual Result:

OnFido SDK isn't updated to the latest.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes.

Platform:

Where is this issue occurring?

  • Web

Version Number:
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/206694

View all open jobs on GitHub

@michaelhaxhiu michaelhaxhiu added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Apr 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 15, 2022

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 15, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@michaelhaxhiu
Copy link
Contributor Author

michaelhaxhiu commented Apr 15, 2022

@marcaaron can you help confirm that this is eligible for External? @amyevans mentioned that it's likely good for external but just wanted to double check as a part of the standard flow of creating a new GH in E/app (and bc the historic example of updating the SDK was done by internal engineers it seems?)

@melvin-bot melvin-bot bot added the Overdue label Apr 18, 2022
@marcaaron
Copy link
Contributor

OnFido needs to be updated to the newest version of the SDK (6.20.0)

Where does it need to be upgraded? Everywhere or only New Expensify?

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2022
@marcaaron
Copy link
Contributor

Agree this can be External as it's just updating a library. But the flow needs to be tested still so maybe we can make sure QA is done correctly and there are no regressions after updating.

@marcaaron marcaaron removed their assignment Apr 18, 2022
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Apr 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 18, 2022

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MitchExpensify
Copy link
Contributor

Upwork Job

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 18, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 18, 2022

Triggered auto assignment to @marcochavezf (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Upgrade OnFido SDK to 6.20.0 [$250] Upgrade OnFido SDK to 6.20.0 Apr 18, 2022
@amyevans
Copy link
Contributor

Where does it need to be upgraded? Everywhere or only New Expensify?

I just searched for where we're using the package, and it looks like it's in Web-Secure in addition to App. So perhaps this should stay internal after all?

@michaelhaxhiu
Copy link
Contributor Author

cc @nkuoch or @chiragsalian for your input too, since you both were involved in the last SDK update for OnFido. Seems we still are uncertain about whether this is internal or external.

@melvin-bot melvin-bot bot added the Overdue label May 3, 2022
@marcochavezf
Copy link
Contributor

Not overdue, waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label May 4, 2022
@michaelhaxhiu
Copy link
Contributor Author

Should we be doubling price of this job @MitchExpensify ?

@MitchExpensify
Copy link
Contributor

Yes I will today @michaelhaxhiu

@MitchExpensify MitchExpensify changed the title [$250] Upgrade OnFido SDK to 6.20.1 [$500] Upgrade OnFido SDK to 6.20.1 May 5, 2022
@MitchExpensify
Copy link
Contributor

Doubled! Upwork Job

@Regaron
Copy link

Regaron commented May 6, 2022

Proposal

Looking at the change logs there doesn’t seem to be any breaking changes. So we can just update the packages and test for regressions.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 6, 2022
@jayeshmangwani
Copy link
Contributor

Proposal

it is a straightforward change of the updating package, need to update to the latest version of onfido-sdk-ui, as at this time it is 8.0.0, and then need to test in web and desktop , that update the package is working fine or not

@michaelhaxhiu michaelhaxhiu added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels May 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 6, 2022

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 6, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot
Copy link

melvin-bot bot commented May 6, 2022

Current assignee @marcochavezf is eligible for the Exported assigner, not assigning anyone new.

@michaelhaxhiu
Copy link
Contributor Author

michaelhaxhiu commented May 6, 2022

There is no C+ on this issue since Rushat un-assigned himself, so I'm triggering re-assignment.

@twisterdotcom twisterdotcom changed the title [$500] Upgrade OnFido SDK to 6.20.1 [$500] Upgrade OnFido SDK to 8.0.0 May 9, 2022
@twisterdotcom
Copy link
Contributor

twisterdotcom commented May 9, 2022

@jayeshmangwani is right, this is now 8.0.0. Updated the issue title and our internal tracker.

@michaelhaxhiu
Copy link
Contributor Author

This SDK seems to be updating pretty frequently, and consecutively each week... is this the norm? If so, I wonder if this is best handled internally after all?

@nkuoch
Copy link
Contributor

nkuoch commented May 9, 2022

I agree. I think whoever does Web-Secure internally could do App at the same time - it's not much more work.

@Santhosh-Sellavel
Copy link
Collaborator

Is this still external? or internal? @michaelhaxhiu

@michaelhaxhiu
Copy link
Contributor Author

@Santhosh-Sellavel I'm working on making this internal right now, based on the comments above.

@michaelhaxhiu
Copy link
Contributor Author

Sorry for the confusion on this GH @jayeshmangwani and @Regaron, we are closing this external job and will fix this internally instead. Thanks for your interest, feel free to browse other available jobs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests