[HOLD for payment 2022-08-11] [HOLD] [$1000] Web - Compose Box - In Minimize window one chat goes to the list of chats

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition - Must be already logged in to Expensify. Browser window must be fully maximized.
Should be two chats on the list + Concierge

1. Click on one chat first
2. Minimize the window as much as possible
3. Maximize the window
4. Click another chat
5. Minimize window

Expected Result:

When minimizing the window, the chat must stay in the browser to continue the conversation with the selected user.

Actual Result:

One chat stays active while minimizing the window, but the second chat exits to the list of all chats and there is no possibility to chat with the selected user anymore.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.57.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5553207_minimize_list_chat.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause (Exploratory)

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

Yeah this is a bit weird. The state that keeps track of the chat selector when collapsing the window to something minimized should prioritize showing the chat itself first instead of the selector if it both were visible before the resizing.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MitchExpensify]

Upwork Job

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mdneyazahmad]

Proposal

When dispatching a reset action we are not checking against correct history to find the drawer state and also on web default status is closed therefore we are setting the drawer state to open when navigating to report. As soon as we resize the window, it shows the drawer because of drawer state is open.

App/src/libs/Navigation/CustomActions.js

Lines 101 to 113 in 283569c

	const history = _.map(state.history ? [...state.history] : [screenRoute], () => screenRoute);
	// Force drawer to close
	// https://github.com/react-navigation/react-navigation/blob/94ab791cae5061455f036cd3f6bc7fa63167e7c7/packages/routers/src/DrawerRouter.tsx#L142
	const hasDrawerhistory = _.find(state.history || [], h => h.type === 'drawer');
	if (!hasDrawerhistory || currentState.type !== 'drawer') {
	history.push({
	type: 'drawer',
	// If current state is not from drawer navigator then always use closed status to close the drawer
	status: currentState.type !== 'drawer' || currentState.default === 'open' ? 'closed' : 'open',
	});
	}

-const hasDrawerhistory = _.find(state.history || [], h => h.type === 'drawer'); 
+const hasDrawerhistory = _.some(history || [], h => h.type === 'drawer'); 
 if (!hasDrawerhistory || currentState.type !== 'drawer') { 
     history.push({ 
         type: 'drawer', 
  
         // If current state is not from drawer navigator then always use closed status to close the drawer 
-        status: currentState.type !== 'drawer' || currentState.default === 'open' ? 'closed' : 'open', 
+        status: 'closed',
     }); 
 } 

More about it here #8657 (comment). It will fix that issue too.

[mdneyazahmad]

We may need to do some refactoring.

[aldo-expensify]

On hold, not overdue

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.87-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix combobox minimize #9706

If no regressions arise, payment will be issued on 2022-08-11. 🎊

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MitchExpensify]

Does it look like we ran into a regression here @aldo-expensify ?

[aldo-expensify]

Nop, the PR was reverted with this other #10101 to look for a more holistic/long term solution, so it couldn't have caused a regression.. the issue described in this GH issue is still happening, but it is of very little priority

More details on the decision to revert here: #8841 (comment)

[MitchExpensify]

got it! Paying based on this comment

[MitchExpensify]

Confirming in #contributor-management what price that should be - Asked here

[Santhosh-Sellavel]

Any update @MitchExpensify!

[MitchExpensify]

Bumped the Slack thread here for a buddy check.

[MitchExpensify]

Offer sent on the new Upwork post @Santhosh-Sellavel, mind applying for payment @mollfpr - Thank you

[mollfpr]

@MitchExpensify I already got the contract, just waiting to end the contract. Thanks!

[MitchExpensify]

Ah I thought the old expired job took the old contract with it, thanks for correcting me. On the old contract, it appears we've already paid out to you @mollfpr - Is that the case?

[MitchExpensify]

@Santhosh-Sellavel I've paid you using the old contract, no need to accept the new offer

[mollfpr]

@MitchExpensify Yup, it’s already paid.

[MitchExpensify]

Awesome! Looks like we are set here, thanks for your patience everyone!

[MitchExpensify]

I'll end both contracts now too

[MitchExpensify]

Done :)