Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow MacOS app download link to be copy from Right Hand Nav/Pane #8933

Closed
mvtglobally opened this issue May 11, 2022 · 12 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem:

When you want to share a link with someone to download the MacOS app, it's not possible to copy it from within the app

Solution:

Add the ability to right-click on macOS in App download links in About in Settings in Right Hand Nav/Pane

Action Performed:

  1. Navigate to Settings > About > App download links

Expected Result:

There should be the correct link to download desktop build (e.g. https://new.expensify.com/NewExpensify.dmg)

Actual Result:

Unable to copy via Desktop or Web (Chrome)

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.57-12
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-05-10T234016 584

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1652194232420029

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 NewFeature Something to build that is a new item. labels May 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2022

Triggered auto assignment to @strepanier03 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Overdue and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels May 11, 2022
@strepanier03
Copy link
Contributor

Oops, sorry for the hold up. This wasn't showing on my dashboard until it was overdue so I missed it. Looking now.

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2022
@strepanier03
Copy link
Contributor

I can see how this could be handy, not 100% sure of the value or difficulty in adding it though. Sending on for another opinion.

@melvin-bot
Copy link

melvin-bot bot commented May 13, 2022

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label May 16, 2022
@madmax330 madmax330 added the External Added to denote the issue can be worked on by a contributor label May 16, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@madmax330
Copy link
Contributor

should be pretty straightforward

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2022
@madmax330 madmax330 removed their assignment May 16, 2022
@Justicea83 Justicea83 self-assigned this May 16, 2022
@Justicea83
Copy link
Contributor

picking this up

@JmillsExpensify
Copy link

Nice! I'll hold off on posting to Upwork for the time being, but will keep myself assigned to the issue.

@Justicea83
Copy link
Contributor

I think we should be able to copy the links of all the items in the list, maybe the user just wanna share the link. In all cases the user already has the application installed so they might wanna share the urls with their friends.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2022

@JmillsExpensify, @Justicea83 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify
Copy link

Linked PR made it to production 4 days ago.

@JmillsExpensify
Copy link

This issue seems purely internal, so I'm going to close now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants