-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow MacOS app download link to be copy from Right Hand fix #9047
Allow MacOS app download link to be copy from Right Hand fix #9047
Conversation
Requesting another reviewer |
Gentle bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me I am just concerned if we need to have any visual change as well otherwise the default thinking would be to click the item right? as it also has an external link icon
so how would user now if they have an option of long press/right-click to copy the link?
In old dot in reports once we hover over the name it shows a tooltip that one can copy the email by clicking on the name. Is there something similar on new dot?
@techievivek this is a typical example. Since we already have this flow, it's not advisable to do something different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright then. Looks good from my end. Thanks
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @Justicea83 in version: 1.1.64-0 🚀
|
🚀 Deployed to production by @AndrewGable in version: 1.1.64-0 🚀
|
Details
Fixed Issues
$ #8933
Tests
PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Mobile Web
Desktop
iOS
Android